From nobody Wed Oct 29 22:58:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525837937249375.90658364346484; Tue, 8 May 2018 20:52:17 -0700 (PDT) Received: from localhost ([::1]:54286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG9I-00006g-Cz for importer@patchew.org; Tue, 08 May 2018 23:52:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG4V-0004P0-Ic for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGG4S-0002Tw-GZ for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:19 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33926) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGG4S-0002T0-CL for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:16 -0400 Received: by mail-qk0-x241.google.com with SMTP id p186so26492486qkd.1 for ; Tue, 08 May 2018 20:47:16 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w12-v6sm14497002qtb.80.2018.05.08.20.47.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 20:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vu1TXEsK3+H4qpumdJHo53uHjItrLRu/KlLqEeGbpNo=; b=Py0OsWbMU1IsjVgNJjYobgITjFEEpLsMheaGQ/bpBPasr0Xa+2TPxhAoBvBvk9mABw BOC0r0mYLCfLrzRaYMPDuy2T+ulPfrECbBnfg1mhzvS0+qPTt77UjnMU4382OVLbPYJo ZS1EmKYUBqtCnSXqCK3pp5NLgjQx7MAogVsP/rLy6PryaL7/n2J9U3RvkqYAAOgePUHH YrsLkzw5fb3qr7utKa6D240T03CYaOgbCtcnI6xm2CodebW8H+xUZ7h/nMQDzdq4gu5j Nue8eQMCxsbJ5kk08JQoM0VQyjQN6s2jvpXxWNZE/EUGECmwtL3aLACBiT81C5RvbcIQ SlnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vu1TXEsK3+H4qpumdJHo53uHjItrLRu/KlLqEeGbpNo=; b=DRE4ptmaUg3BwhYZMlMNgRp8pHsZJvD8eypfpJ8NzysElUDtfpv4URIxvBCSBPHduZ jJ2j41lk0zMO59rxE4KJ1FoiMscgpcvIPQrcv6dm9F5qfNt5WlOphNe0Le4DcRbXw/4L iyUwjqZoAGtPT7nUjU+Tto3Uw9QHodf7RuBAVCRUxxlZQETNedzPNg+omkYXyaWE7aTO iC1Y0p0UQirKx54J/YrLy0508udOnKTGgRt7whQ4bEWm0r/MwXYKQ0SfO3zsR7630bhf 4nsyhFzFiNhGXWYybBuvN361sp6//OyUOA4/GkAIBQxIPi5rT0AVG1QjGUYvmk6OzdEY hb0A== X-Gm-Message-State: ALQs6tBKOOLoWzODVfVRS5Rh4LKo2U8AKe9D93DGloqsyIsb/FCbXcMo +cQwrjglBiiIkt2R3oQYJGU= X-Google-Smtp-Source: AB8JxZp42GJTO4tjknYQMM8zK8Fm5axLW5GCCRBZSn6w4vyEQ7mEm0JnIJ1xqefxtjGRA+Ic4TC1/A== X-Received: by 10.55.111.196 with SMTP id k187mr23887708qkc.143.1525837635669; Tue, 08 May 2018 20:47:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Edgar E . Iglesias" Date: Wed, 9 May 2018 00:46:47 -0300 Message-Id: <20180509034658.26455-4-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509034658.26455-1-f4bug@amsat.org> References: <20180509034658.26455-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v2 03/14] sdcard: Fix sd_crc*() style X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Fix style to keep patchew/checkpatch happy when moving this code in the next patch. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sd.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index eb6dd5482e..27a70896cd 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -242,12 +242,14 @@ static uint8_t sd_crc7(const void *message, size_t wi= dth) uint8_t shift_reg =3D 0x00; const uint8_t *msg =3D (const uint8_t *)message; =20 - for (i =3D 0; i < width; i ++, msg ++) - for (bit =3D 7; bit >=3D 0; bit --) { + for (i =3D 0; i < width; i++, msg++) { + for (bit =3D 7; bit >=3D 0; bit--) { shift_reg <<=3D 1; - if ((shift_reg >> 7) ^ ((*msg >> bit) & 1)) + if ((shift_reg >> 7) ^ ((*msg >> bit) & 1)) { shift_reg ^=3D 0x89; + } } + } =20 return shift_reg; } @@ -259,12 +261,14 @@ static uint16_t sd_crc16(const void *message, size_t = width) const uint16_t *msg =3D (const uint16_t *)message; width <<=3D 1; =20 - for (i =3D 0; i < width; i ++, msg ++) - for (bit =3D 15; bit >=3D 0; bit --) { + for (i =3D 0; i < width; i++, msg++) { + for (bit =3D 15; bit >=3D 0; bit--) { shift_reg <<=3D 1; - if ((shift_reg >> 15) ^ ((*msg >> bit) & 1)) + if ((shift_reg >> 15) ^ ((*msg >> bit) & 1)) { shift_reg ^=3D 0x1011; + } } + } =20 return shift_reg; } --=20 2.17.0