From nobody Wed Oct 29 22:59:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525838147658794.9375574098643; Tue, 8 May 2018 20:55:47 -0700 (PDT) Received: from localhost ([::1]:54309 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGGCg-0003o8-PN for importer@patchew.org; Tue, 08 May 2018 23:55:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG52-0004qD-Vi for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGG52-0003YM-5Y for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:53 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:46600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGG52-0003Xj-0F for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:52 -0400 Received: by mail-qt0-x241.google.com with SMTP id m16-v6so43924257qtg.13 for ; Tue, 08 May 2018 20:47:51 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w12-v6sm14497002qtb.80.2018.05.08.20.47.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 20:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gfHCMg63bu7IfvVcBc7uLjFY3OafX1WdCVRJb6CT4Ag=; b=WMLwuduoY0PoAS50x+t9z7EK/K66OgOCW4g+JWmy27nKLkNWIhJwdTH/1IaVKA/e53 O+mDTOBvzUsOwSlSDLA7DizE+a1GYxbluLV3x8X1LmkEr2zV6GpOjdrabkmgdmBcq8LG ymGS7Jt6JL4o9WRqBKDhdMDMCDtenSKZIZdIpey+PdyWOKl/AmSMw7OE0GjfUtZxwv9S l/4fKbipJ9odfTqqM+3UpqQVN6TmXwiz0lC/ef9IbrBjtTzzouIzNsoCRAh+tLc+GQk5 agTmtt58kAKDrBqBrS/rl2c9g5vmKS9eJ924O++L7IMyAlZKvrIpff+NZFQS++Fbsl0z Je/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gfHCMg63bu7IfvVcBc7uLjFY3OafX1WdCVRJb6CT4Ag=; b=PI0nU9LUMOh28Im/H9JziDzyEwGvxcFJvKiOSBx2/BejsCyWBDwyz9Y1zzqSTm+YXO n8STUH1ozknfO/ghUkxIKH3Mi5GvS1cxvGlPcddD6XFPYLE6nuI2pRa46m5+b7HleDXH vhP3UMV1fUnM4UFKmfMAt9rUR4g3a6UxVTC4MeVTutgM7z2hGtK9XBpXYwgm75tkEIVT QuFWimwkle28/HP3sKIi1FvJtA2eZEjTpORHHVRz2oMV7uKpXl29gtgReRrdY0H5e5wl hrJfnmtTIV8ZBtrxB0AMAMpk+L6Y4enQiSb1zLGMzQZHCMd2RQyt4bCjdgefexBTwTQj sbjQ== X-Gm-Message-State: ALQs6tDAuyBXIpR6Ha7Lwp2RyG7mW5ufvbvtTjhtw8MVt61H10mh/DwN qyPDP5XdlmRMoxbINUi6eXQ= X-Google-Smtp-Source: AB8JxZrL913aR0aaH2rmY9HQ6kj3k6ekcVKGkh9Yoqt0WUkoa1nP9sWrn1iQ/BbqVjpsJHbK8JMINA== X-Received: by 2002:ac8:482:: with SMTP id s2-v6mr39634439qtg.144.1525837671354; Tue, 08 May 2018 20:47:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Edgar E . Iglesias" Date: Wed, 9 May 2018 00:46:58 -0300 Message-Id: <20180509034658.26455-15-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509034658.26455-1-f4bug@amsat.org> References: <20180509034658.26455-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [RFC PATCH v2 14/14] hw/sd/ssi-sd: Enable CRC validation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/ssi-sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 77e446bb94..0375f0b959 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -95,11 +95,11 @@ static uint32_t ssi_sd_transfer(SSISlave *dev, uint32_t= val) if (s->arglen =3D=3D 4) { uint8_t request[6]; uint8_t longresp[16]; - /* FIXME: Check CRC. */ =20 DPRINTF("CMD%d arg 0x%08x\n", s->cmd, ldl_be_p(s->cmdarg)); sd_frame48_init(request, sizeof(request), s->cmd, ldl_be_p(s->cmdarg), false); + request[5] =3D sd_frame48_calc_checksum(request); =20 s->arglen =3D sdbus_do_command(&s->sdbus, request, longresp); if (s->arglen <=3D 0) { @@ -257,6 +257,7 @@ static void ssi_sd_realize(SSISlave *d, Error **errp) qdev_prop_set_drive(carddev, "drive", blk_by_legacy_dinfo(dinfo), = &err); } object_property_set_bool(OBJECT(carddev), true, "spi", &err); + object_property_set_bool(OBJECT(carddev), true, "validate-crc", &err); object_property_set_bool(OBJECT(carddev), true, "realized", &err); if (err) { error_setg(errp, "failed to init SD card: %s", error_get_pretty(er= r)); --=20 2.17.0