From nobody Wed Oct 29 22:59:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525837977311370.4624636697439; Tue, 8 May 2018 20:52:57 -0700 (PDT) Received: from localhost ([::1]:54288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG9t-0000b1-A2 for importer@patchew.org; Tue, 08 May 2018 23:52:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG4y-0004nl-Uv for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGG4v-0003Lo-RX for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:49 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:38215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGG4v-0003LA-Mk for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:45 -0400 Received: by mail-qt0-x243.google.com with SMTP id m9-v6so23222198qtb.5 for ; Tue, 08 May 2018 20:47:45 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w12-v6sm14497002qtb.80.2018.05.08.20.47.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 20:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u1zCEGvuZ/Sf/oh4Wpn3Cb39XlfQ5FDh9GWXfpQE1sA=; b=kv5ddOPwU8abh2aegjR8Ab0Q8rhQNzxesRpex1zIPQAkHLmtyjWLnZANDfoTgjjOL/ QuF+qpaoEuHU7aAXiK631pVAWug/6iF+/EGmaCVJ0/YLJDum9OJPALPtVPRQ6bOZcHgw 33FxfRQkGbZP9RKXJxNkp5FeaM3r/JUvmGaeq0bDBUXCdty/MiO4Qx27zanieWlyaFrh mi6ycz6LQ+mX8odSSUs0Y/HylbuRddI2v5qKyqfZ6EXdLk32OQ/SQlYO1T3ggx24KXMr iJEMK0pj54cE+/XW6qYJRrkLofa6Z4NVxZOEQHvb205u1fUPqWzQNfNAqBBgjYafjmwL I17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=u1zCEGvuZ/Sf/oh4Wpn3Cb39XlfQ5FDh9GWXfpQE1sA=; b=FZUQl99j7TgR9oFXNIFrMdtTgFAzTAAahkqtabf3x/Gj258F0mvUhJ9SXu5OdMemDx pg6LMUcd1pbd81xLNIwnS9GkI56gQbTfbqqQTXMJtGCNJe4rpqyG3+DFmNzzb6/T6yuR voYlQj9EoEjzEQxiYOiSQC3Y0Kr+qo344bKKEiB9Euok0hioka/It5bP/ayfEgqkWrOG zQjDKu8BNSUBYAWt1RHqHP8P6f1a+Ry6evER3GxHwna7UHAEqmVA/NQ7tUMK5RB/AwzG S/yeeyJy1jQwfA+44NxwqOGeALyaKqyfM5pLT0A6PV4DHdW3FAojLdeSDwBsC399IzhD 8zeA== X-Gm-Message-State: ALQs6tAV/ROfIx5fQ7OCQJKPp4co9Jg4awtg8KPkZhDajQAWx+w2BY7a n5ArNxkdZsCPipr1R69RAnQ= X-Google-Smtp-Source: AB8JxZpliNYGuvthwMxzWc7TdGDJN/qd63AXpJLYSuTQxhjDx+NvrP7lMzPwiAmNaY5F09t8CFyLSQ== X-Received: by 2002:ac8:41cc:: with SMTP id o12-v6mr39234570qtm.227.1525837665071; Tue, 08 May 2018 20:47:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Edgar E . Iglesias" Date: Wed, 9 May 2018 00:46:56 -0300 Message-Id: <20180509034658.26455-13-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509034658.26455-1-f4bug@amsat.org> References: <20180509034658.26455-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v2 12/14] sdcard: Add tests to validate the 7-bit CRC checksum of 48-bit SD frame X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/sdcard-test.c | 74 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/tests/sdcard-test.c b/tests/sdcard-test.c index 81789d1f88..2288a05cdf 100644 --- a/tests/sdcard-test.c +++ b/tests/sdcard-test.c @@ -14,6 +14,66 @@ #include "libqtest.h" #include "hw/sd/sd.h" =20 +static void sd_prepare_request48(uint8_t *buf, size_t bufsize, + uint8_t cmd, uint32_t arg) +{ + sd_frame48_init(buf, bufsize, cmd, arg, /* is_resp */ false); + buf[5] =3D sd_frame48_calc_checksum(buf); +} + +static void sd_prepare_response48(uint8_t *buf, size_t bufsize, + uint8_t cmd, uint32_t arg) +{ + sd_frame48_init(buf, bufsize, cmd, arg, /* is_resp */ true); + buf[5] =3D sd_frame48_calc_checksum(buf); +} + +static void test_sd_request_frame_crc7(void) +{ + uint8_t req[6]; + + /* CMD0 */ + sd_prepare_request48(req, sizeof(req), 0, 0); + g_assert_cmphex(req[5], =3D=3D, 0b1001010); + + /* CMD17 */ + sd_prepare_request48(req, sizeof(req), 17, 0); + g_assert_cmphex(req[5], =3D=3D, 0b0101010); + + /* APP_CMD */ + sd_prepare_request48(req, sizeof(req), 55, 0); + g_assert_cmphex(req[5], =3D=3D, 0x32); + + /* ACMD41 SEND_OP_COND */ + sd_prepare_request48(req, sizeof(req), 41, 0x00100000); + g_assert_cmphex(req[5], =3D=3D, 0x5f >> 1); + + /* CMD2 ALL_SEND_CID */ + sd_prepare_request48(req, sizeof(req), 2, 0); + g_assert_cmphex(req[5], =3D=3D, 0x4d >> 1); + + g_assert_true(sd_frame48_verify_checksum(req)); +} + +static void test_sd_response_frame48_crc7(void) +{ + uint8_t resp[6]; + + /* response to CMD17 */ + sd_prepare_response48(resp, sizeof(resp), 17, 0x00000900); + g_assert_cmphex(resp[5], =3D=3D, 0b0110011); + + /* response to the APP_CMD */ + sd_prepare_response48(resp, sizeof(resp), 55, 0x00000120); + g_assert_cmphex(resp[5], =3D=3D, 0x41); + + /* response to CMD3 SEND_RELATIVE_ADDR (Relative Card Address is 0xb36= 8) */ + sd_prepare_response48(resp, sizeof(resp), 3, 0xb3680500); + g_assert_cmphex(resp[5], =3D=3D, 0x0c); + + g_assert_true(sd_frame48_verify_checksum(resp)); +} + static void test_sd_response_frame136_crc7(void) { uint8_t buf[16]; @@ -27,6 +87,17 @@ static void test_sd_response_frame136_crc7(void) g_assert_true(sd_frame136_verify_checksum(buf)); } =20 +static void test_sd_verify_cksum_frame48(void) +{ + uint8_t buf[6]; + + sd_prepare_request48(buf, sizeof(buf), 42, 0x12345678); + g_assert_true(sd_frame48_verify_checksum(buf)); + + sd_prepare_response48(buf, sizeof(buf), 69, 0x98765432); + g_assert_true(sd_frame48_verify_checksum(buf)); +} + static void test_sd_verify_cksum_frame136(void) { uint8_t buf[16]; @@ -40,7 +111,10 @@ int main(int argc, char *argv[]) { g_test_init(&argc, &argv, NULL); =20 + qtest_add_func("sd/prepare_req_crc7", test_sd_request_frame_crc7); + qtest_add_func("sd/prepare_resp48_crc7", test_sd_response_frame48_crc7= ); qtest_add_func("sd/prepare_resp136_crc7", test_sd_response_frame136_cr= c7); + qtest_add_func("sd/verify_cksum_frame48", test_sd_verify_cksum_frame48= ); qtest_add_func("sd/verify_cksum_frame136", test_sd_verify_cksum_frame1= 36); =20 return g_test_run(); --=20 2.17.0