From nobody Wed Oct 29 22:59:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525838255365818.9814152711502; Tue, 8 May 2018 20:57:35 -0700 (PDT) Received: from localhost ([::1]:54322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGGEQ-0005QO-JV for importer@patchew.org; Tue, 08 May 2018 23:57:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG4l-0004cu-SF for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGG4k-00033k-TL for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:35 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:37782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGG4k-00032c-Nl for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:34 -0400 Received: by mail-qk0-x242.google.com with SMTP id d74so26465926qkg.4 for ; Tue, 08 May 2018 20:47:34 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w12-v6sm14497002qtb.80.2018.05.08.20.47.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 20:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qJ3HzvrBAYqwSGhk5jUEba6GuYhU3LI0Gs4Dy/G0drI=; b=RZngEBDrRARzTG//H3hfsmfVPal0Ww/KjpmmQ6zMKohOpeC1S2wjYAYdY5WO+sLf8R qIj1yI93fk4N76SMuurnlafbco80MD0IVCniG3Vn4BntEAfHp75UG6TZQlmD6drYF9I4 amnSjMjUiKEEIvv6g2eMj3XQuQgDkvI8FGma1LLIZmG+MVGm4OIqoY6WrNzPTKCu6kyM b8WslLkET/Xxd2t8TDF3JlLs8EJYbbNFZk2Aeyql3Vj6BXc7B3fjDFoHMaxGNbnWoBas YGx+XDCNdZB2NINr+S8NvfAVN+FzggATj0Prixhk+T50ZQWAtYMNHD7G4n6YU4qgL4dv OQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qJ3HzvrBAYqwSGhk5jUEba6GuYhU3LI0Gs4Dy/G0drI=; b=jUWocxqzEhS80mEA8Hp/gSkNqnAhHPq/CEaitTkQFXkgVk1PNKghlSYzb1y08ThpXr 5TOjYnyS0jvUzcMJAhebaxLWER7CCCdOtLXlj+Otg+MnMyjbBkMtCtgxYo4l0/rOSE3Q +B9cfrJhh2bglNhqWoPN8itDrZW6mdHeADdjN+jgrxotWuWoG5koqVb8IIiPaGzQGXRt oTYcpy2p7Xgr06vfdwUf8Ucz205rg8jZVuYA1Hr7lZCBbvX9fdbHfR0GztixQkRg82mC 6wJ3ryOTSAD2o/i1ogpYhxC6fl8YAX1QttOcThk3zSpcdCfIIOu62yQT2rF1oRS1Ctcp hchA== X-Gm-Message-State: ALQs6tBaV1Hc3cdABeWuZKFXqqa602F6gsKmQgMMPrqI/WgUo7K+ukOF PTc6KUXraQsCuYPbYMwssEQ= X-Google-Smtp-Source: AB8JxZoiWOzbYmdIkHy50aPM4gKtSJ6zkDDh7vm7OaY18AiNQv6NQsiPsy1ga1AECaY8fHf8rBNCFQ== X-Received: by 10.55.144.7 with SMTP id s7mr36932433qkd.354.1525837654070; Tue, 08 May 2018 20:47:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Edgar E . Iglesias" Date: Wed, 9 May 2018 00:46:53 -0300 Message-Id: <20180509034658.26455-10-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509034658.26455-1-f4bug@amsat.org> References: <20180509034658.26455-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v2 09/14] sdcard: Add sd_frame136_verify_checksum() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/sd/sd.h | 10 ++++++++++ hw/sd/sdmmc-internal.c | 6 ++++++ tests/sdcard-test.c | 12 ++++++++++++ 3 files changed, 28 insertions(+) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index 752d8edd6c..83399cd42d 100644 --- a/include/hw/sd/sd.h +++ b/include/hw/sd/sd.h @@ -160,6 +160,16 @@ uint8_t sd_frame136_calc_checksum(const void *content); */ bool sd_frame48_verify_checksum(const void *content); =20 +/** + * sd_frame136_verify_checksum: + * @content: pointer to the frame content + * + * Verify the 7-bit CRC checksum of a 136-bit SD frame. + * + * Returns: A boolean indicating whether the frame 7-bit CRC is correct. + */ +bool sd_frame136_verify_checksum(const void *content); + /* Legacy functions to be used only by non-qdevified callers */ SDState *sd_init(BlockBackend *bs, bool is_spi); int sd_do_command(SDState *sd, SDRequest *req, diff --git a/hw/sd/sdmmc-internal.c b/hw/sd/sdmmc-internal.c index a9d19ce3eb..f709211401 100644 --- a/hw/sd/sdmmc-internal.c +++ b/hw/sd/sdmmc-internal.c @@ -111,3 +111,9 @@ bool sd_frame48_verify_checksum(const void *content) return sd_frame48_calc_checksum(content) =3D=3D ((const uint8_t *)content)[F48_CONTENT_LENGTH]; } + +bool sd_frame136_verify_checksum(const void *content) +{ + return sd_frame136_calc_checksum(content) + =3D=3D ((const uint8_t *)content)[F136_CONTENT_LENGTH]; +} diff --git a/tests/sdcard-test.c b/tests/sdcard-test.c index c59af28382..81789d1f88 100644 --- a/tests/sdcard-test.c +++ b/tests/sdcard-test.c @@ -23,6 +23,17 @@ static void test_sd_response_frame136_crc7(void) sizeof(buf)); buf[15] =3D sd_frame136_calc_checksum(buf); g_assert_cmphex(buf[15], =3D=3D, 0xad); + + g_assert_true(sd_frame136_verify_checksum(buf)); +} + +static void test_sd_verify_cksum_frame136(void) +{ + uint8_t buf[16]; + + memset(buf, 69, sizeof(buf)); + buf[15] =3D sd_frame136_calc_checksum(buf); + g_assert_true(sd_frame136_verify_checksum(buf)); } =20 int main(int argc, char *argv[]) @@ -30,6 +41,7 @@ int main(int argc, char *argv[]) g_test_init(&argc, &argv, NULL); =20 qtest_add_func("sd/prepare_resp136_crc7", test_sd_response_frame136_cr= c7); + qtest_add_func("sd/verify_cksum_frame136", test_sd_verify_cksum_frame1= 36); =20 return g_test_run(); } --=20 2.17.0