From nobody Wed Oct 29 11:37:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525805822894424.604059027158; Tue, 8 May 2018 11:57:02 -0700 (PDT) Received: from localhost ([::1]:52913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7nB-0001qo-3P for importer@patchew.org; Tue, 08 May 2018 14:56:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7ln-0001LY-Uh for qemu-devel@nongnu.org; Tue, 08 May 2018 14:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7lk-0002nF-Kf for qemu-devel@nongnu.org; Tue, 08 May 2018 14:55:27 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:38806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG7lk-0002mg-F1 for qemu-devel@nongnu.org; Tue, 08 May 2018 14:55:24 -0400 Received: by mail-pf0-x241.google.com with SMTP id o76so24392319pfi.5 for ; Tue, 08 May 2018 11:55:24 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id f1sm26536212pfn.52.2018.05.08.11.55.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 11:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=JD5Xcy+Rasc9or/ADB3Z35MCk+JNXECBZGrHr2UA2dM=; b=iGKyG/OPwTWToSlvPnlI4nmiPyA9n6G6ivj2QJerN/Nj7alN0Q4J80unMlMdgqyGFV 0jMf4kg/mEu47eEVQkwcKkx3i02Ekf8o9AEfJgnW3N0iAAZ94sdCimCnyUo+yFZYK0nJ eCewh5k/p3r2fn05AGzXWUJE6fW65I1I6pN8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JD5Xcy+Rasc9or/ADB3Z35MCk+JNXECBZGrHr2UA2dM=; b=VHmMGT/gQzybLUDJtcF1YTEgTOj1Ioj9L+ceglePf8LtJB4cFHUmS/JLLTBPO2hYYR 4YnWKpdjFjNpDRWDuWz2Pcl+/b+e4bRDK9BiNJB/SMpMWKWS6TG8yyN7D5cwCq7ZJDSD 0Oj8FoCxAZ6lUxl4xrCxPXXiL+0ENRfxaNMW6qV5ro5BaBa9g9Q4I7gyT3RhdXPZYfK8 XVgUO/6noce1KkFT9+Poxbqb768exRAynFXK0AWVa/WAZ7DG1APFHyo0LBt1qVWKczpE VklYDrHEz6aClFoHx+0eABDB4MRPmNCAdF6ghD5w8QhC0OSatuBE472J+obMJxvSRB/x DhZQ== X-Gm-Message-State: ALQs6tB529/UrIR0wmokzyTjkfP7ujG/lbay2gDBjIIuRPxDS44o7eCb W4fKZtdTRAseXbfzQBTsTAhWPrj5bQk= X-Google-Smtp-Source: AB8JxZp8VxoRDrpwAD+6d4gqNGGzHca1tlBxkdZxSL4y4mjzKHVjO+ZV6UWz8qgH2TPRGtA5RqzLPQ== X-Received: by 2002:a63:6c04:: with SMTP id h4-v6mr34192928pgc.220.1525805722701; Tue, 08 May 2018 11:55:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 11:55:20 -0700 Message-Id: <20180508185520.23757-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fedora 28 ships with the released gcc 8. The Werror stems from the compiler finding a path through the second switch via a missing default case in which src1 is uninitialized, and not being able to prove that the missing default case is unreachable due to the first switch. Simplify the second switch to merge default with OS_LONG, which returns directly. This removes the unreachable path. Cc: Laurent Vivier Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier --- target/m68k/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index e407ba2db3..44a0ac4e2e 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -2297,7 +2297,7 @@ DISAS_INSN(arith_im) im =3D tcg_const_i32(read_im32(env, s)); break; default: - abort(); + g_assert_not_reached(); } =20 if (with_SR) { @@ -2317,7 +2317,8 @@ DISAS_INSN(arith_im) } src1 =3D gen_get_sr(s); break; - case OS_LONG: + default: + /* OS_LONG; others already g_assert_not_reached. */ disas_undef(env, s, insn); return; } --=20 2.17.0