From nobody Thu Oct 30 15:20:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525800952577760.83085638961; Tue, 8 May 2018 10:35:52 -0700 (PDT) Received: from localhost ([::1]:52568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6Wl-0002G5-J5 for importer@patchew.org; Tue, 08 May 2018 13:35:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6T2-00081U-2M for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG6T0-0005Fc-2R for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:00 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:38801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG6Sz-0005FJ-R9 for qemu-devel@nongnu.org; Tue, 08 May 2018 13:31:58 -0400 Received: by mail-lf0-x244.google.com with SMTP id z142-v6so3769917lff.5 for ; Tue, 08 May 2018 10:31:57 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id z10-v6sm4881148lfj.50.2018.05.08.10.31.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 10:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cvKXuJIGSe9L4JbNRWWwCBBbmA10rjD3l64OCmr1iVw=; b=rcHUiMnPLQOGRDUUEtbxILuJlXmV27bUEcH8/PyNQMvwBPgtCAgcIX23PhLQi1kgIQ ku4dJ3aRsu+Q+X2+2NwEiCE1QwY+HmQ/UbmhOvWYGJwVu+SP001d4Rrf9SP8y+b1YXuL nOzGG/a59CWdSkE0cnLLPbSPerFmNZqkv7phOhADcXsm7VIu8LH6ji1Kxbpu9Phzmeg8 CTK/pXztY3ENGCqxnJ/mRpsl21npMGWsS8ICBbvtQv5Qnp5ZoI+N2xbKPTEjKnzkLnAn y6VSa9xsabWcyRYytompIA3oThytDzQndlJytiFeS1gDXad+UTvnVMTtNhDzcTWvkl8+ bjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cvKXuJIGSe9L4JbNRWWwCBBbmA10rjD3l64OCmr1iVw=; b=jhb6qSBj3BKaHUPuHDPeuneC062u1TKkZ/LBMT9BSQKIZkFHSRR4ksVHPZq5wqtgGS 0yCzxArEv3Xq7p0DtMXnJtivqibuWIP8PEqHOAsiLUKReBowDyYwBJUXiOo4eHCLHgJW rRknJ6HgYuqiCE58N6757JW7qth54OIVYMygAmVHtI5ME8KZocuC2Pfm50Daku/2ArmG Lh1Sbhm/AH4SU9UaZ6twps2ne3wAJGtAqtWhnwBKSCXbLyZjjIiCi3eLrit8MQZJxtVL BO+zNSlD5w6WemIIFFbiZUxhUe/IPM7zG3XMqq9rz9bhYLwy/ZOO53rqq/0kwnvyFU80 uNVQ== X-Gm-Message-State: ALQs6tD03GzUI6roUyfGLa9LbAi7RUCmXvfKa7+RZk/lqKz7g/wzzl6K jM2CcwKSySBK/mv+9Baxyl1zRg== X-Google-Smtp-Source: AB8JxZq6xPZHs4KXU2w9TPZQ9x3RHieYk8KIiTx9mUPw6N5a7djeJwvCPxBhym3jTrBTkpiSKuMyJw== X-Received: by 2002:a2e:3112:: with SMTP id x18-v6mr14282988ljx.107.1525800716317; Tue, 08 May 2018 10:31:56 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 19:31:17 +0200 Message-Id: <20180508173152.29327-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180508173152.29327-1-edgar.iglesias@gmail.com> References: <20180508173152.29327-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v2 01/36] target-microblaze: dec_load: Use bool instead of unsigned int X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 100883e2cc..33f21aa5b7 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -897,14 +897,15 @@ static inline TCGv *compute_ldst_addr(DisasContext *d= c, TCGv *t) static void dec_load(DisasContext *dc) { TCGv t, v, *addr; - unsigned int size, rev =3D 0, ex =3D 0; + unsigned int size; + bool rev =3D false, ex =3D false; TCGMemOp mop; =20 mop =3D dc->opcode & 3; size =3D 1 << mop; if (!dc->type_b) { - rev =3D (dc->ir >> 9) & 1; - ex =3D (dc->ir >> 10) & 1; + rev =3D extract32(dc->ir, 9, 1); + ex =3D extract32(dc->ir, 10, 1); } mop |=3D MO_TE; if (rev) { --=20 2.14.1