From nobody Thu Oct 30 15:21:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525801918093436.8311406775414; Tue, 8 May 2018 10:51:58 -0700 (PDT) Received: from localhost ([::1]:52666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6mG-0003xb-Mt for importer@patchew.org; Tue, 08 May 2018 13:51:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6TQ-0008OK-Kz for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG6TP-0005S9-RO for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:24 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:43841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG6TP-0005RW-JA for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:23 -0400 Received: by mail-lf0-x241.google.com with SMTP id g12-v6so47036263lfb.10 for ; Tue, 08 May 2018 10:32:23 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id y23-v6sm4345801ljh.88.2018.05.08.10.32.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 10:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GHwqzpKtMLCmGIl0nECA1Z2NfinN2rmVe/P30yNIOaY=; b=DUvdlRZLILQ1hOj2SnAe+mU6DM+D1wMiYeIc6n2n27eVEbp8W2UR2xZEN5H8g1ygJN +nsh7I6/+Z77pnGPyyJR5nPW3G+QUq9uhR1pl4CxU1LHELH2kFDumy13D0lofNJO9h8m phjxeI6BeCJIRKtMM3U0oadxkqoGN+dkwyGJa3eI7n4+Y7ETJCP7xk3E3TosUTYkjoGV jMxwMQwzb1OCVYmEL+LfpwX9ppRwMbYL0PE5JoKirDb0+2iG7w/Zgxf72hXMeCFHkkpq rg8BvRsuUXYpoD3YL3Av2zHiFEzDi87Rk/It+CaL4g23NJOpC14hNHwIjKRQIgUFAciU cP2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GHwqzpKtMLCmGIl0nECA1Z2NfinN2rmVe/P30yNIOaY=; b=HVCbpJz1Z7Un9dTUxKlJbuTZvdcp5W1wE7tfpzMppSLoVqp/5kgUVQ/EU1x0zw4peP O8vWS4c72OtvyK5rCa1yRx3EcY+8vwsgybe7XMM2y8ihFEDbs2TC0OW+h3lPowZkD+P6 ezYKT2n1EWKOlz/opdjZjv9e/Nr8Zi4W/9iwLOba4dYNYwUlGVsTq/kN7mdyV+HM0RgZ oCum6NZv2MrqvcWzF9c9WNc41qtFkfDyw4PgQWZP9d7dIoOvfmziYcEI0MaSAoQtn5tW kTwzTTk7opySuLyIAfx4EAOd9Ku3MYZvR/nL7hAeOjO0Oi/qdglFWQGfntfaT4pRyHtn 7CCQ== X-Gm-Message-State: ALQs6tDGNLto6vVxx4z0pNJ9IbiztDWfhJfuCsFj2wAj9Vvs6jxEobJK PINBDg5eQIHy/x98aGpd5qS22g== X-Google-Smtp-Source: AB8JxZr1thDdzVjm9djng0xFV3hE2puQD2MxzFtF1mpS3yG1e+DU4F1Nq044+MQmwgQjeWcsqRvlww== X-Received: by 2002:a19:6d02:: with SMTP id i2-v6mr27960540lfc.81.1525800742014; Tue, 08 May 2018 10:32:22 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 19:31:34 +0200 Message-Id: <20180508173152.29327-19-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180508173152.29327-1-edgar.iglesias@gmail.com> References: <20180508173152.29327-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v2 18/36] target-microblaze: dec_msr: Reuse more code when reg-decoding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Reuse more code when decoding register numbers. No functional changes. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 38 +++++++++----------------------------- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 0593aff692..0582568992 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -531,11 +531,9 @@ static void dec_msr(DisasContext *dc) case 1: msr_write(dc, cpu_R[dc->ra]); break; - case 0x3: - tcg_gen_mov_i32(cpu_SR[SR_EAR], cpu_R[dc->ra]); - break; - case 0x5: - tcg_gen_mov_i32(cpu_SR[SR_ESR], cpu_R[dc->ra]); + case SR_EAR: + case SR_ESR: + tcg_gen_mov_i32(cpu_SR[sr], cpu_R[dc->ra]); break; case 0x7: tcg_gen_andi_i32(cpu_SR[SR_FSR], cpu_R[dc->ra], 31); @@ -562,17 +560,11 @@ static void dec_msr(DisasContext *dc) case 1: msr_read(dc, cpu_R[dc->rd]); break; - case 0x3: - tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_EAR]); - break; - case 0x5: - tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_ESR]); - break; - case 0x7: - tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_FSR]); - break; - case 0xb: - tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_BTR]); + case SR_EAR: + case SR_ESR: + case SR_FSR: + case SR_BTR: + tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[sr]); break; case 0x800: tcg_gen_ld_i32(cpu_R[dc->rd], @@ -582,19 +574,7 @@ static void dec_msr(DisasContext *dc) tcg_gen_ld_i32(cpu_R[dc->rd], cpu_env, offsetof(CPUMBState, shr)); break; - case 0x2000: - case 0x2001: - case 0x2002: - case 0x2003: - case 0x2004: - case 0x2005: - case 0x2006: - case 0x2007: - case 0x2008: - case 0x2009: - case 0x200a: - case 0x200b: - case 0x200c: + case 0x2000 ... 0x200c: rn =3D sr & 0xf; tcg_gen_ld_i32(cpu_R[dc->rd], cpu_env, offsetof(CPUMBState, pvr.regs[rn])); --=20 2.14.1