From nobody Thu Oct 30 15:21:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525801037764171.5959219466514; Tue, 8 May 2018 10:37:17 -0700 (PDT) Received: from localhost ([::1]:52580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6Y8-0003VM-Tp for importer@patchew.org; Tue, 08 May 2018 13:37:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG6TC-0008AF-So for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG6TC-0005KO-0t for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:10 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:40284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG6TB-0005K6-Ov for qemu-devel@nongnu.org; Tue, 08 May 2018 13:32:09 -0400 Received: by mail-lf0-x244.google.com with SMTP id p85-v6so11648838lfg.7 for ; Tue, 08 May 2018 10:32:09 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id q18-v6sm4520433lfi.97.2018.05.08.10.32.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 10:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F8YuqPcoMlrPY8X1uzL8nO/RxQ4DLnZlQjO6I/YPEDc=; b=R1KZSn5CWbugwMR95BTgsiNDos0zeILqm9z0HEkbOI3e7nYHNXA8a4Mbfim66XS2uT 7LSG7PeWcp7o2BnvKyWwAKkXICAb5xe3ot+3AAcfA2I7ABbhgB0u9BlQunpZMxFlWUpQ /00t30eB4reSdaWH0OO3+tf+V63s+PQu8/zEEZkkUr/auq9l97u70sfa5bSMvDEakwK6 2kzeysheP8+5pY4I88nWrYgkySWCV9IdJN1tbyq/9diRPixM+mmy5fJJsNRuuLE35cnW saXiGHjjQBJf70N64Qg+3F3XPbbEnPlyzfqbEms87mRVTI74A9u2eDtsQ0L8xN+M3Pgy A1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F8YuqPcoMlrPY8X1uzL8nO/RxQ4DLnZlQjO6I/YPEDc=; b=B6kuHlh5phXqGGvcTqpzaH8u5evqSDO5AbDd86SNbOp3sNTeiGQ6V8JIwwRAudeodA wfN1RFWrj42in7+cMHTZXvIt5JiZ1RYbGRBlAKf/299RZpD915aKE0ElJHb/rX04+uUr 5csAv+JmTe4MFZyvue00eBJgtvvcXuBz4qXiTSzNsOTSLJdQ5qGzmywZftRY9TzeLJFY BYZkt40u7N+VuckmwHp8PPSe3TyEduWbFOZKOK7ifu2qD39iEwey/yRs6ppe0Z4Pot/0 YiADe5f7dQEiiqd2qXYIg09ejesiQLDrGSGCHCVTsn0m1ylI9c+ElWRSl5AjfrIvlTaK gy2Q== X-Gm-Message-State: ALKqPwcW1qc1eqEYsHKpg3YcOTIEdNVVUpOxyJxtf5v1Sr41IGNkMu8q uRkjdxPBX1XR4NmShLw1x8i9tQ== X-Google-Smtp-Source: AB8JxZrSTzPMHxA6yA4Xgc1lfDTWP6Iw/s4MG+1ti6eO7Qw2sPN6Lm21mjtCVNqQ7keTUlS1ehkjmQ== X-Received: by 2002:a19:c48f:: with SMTP id u137-v6mr6029693lff.2.1525800728278; Tue, 08 May 2018 10:32:08 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 19:31:25 +0200 Message-Id: <20180508173152.29327-10-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180508173152.29327-1-edgar.iglesias@gmail.com> References: <20180508173152.29327-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v2 09/36] target-microblaze: Conditionalize setting of PVR11_USE_MMU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Conditionalize setting of PVR11_USE_MMU on the use_mmu CPU property, otherwise we may incorrectly advertise an MMU via PVR when the core in fact has none. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 06476f6efc..6fdf0fd223 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -201,7 +201,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) PVR5_DCACHE_WRITEBACK_MASK : 0; =20 env->pvr.regs[10] =3D 0x0c000000; /* Default to spartan 3a dsp family.= */ - env->pvr.regs[11] =3D PVR11_USE_MMU | (16 << 17); + env->pvr.regs[11] =3D cpu->cfg.use_mmu ? PVR11_USE_MMU : 0 | + 16 << 17; =20 mcc->parent_realize(dev, errp); } --=20 2.14.1