From nobody Wed Oct 29 11:33:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525712079787473.1545630576861; Mon, 7 May 2018 09:54:39 -0700 (PDT) Received: from localhost ([::1]:47170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFjPL-0002mA-27 for importer@patchew.org; Mon, 07 May 2018 12:54:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFjNq-0001oQ-F3 for qemu-devel@nongnu.org; Mon, 07 May 2018 12:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFjNn-0005EW-Bv for qemu-devel@nongnu.org; Mon, 07 May 2018 12:53:06 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:41377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFjNn-0005Dr-7K; Mon, 07 May 2018 12:53:03 -0400 Received: by mail-qt0-x244.google.com with SMTP id g13-v6so37167095qth.8; Mon, 07 May 2018 09:53:03 -0700 (PDT) Received: from Power8-A.ELDORADO (ipe-tel-fw.eldorado.org.br. [200.168.210.66]) by smtp.gmail.com with ESMTPSA id q8-v6sm19364882qtb.13.2018.05.07.09.52.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 09:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XBMDx1htcjaFbu1Nz57vaqndISnkk+ntHzBxCRd3YH8=; b=bn7qk8Veg2+5qS0NJRe7vBSo+Xp/qvlW9L1DAZq1ajhJN9Uig+wRAt9US5BMzAzdza ZaD70EgRR1/j5gQZ4kucYzu2JTbxtGGxX+/WgwStc+ciYcm4g/8MsBH7reDsCGWYyG0h dvuruYOlRs0cpb9pmz41xm83FAgM5ce6S7RSKfKopW+1LkGO5E3+vbCbvzF6FtwxbbN0 N0ElSBwch6SxLzpGNlO6OFr8YRcPnpx7qoo1HDKiyn6YuPcrN3oyN8L7xmO+XAppa8nu ZVXL76pa45mp4ykJ2EqkjZx0lC4KNKDSwgKcUnGzgD/OTSzChW6thJX8PtlyX9idHKxS FDfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XBMDx1htcjaFbu1Nz57vaqndISnkk+ntHzBxCRd3YH8=; b=gEnV2u+3uJRuCmWJqX4tvoF2JNiSIwpH3I37sZ4S6ut1ofq/QtbrlX67c8mIquFvFS 6xQTP/dQReYTs6nK+GlYnIH88/0LV1/O0zbG1kKpIpQpp4KPFBVbOXbj6sj6sFJ5FxeW 6yM80Ezfnwxp6o+n8zAkVR45s1tP1M7JCDHKQr1et0MGIvOLrlPGIVCK8Hl0ZZST7kly +R6zQ+xNdC/UHG6q4TKNmOxjY8h23K31LQsaV9uD5l9BxlwAtEvstCxbQpG4IY1Va9vd fpalofrtlgsW03bZsaroTQI2L8NFiqXkaCnsj5WcIejqjU6F9VWD6PnndiqALzJLpc04 E3Aw== X-Gm-Message-State: ALQs6tDTvwmkFAKIrf51hLIO5RvDb9tr1Ya/Yynk1IRLZz5IJd37hPu8 HM5x4u5rLrHKIfesZUSkDw3nfYZY X-Google-Smtp-Source: AB8JxZq/VL2awGyoc2r/AjmbFMZ8j2rCPzIwqYQwukdN/9XI5ddo6Yn/52Dl0bNM96OqL3n/fJST7A== X-Received: by 2002:a0c:d1f1:: with SMTP id k46-v6mr18716543qvh.58.1525711982086; Mon, 07 May 2018 09:53:02 -0700 (PDT) From: luporl To: qemu-devel@nongnu.org Date: Mon, 7 May 2018 13:52:42 -0300 Message-Id: <20180507165242.46502-1-leandro.lupori@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180507180835.4b7b9222@bahia.lan> References: <20180507180835.4b7b9222@bahia.lan> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v3] target/ppc: Allow PIR read in privileged mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: luporl , qemu-ppc@nongnu.org, Alexander Graf , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" According to PowerISA, the PIR register should be readable in privileged mode also, not only in hypervisor privileged mode. PowerISA 3.0 - 4.3.3 Processor Identification Register "Read access to the PIR is privileged; write access is not provided." Cc: David Gibson Cc: Alexander Graf Cc: qemu-ppc@nongnu.org Signed-off-by: Leandro Lupori Reviewed-by: Jose Ricardo Ziviani Reviewed-by: Greg Kurz --- Changes in v2: - added my Signed-off-by, maintainers CC and Jose's Reviewed-by tags Changes in v3: - added subsystem name, version tag and summary of changes - added the section of PowerISA that describes PIR access privileges target/ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c index a72be6d121..7b56e3ffb9 100644 --- a/target/ppc/translate_init.c +++ b/target/ppc/translate_init.c @@ -7816,7 +7816,7 @@ static void gen_spr_book3s_ids(CPUPPCState *env) /* Processor identification */ spr_register_hv(env, SPR_PIR, "PIR", SPR_NOACCESS, SPR_NOACCESS, - SPR_NOACCESS, SPR_NOACCESS, + &spr_read_generic, SPR_NOACCESS, &spr_read_generic, NULL, 0x00000000); spr_register_hv(env, SPR_HID0, "HID0", --=20 2.11.0