From nobody Wed Oct 29 11:38:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525375330635501.4133785945861; Thu, 3 May 2018 12:22:10 -0700 (PDT) Received: from localhost ([::1]:58465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEJnp-0002td-1Z for importer@patchew.org; Thu, 03 May 2018 15:22:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEJmV-00025S-JE for qemu-devel@nongnu.org; Thu, 03 May 2018 15:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEJmR-0000fw-Lp for qemu-devel@nongnu.org; Thu, 03 May 2018 15:20:43 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53270 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEJmR-0000ds-G7 for qemu-devel@nongnu.org; Thu, 03 May 2018 15:20:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75E5781A327D for ; Thu, 3 May 2018 19:20:36 +0000 (UTC) Received: from link.redhat.com (ovpn-121-163.rdu2.redhat.com [10.10.121.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5719A2024CA1; Thu, 3 May 2018 19:20:36 +0000 (UTC) From: Bandan To: qemu-devel@nongnu.org Date: Thu, 3 May 2018 15:20:28 -0400 Message-Id: <20180503192028.14353-3-bsd@redhat.com> In-Reply-To: <20180503192028.14353-1-bsd@redhat.com> References: <20180503192028.14353-1-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 03 May 2018 19:20:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 03 May 2018 19:20:36 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bsd@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 2/2] usb-mtp: Unconditionally check for the readonly bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Bandan Das Currently, it's only being checked if desc is NULL and so write support breaks upon specifying desc Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 24cff640c0..3d59fe4944 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1948,16 +1948,17 @@ static void usb_mtp_realize(USBDevice *dev, Error *= *errp) return; } s->desc =3D strrchr(s->root, '/'); - /* Mark store as RW */ - if (!s->readonly) { - s->flags |=3D (1 << MTP_FLAG_WRITABLE); - } if (s->desc && s->desc[0]) { s->desc =3D g_strdup(s->desc + 1); } else { s->desc =3D g_strdup("none"); } } + /* Mark store as RW */ + if (!s->readonly) { + s->flags |=3D (1 << MTP_FLAG_WRITABLE); + } + } =20 static const VMStateDescription vmstate_usb_mtp =3D { --=20 2.11.0