From nobody Mon Feb 9 01:49:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525339859211872.420169292186; Thu, 3 May 2018 02:30:59 -0700 (PDT) Received: from localhost ([::1]:54892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEAZm-00026C-Fi for importer@patchew.org; Thu, 03 May 2018 05:30:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEAPK-0001Dt-7x for qemu-devel@nongnu.org; Thu, 03 May 2018 05:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEAPG-0005Cy-9B for qemu-devel@nongnu.org; Thu, 03 May 2018 05:20:10 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:44147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEAPG-0005CW-0o for qemu-devel@nongnu.org; Thu, 03 May 2018 05:20:06 -0400 Received: by mail-lf0-x242.google.com with SMTP id h197-v6so24879963lfg.11 for ; Thu, 03 May 2018 02:20:05 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id z184-v6sm2700960lfa.55.2018.05.03.02.20.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 02:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LuNcbqSjKxB1BfScpas0UwL9xk+DXRuan/kipFw620k=; b=ESGbYEa3oZYSfKjXzw6IOW78CJIGDeniz/M8R3QH61aCQ7EgxkqScL1N04ogC8KbUP SdfN5EFEaEkDsqzl8GHPt7ENxoQMyPVcWddiESa717yK0mxIPAKrDz+aZu+JnWrpKAg5 /AAu36lTTpIevJfmZu94ifOLwNHvsQ+bko4XTH2ki2s05MurgtDL3v2qNvYzE/blvnhu SgIGsK4eTosAnW7FZ6PuT5Dg0DJvsCJBVxh/cRMIwjBZ7g1QQPsfqGadD6F+kAC/aQDU Bwl0m+hhedyTTINx4ZPV4kW3KdIp2wQIzPca5Rud4ceJXnXKctwkZojE8veaNdrMq5BG r/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LuNcbqSjKxB1BfScpas0UwL9xk+DXRuan/kipFw620k=; b=RYz/KrTWiK6h0hq+7tYbobBix+cjQx/Wb5wsrL+OTEc7oYFswsejOqYl99CUaIe4qP BxuUpFLCsh5QoTBk1lPiCoxmyj3orta0tr3+0XZafEsy1+YH9T0VpLOs5pchIwBl6q79 phlCM4MPJ2+++1+8nzah+d4dSE2NCeEuOjGFmhHai6oKjMgdM+jYAA6tmPoi+QeebsGI Om2MoB4g9Gu+hmqfb12WyKjSAfnW3cHvrZu3xP5h5/6Ao1rDnbnbPaY+rYx7OunOBrWj ppS8SU0dnUU1DP2nXFz2rd7dcXoym/etYNEAU8z4V3iR/9P7X0K6fVQAF20YGG8baFk2 GS7Q== X-Gm-Message-State: ALQs6tBYyGcHR0A6gEdvhuF99saub0L0NBkU5RpJL7DTcO3UqOmbbu0H jpcqQIXn1ZgQa6+RLkbvblHcSw== X-Google-Smtp-Source: AB8JxZol/d0OzBjb9jNZbmUGFLtu4kIujOj9OwAHQZb8eFs9QzZuN3fkwO+Sqg0HXZEU1hMDW/a2pw== X-Received: by 2002:a19:ec0a:: with SMTP id b10-v6mr14648398lfa.31.1525339204447; Thu, 03 May 2018 02:20:04 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 3 May 2018 11:19:18 +0200 Message-Id: <20180503091922.28733-26-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180503091922.28733-1-edgar.iglesias@gmail.com> References: <20180503091922.28733-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PATCH v1 25/29] target-microblaze: mmu: Remove unused register state X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add explicit handling for MMU_R_TLBX and log accesses to invalid MMU registers. We can now remove the state for all regs but PID, ZPR and TLBX (0 - 2). Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 7 +++++-- target/microblaze/mmu.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index f4a4c339c9..231803ceea 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -211,11 +211,14 @@ uint32_t mmu_read(CPUMBState *env, uint32_t rn) } r =3D env->mmu.regs[rn]; break; + case MMU_R_TLBX: + r =3D env->mmu.regs[rn]; + break; case MMU_R_TLBSX: qemu_log_mask(LOG_GUEST_ERROR, "TLBSX is write-only.\n"); break; default: - r =3D env->mmu.regs[rn]; + qemu_log_mask(LOG_GUEST_ERROR, "Invalid MMU register %d.\n", r= n); break; } D(qemu_log("%s rn=3D%d=3D%x\n", __func__, rn, r)); @@ -298,7 +301,7 @@ void mmu_write(CPUMBState *env, uint32_t rn, uint32_t v) break; } default: - env->mmu.regs[rn] =3D v; + qemu_log_mask(LOG_GUEST_ERROR, "Invalid MMU register %d.\n", r= n); break; } } diff --git a/target/microblaze/mmu.h b/target/microblaze/mmu.h index 113539c6e9..624becfded 100644 --- a/target/microblaze/mmu.h +++ b/target/microblaze/mmu.h @@ -67,7 +67,7 @@ struct microblaze_mmu /* We keep a separate ram for the tids to avoid the 48 bit tag width. = */ uint8_t tids[TLB_ENTRIES]; /* Control flops. */ - uint32_t regs[8]; + uint32_t regs[3]; =20 int c_mmu; int c_mmu_tlb_access; --=20 2.14.1