From nobody Sun Feb 8 19:39:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525118654214308.1783384457219; Mon, 30 Apr 2018 13:04:14 -0700 (PDT) Received: from localhost ([::1]:33158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDF1w-0004wo-4K for importer@patchew.org; Mon, 30 Apr 2018 16:04:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEzn-0003jo-MZ for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:02:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEzm-0005sU-UY for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:59 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:40091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDEzm-0005rz-Oi for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:58 -0400 Received: by mail-wr0-x243.google.com with SMTP id v60-v6so9125600wrc.7 for ; Mon, 30 Apr 2018 13:01:58 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id u35-v6sm8455997wrc.29.2018.04.30.13.01.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 13:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PaWrojOQmXRWjeKvLmvqU8f87sNMplBW385V/J255mw=; b=cy7wkZMiWhNXd32BrUq0lSn9DJU5WsmyEXXujNONbLNo5CE5KYIknkfPIhnifJp/pR idqvTiqUfR7Rk+fJFysJPmZo4NGla9C38SkHjMHFI5xRAXvjiEYwOHQ/iv+040k2h5Sk GZ0JKN6t0V2UFJ47UGLXPvY92U/CcZRMuelKBdiXWL8f9QxoXH21SzCk/3x5aAlKXMnr Vg7/4+nqruNwvUa97EzaM+DePcT9yraQrtPBA9xRFGBDaRqvxp/ZPDRk5pe3pbyf5Xbt XMzo5/356o7HgUCzsCjitM69imfnd2he0gj6FjRca/1dnKDnF5eiN1qI1GfWeVbORwR8 Xuwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PaWrojOQmXRWjeKvLmvqU8f87sNMplBW385V/J255mw=; b=FVEdcva46pubhX2uCWOUG8EI5iWcv+Yq2lhFIq+8yxWvVBj7DULjRVWpxf/oCmlrcr f1pOC4byyx7FXuFWR8JNGZnjzwL1K/ARzlSQ+G3tQLnlx0+6fyXcSc85Qtv1g6OrrZT3 OkjrOstyGKYrvq+NCJjsDdq3kVldf1NmRyN1DkQqmZkBv8l3ADy7FXOC1gV52fZPL8o7 hgxAkXGRc1DK55oiInP1WufRM3Yf9zCZqnzZnOo2Sz2gJRMoq/lDFPjUlunwiEyunGbF JpNL0aehX4odB/r3W9iaSXtU2HvDWUFJNVL6LvrE6IxETN3zrOAKKl0CK7LXmz+G7MEE ChHg== X-Gm-Message-State: ALQs6tBvPHXXNpLpEQVfIWeiZWiRHoxqxVWfa7GsZ+0SEMRIl2olMC7G eWzXD368iHejiQUED7oeLQiOhQ== X-Google-Smtp-Source: AB8JxZrL5dNTLZTyZzmc95DR7dRGmVLzq5kFVAqYGJ9KVZdoOUbi2bK3RhkWQFCQlSv+UTEmNOi6rA== X-Received: by 2002:adf:e447:: with SMTP id t7-v6mr9720946wrm.143.1525118517488; Mon, 30 Apr 2018 13:01:57 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 23:02:19 +0300 Message-Id: <20180430200223.4119-4-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> References: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH 3/7] hw/rdma: Delete port's pkey table X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yuval Shaia Support for PKEY is not yet implemented. Removing the unneeded table until a support will be added. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm_defs.h | 3 +-- hw/rdma/vmw/pvrdma_main.c | 15 --------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/hw/rdma/rdma_rm_defs.h b/hw/rdma/rdma_rm_defs.h index fc646da61f..45503f14e0 100644 --- a/hw/rdma/rdma_rm_defs.h +++ b/hw/rdma/rdma_rm_defs.h @@ -21,7 +21,7 @@ #define MAX_PORTS 1 #define MAX_PORT_GIDS 1 #define MAX_PORT_PKEYS 1 -#define MAX_PKEYS 1 +#define MAX_PKEYS MAX_PORT_PKEYS #define MAX_GIDS 2048 #define MAX_UCS 512 #define MAX_MR_SIZE (1UL << 27) @@ -87,7 +87,6 @@ typedef struct RdmaRmQP { typedef struct RdmaRmPort { union ibv_gid gid_tbl[MAX_PORT_GIDS]; enum ibv_port_state state; - int *pkey_tbl; /* TODO: Not yet supported */ } RdmaRmPort; =20 typedef struct RdmaDeviceResources { diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index c552248c90..994220b58e 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -275,15 +275,6 @@ static void init_dsr_dev_caps(PVRDMADev *dev) pr_dbg("Initialized\n"); } =20 -static void free_ports(PVRDMADev *dev) -{ - int i; - - for (i =3D 0; i < MAX_PORTS; i++) { - g_free(dev->rdma_dev_res.ports[i].gid_tbl); - } -} - static void init_ports(PVRDMADev *dev, Error **errp) { int i; @@ -292,10 +283,6 @@ static void init_ports(PVRDMADev *dev, Error **errp) =20 for (i =3D 0; i < MAX_PORTS; i++) { dev->rdma_dev_res.ports[i].state =3D IBV_PORT_DOWN; - - dev->rdma_dev_res.ports[i].pkey_tbl =3D - g_malloc0(sizeof(*dev->rdma_dev_res.ports[i].pkey_tbl) * - MAX_PORT_PKEYS); } } =20 @@ -622,8 +609,6 @@ static void pvrdma_exit(PCIDevice *pdev) =20 pvrdma_qp_ops_fini(); =20 - free_ports(dev); - rdma_rm_fini(&dev->rdma_dev_res); =20 rdma_backend_fini(&dev->backend_dev); --=20 2.14.3