From nobody Sun Feb 8 19:38:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525118817093489.534887520437; Mon, 30 Apr 2018 13:06:57 -0700 (PDT) Received: from localhost ([::1]:33182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDF4a-0007Ug-9d for importer@patchew.org; Mon, 30 Apr 2018 16:06:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEzm-0003jb-Jg for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEzl-0005rp-T6 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:58 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:34938) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDEzl-0005r3-M5 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:57 -0400 Received: by mail-wr0-x242.google.com with SMTP id i14-v6so5965740wre.2 for ; Mon, 30 Apr 2018 13:01:57 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id u35-v6sm8455997wrc.29.2018.04.30.13.01.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 13:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lU7UKKXZzcPj4fwGn+VOvHqu6PXkpW8o/pqWdo0OC8Q=; b=I81zlNCzOc98xKSfQSe9T0Xw8tGk+8CS8OWPr3egq4hBUgpJKH8HY4ytdC7bjux/hU WZB9ZalR/KW3Q9XIKeYcv768swjAgxLsb3eWwMxIt2ArgC+k9joZIrxIUDWU1Z12KiCI OmH9y+Yhlg4s3FpmtFJvYMo++079fOwcms+ccmd54Caqt6Njwz7LP2xzlKghVVzzekR6 ug9O0EN/q1cyuBK5Fy2yzOGgsv7ctRHRq/Lyo/t1iNKWs/g7S4bKXnTjuTzE/P4Udv3d V450Vnk/wz7sH15GFrxJa4k2SHbRZMwsigg6+ZbSni5GE3FqOK2FsQdYJ61wGN5AfW0Z xslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lU7UKKXZzcPj4fwGn+VOvHqu6PXkpW8o/pqWdo0OC8Q=; b=lz9cDxBBASWYvvxXu4FK4JiXFZDL83w7AeqGIGtPa4IoElBKmiz6srvlycJipaoPx5 uwtAaX86Sw9HUyU09NNXd77aXgp+WiyvQf1OSMBIhbO+XxAmF1IEWgd5m/g8cRZgvqL+ 8LyJMjk/gM17CLfUwKQjhjxTazO1Hd6lmrf7xP/1xLJF7/Ce2MAwIn4b1BfbV1+jIrzk bzzpyhqCg8/lYB+Ea60ZeAZfdWpoa+gzUyibcP0zOJE9rcd1eTfFbkoYVv33pIhRliIg tE1DVc6DIyXMq3onct0Cyu+/8f3bnBUPUHHN6e6Dr9puBw9/qCt9r6DHfB3sxR2VpUQE JR+w== X-Gm-Message-State: ALQs6tCM/9643phYN3B4uRcU2szfnQQn5QZqgA9W+3GGupN56jwKn/5I 9gXsw0+jLxitTALVYBBB3eiJnQ== X-Google-Smtp-Source: AB8JxZou8AoarHL2dPF83QXPJCb1bAMtYJ7lXask6wQQHIGAdU9mUbBZrdtZu2x1LNV5hKMWGzUNaQ== X-Received: by 2002:adf:abab:: with SMTP id s40-v6mr10483566wrc.259.1525118516243; Mon, 30 Apr 2018 13:01:56 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 23:02:18 +0300 Message-Id: <20180430200223.4119-3-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> References: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PATCH 2/7] hw/rdma: Fix possible usage of a NULL pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Coverity CID 1390586; The cq handle is provided by the guest and cannot be trusted to be previuosly allocated. Fix it by exiting the completion flow. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/rdma/vmw/pvrdma_qp_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 750ade6c31..99bb51111e 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -216,6 +216,7 @@ void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint3= 2_t cq_handle) cq =3D rdma_rm_get_cq(dev_res, cq_handle); if (!cq) { pr_dbg("Invalid CQ# %d\n", cq_handle); + return; } =20 rdma_backend_poll_cq(dev_res, &cq->backend_cq); --=20 2.14.3