From nobody Sun Feb 8 17:03:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525101027133562.9898533416429; Mon, 30 Apr 2018 08:10:27 -0700 (PDT) Received: from localhost ([::1]:60150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDARe-00075U-Ar for importer@patchew.org; Mon, 30 Apr 2018 11:10:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAQ0-00061p-Vz for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAPz-0004z2-79 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:44 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:41025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAPy-0004yW-VQ for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:43 -0400 Received: by mail-lf0-x242.google.com with SMTP id o123-v6so12564363lfe.8 for ; Mon, 30 Apr 2018 08:08:42 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id i6-v6sm1560640lji.49.2018.04.30.08.08.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XXwKcR4N51X7aOae10Qyt7cWtrSrtjeH0/gutcOucP0=; b=KtKlVqP/Q3Yr4QfrFf8Y6KJYX9p6+veHF29HP05gjcktMv/ghYzT2HJTZq+Z76htYC OagRgN6ZWMNSXZ2R1a758PvWtf75QnhHccnJ6a+yurHjQknUH+aV0Epmn+08R1MzHCiK gnZDjfZtbMl1N3RlQQxeKvGKPbgTf8r5ej12/h8yM2+htnT5mFVOEWWxFCIzHycOOO6f 4rodrZZYRZ0/A+wKHrgYeTIe7cAJH/PhYlYz28eVDs4paRvxUKSMfWRxdw+40caEKuHb TS7fOqsS2gaOx0KnyGxoIDnRmjSCpVL9KUSs7jAk+nDgs6Xiuc/OYs3Ad/BaouoTk4tU Na8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XXwKcR4N51X7aOae10Qyt7cWtrSrtjeH0/gutcOucP0=; b=ooWWuW10rZZRZ5Xrn+rqHRbCaXQc9b/2N3fvVIPbIVrMyLwaxAF2HVhIEFi8n/M8WS gW4FSO/+CmGnSb7Ktk/PyYi6u7sEMnZu9vuQ0ISXVYMi65ZoYBR1bfR4l082V0Y6QkZq jMpK6Ucaw9bK17/nCj8+wgQzf6JsvFw0j94Ve4HyzTfoQX2uloehG/fAFjn4lfw3dgwA 3o2L5SnZUD6l1Boe68Y68SSmfHhN5Nu4eN+W8srFvfbX+hUwBf8BEg3VN1PFOfs3Xv41 RZf4QITXPrRE9uixUlEpp2/ckpMQ/2CE4HwWkxDqHm2MKvK/ScAIVn2jToyIQEG3p3R/ oi5Q== X-Gm-Message-State: ALQs6tAq6Sjl/OsCyUBGg6UxXMNaeBGrv68nILpuRZl47x8deG0cX3Uo 1QJL2UpkaR5pqJbn3nsY3/KRVg== X-Google-Smtp-Source: AB8JxZrUk4nGwmb8NIy7fT3DDLNJuexWqOXMBqxPqI55yDGl58FrMheLqaeBLJCnVcUqc+N7bjARew== X-Received: by 2002:a19:8f06:: with SMTP id r6-v6mr8005781lfd.56.1525100921540; Mon, 30 Apr 2018 08:08:41 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 17:08:33 +0200 Message-Id: <20180430150837.20470-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180430150837.20470-1-edgar.iglesias@gmail.com> References: <20180430150837.20470-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 1/5] target-microblaze: Respect MSR.PVR as read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7628b0e25b..f739751930 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -424,7 +424,7 @@ static inline void msr_write(DisasContext *dc, TCGv v) /* PVR bit is not writable. */ tcg_gen_andi_tl(t, v, ~MSR_PVR); tcg_gen_andi_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], MSR_PVR); - tcg_gen_or_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], v); + tcg_gen_or_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], t); tcg_temp_free(t); } =20 --=20 2.14.1 From nobody Sun Feb 8 17:03:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525101207175126.1212542856224; Mon, 30 Apr 2018 08:13:27 -0700 (PDT) Received: from localhost ([::1]:60168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAUY-0000yn-Ev for importer@patchew.org; Mon, 30 Apr 2018 11:13:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAQ1-00062G-My for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAQ0-0004ze-QJ for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:45 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAQ0-0004zB-IX for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:44 -0400 Received: by mail-lf0-x244.google.com with SMTP id h4-v6so12597628lfc.1 for ; Mon, 30 Apr 2018 08:08:44 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id w2-v6sm1565417ljw.70.2018.04.30.08.08.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H64HEWKVeVSke19Rg7nkhOskfBgoN/6v2GFBKcOobvE=; b=trGFd5/HbVCd1UA0G/NPP3HF+vJpgIrN2giMFjUDs1AfKOqKtTyfccMfYpIFquxFiw x0jaaSLz+48aM5Xm7WUfKj2CdAUudyWxwVdW1rQngfrTHilL6jVhF/U/mOmcbWQkfWDM YkiUbO+x5u7rq2AOIpPFQPns5fczVd9E5bE5mrxRd6xVPaH2WMkrAC9YRNKpSfTRgAuJ AcQfALg9/KEvUagwwYM3DYtpqPgAdcgBWp+/aNyCrrafTpMvAmYPWffsodWITmwIz4sj Do9M3gQtPyUhZnyWnt0DUzbB0b1/44lrse10XPadsPP5N8zNDnByEAQfSBpPXCI9JTYI PCKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H64HEWKVeVSke19Rg7nkhOskfBgoN/6v2GFBKcOobvE=; b=FiM2PVLIGmNYqbYl38DQQR+ub/lZFMwTapVnOYboGEQCY3PXmO8u0Q8uz3rmDIgud7 Ljz8MN5lwbdvmG+isdwKbqzrAv/Hco54ihjOghsKoZX3Bqm06Ey7qJ8Eeq6i1sZHZHTn 6PD71MwbFxwMi6DEQq53rtSEitFUpBbpTJl5hwtZ0O7ISF7ZN8144MrP1KZmTPG1l8i5 Cip9XKGK+6SZ+cTUtoaHErH2MYWba1t4nB3SO1Nw3MB3qww6T8goU7kPEmrsD9ngkr9t alS9oDbkbsWjaTDFCyETkgCudPDgfAaDBT0IH4pUE0I3upoHdIBcabJXlDSuICMICdnp rorQ== X-Gm-Message-State: ALQs6tDo7Vk7jZU3K9b1xe6aGZZXa4KX56K/qizYyv+EkZIWqZt3n+Aa 3UIUhgVvvAP2iXoIUOSwVlBucw== X-Google-Smtp-Source: AB8JxZoNuNZWF8fgMgLaNxq6a7nCjwf/xHs6ivoCOMRDnP+H27N3B4S6TWGcVTUnnTFSaiPpCk4blQ== X-Received: by 2002:a19:5047:: with SMTP id z7-v6mr7933373lfj.129.1525100923076; Mon, 30 Apr 2018 08:08:43 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 17:08:34 +0200 Message-Id: <20180430150837.20470-3-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180430150837.20470-1-edgar.iglesias@gmail.com> References: <20180430150837.20470-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 2/5] target-microblaze: Fix trap checks for FPU insns X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Fix trap checks for FPU insns when extended FPU insns are enabled. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index f739751930..ec12fed49d 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1412,7 +1412,7 @@ static void dec_fpu(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && (dc->cpu->cfg.use_fpu !=3D 1)) { + && !dc->cpu->cfg.use_fpu) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); return; --=20 2.14.1 From nobody Sun Feb 8 17:03:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525101294229224.87643142526053; Mon, 30 Apr 2018 08:14:54 -0700 (PDT) Received: from localhost ([::1]:60176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAVq-0001uz-8l for importer@patchew.org; Mon, 30 Apr 2018 11:14:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAQ3-00063Q-8J for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAQ2-00050Y-6l for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:47 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:40087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAQ1-0004zx-UY for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:46 -0400 Received: by mail-lf0-x241.google.com with SMTP id j16-v6so12574528lfb.7 for ; Mon, 30 Apr 2018 08:08:45 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id v3-v6sm1165574lfd.66.2018.04.30.08.08.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hv5gJ0EcJcyHM76wX42uv5qL0VCUp24xBQJe4pFWI1w=; b=XKwgAZOEsBAyMJzRcel8hck8p615Zm13Hao6fAz4ljGPeDau214WwTkVnsZXZ+PfYn 9HGsIHcUsVm/zt0rdvWy9hN9PWURzzvqvuAd/RJEhP5pe7HXoZsAU+uAdMALvoxO3GMX ZUNzGvZybgoRxllmIldCwYSPezA06ObMbcWKt0H+71FaK7JbXkRUL0rkLuSct0AGf+sw 7kOXZBnVuVZ6YhqISh8xkEuiwYC8TBXdzXccGkL83HP70RMKmYnulwAQ/8p6eLw3y1PW 4bA0/p1W/0F4ZunNFa3ltbHCd0F/X0OlRosLkDjSo+l8NAfYtzXFGLajby067L6jXJqD m+Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hv5gJ0EcJcyHM76wX42uv5qL0VCUp24xBQJe4pFWI1w=; b=pIfuhCxUL1lJnsnxCn0nMeFzE0HYC4+qvYvtrPxihbXBtBDS+HNaueKzmDnHFha14h uAif5up2T+ovvMd718MVPayPQbkgsz/oO7qW/SwmOwYfy9t3ClTuQIQudxeVXhvNCnPD lYME0eXxqILu+QqNkW2B+xtGs2ORomiTrasDQbJY2a6OHvGKcmA3YhHxLooMv42QC84I 6Fp+VyYQOb2GjKLOC93uYTJSMgtbc7ukuD1wHAU5Z2pj/mvXivpI9iKaxxjWc7qFSo+W D/I0DZI3vwHOawNhTPA06UL/bnLUp/+DmGXwJiEA/nAna78uyR6kp70sfz/+/rym6tvl 8UOg== X-Gm-Message-State: ALQs6tDhWmBVvhD5I2NuW5YNtcb/6LVWJGVl4HFtaVQGjgEA6x8Fs4Gu 4ORJLjgO2RQf0GqEenn6IjfZTw== X-Google-Smtp-Source: AB8JxZrHN3fsrADH1+XF+hAXf1NsOL0MFsZEc1CZM6FZQg5RhQ4LRIIg9iKAkMw3AgBtvCgoyKenfQ== X-Received: by 2002:a19:b217:: with SMTP id b23-v6mr7962654lff.51.1525100924481; Mon, 30 Apr 2018 08:08:44 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 17:08:35 +0200 Message-Id: <20180430150837.20470-4-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180430150837.20470-1-edgar.iglesias@gmail.com> References: <20180430150837.20470-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PULL v1 3/5] target-microblaze: Don't clobber the IMM reg for ld/st reversed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Do not clobber the IMM register on reversed load/stores. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index ec12fed49d..100883e2cc 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -952,7 +952,6 @@ static void dec_load(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } @@ -1104,7 +1103,6 @@ static void dec_store(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } --=20 2.14.1 From nobody Sun Feb 8 17:03:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525101031127812.6497387606283; Mon, 30 Apr 2018 08:10:31 -0700 (PDT) Received: from localhost ([::1]:60151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDARi-00078P-9O for importer@patchew.org; Mon, 30 Apr 2018 11:10:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAQ4-00064i-Qo for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAQ3-00051O-Rw for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:48 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:37781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAQ3-00050r-D6 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:47 -0400 Received: by mail-lf0-x243.google.com with SMTP id b23-v6so12582604lfg.4 for ; Mon, 30 Apr 2018 08:08:47 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id o4-v6sm1575450ljh.39.2018.04.30.08.08.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UQzkGBsgIYfnPfrMVx+LsnICfyTLJljwbPsC2gz0ELQ=; b=giJBlACruHWVsH+UUR0D7fPNpO8oPSox/PjE+4Xf2v3vXqT46BS5WvNa2+NIe6189Z d756PqiXQ21F1fo/C5tGO5NMXZHcdWLDi4/lrEWZa5+ZzIKPNmJoC96CMWkuY85+aNAs 86PIXRnqWX0SzE0gKQUyugl3/IS9vIEw3kFDmuWjaohXoRqPS2CU88rh/WZrDasjieAV jftAXZc/62yzXDCsurpIRsD7Q31VAWF8KRVRN4RhSn1SMUStC7vWHDKUDGU8dLb0XY0g i0nEbATjlVaZxx2I05YtUPna4nW/z0pMD7s9PmvdDWhtN1ImboXRQuF83ssUnA4Hs63L IZ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UQzkGBsgIYfnPfrMVx+LsnICfyTLJljwbPsC2gz0ELQ=; b=dX5hCt60y8k5raAYYXsR+1mA5NByE7vcjgDYyxPLizlsAPC4OFbh6yeFPltWzhRko2 pBg77vwfZCiIlxkcX70qBRhkk+Xgx2toapx+6f2cNV7CwsrhBSGG7rET/Wlb27IT5xEH PWWr6kTODGZQllGSrxf0PcdeIMjdf1UxXY3WLfr2B8dpKK5FWS23a+IiJyjR6GTNoFwL CYJFlmkP8F/2VX4+Tpek6VQj3dBPxtaUimwx7umk791PcDsae46D8U11EvlW5a9/+/p2 PnbfmBt0SaA8CkGZ0re8zNbuKkas2A8f6IWSSyMOW7B/bdZe4BGoCGNYuVTZPo8pYCi9 Arbw== X-Gm-Message-State: ALQs6tDs3GXIo9qbj/5lAjxkuswkuwRkd4gJ9/PihZAX8s0P0i+ew5UN GrL4TnJXVBhKAoygvkRzS1YsIQ== X-Google-Smtp-Source: AB8JxZp7mmhpaU8ZYRwPU2SEz4DaUVfRLQYgYckVokCd39RTQV85dZAu1A02fr85HMnEug8y30PMQA== X-Received: by 2002:a19:9f10:: with SMTP id i16-v6mr7372561lfe.29.1525100925892; Mon, 30 Apr 2018 08:08:45 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 17:08:36 +0200 Message-Id: <20180430150837.20470-5-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180430150837.20470-1-edgar.iglesias@gmail.com> References: <20180430150837.20470-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PULL v1 4/5] target-microblaze: mmu: Make TLBSX write-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index a0f06758f8..8391811900 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -182,7 +182,7 @@ done: uint32_t mmu_read(CPUMBState *env, uint32_t rn) { unsigned int i; - uint32_t r; + uint32_t r =3D 0; =20 if (env->mmu.c_mmu < 2 || !env->mmu.c_mmu_tlb_access) { qemu_log_mask(LOG_GUEST_ERROR, "MMU access on MMU-less system\n"); @@ -211,6 +211,9 @@ uint32_t mmu_read(CPUMBState *env, uint32_t rn) } r =3D env->mmu.regs[rn]; break; + case MMU_R_TLBSX: + qemu_log_mask(LOG_GUEST_ERROR, "TLBSX is write-only.\n"); + break; default: r =3D env->mmu.regs[rn]; break; --=20 2.14.1 From nobody Sun Feb 8 17:03:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525101381739837.3334041300798; Mon, 30 Apr 2018 08:16:21 -0700 (PDT) Received: from localhost ([::1]:60186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAXN-0002uL-0b for importer@patchew.org; Mon, 30 Apr 2018 11:16:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDAQ6-00065j-1C for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDAQ5-00051z-2g for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:49 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:41026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDAQ4-00051Z-RI for qemu-devel@nongnu.org; Mon, 30 Apr 2018 11:08:48 -0400 Received: by mail-lf0-x243.google.com with SMTP id o123-v6so12564848lfe.8 for ; Mon, 30 Apr 2018 08:08:48 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id e18-v6sm1565429ljk.57.2018.04.30.08.08.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 08:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3r8s6ZdOkvIVIYVkoMsHppoIqucNvkDQrdaP9S//BJA=; b=TK+WVqEAVudkfUYzDal3TgzMcriPlxyxETprn5nSFkrAAEMkodYav2Zcq/XiO6Klqn 8qefpbFYTHOFFiTdlwRGggDQVrqCPfAOABtBiJgHMNUDePJO6OoIMcbq2UJovHAv7pBJ 571eTBQ9QnO4wKbp+7mwunagf3M7B2HHlsUlNeY8mDssvSeY1MJQgqJ7DprcGsgu5wRd 67qA2MrbDuQpJIa8fUNyan0jvqvV+7dB02rw+yWc2ghhdk5GFAyRbc9816hXq8SDkHTY srWiUC60oxPPJzXZR2LFYIU9bVCuHHpNCQ0sTMZY5OcYTin2W473Nyh4BBTr33mI+iJ2 cYZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3r8s6ZdOkvIVIYVkoMsHppoIqucNvkDQrdaP9S//BJA=; b=ISeZ42BTr93Ueg/b0cwuIWeZKdATgk7UKfiL1ODBZHBunwTEDy61wRECy1LNdDHXr8 bXr8ejXur0hBsHnAYzpMediai+phz3A3MdtkmW7O1RF/ombiHMEjM4Tt1kVJ8m6hOeF9 1E+v8kNPUjmwrC5nn4q3SJ64bp6qUp2wCoJClfi4NKYMIAAXJEOJs0bzHbcAIsEHI059 z+ZvzItF+X8xGWwoXQVKIDbMfbIagm6Hayb5ffsBNE49Zh1ygBOpPVf3msXx3/XEtrh6 IPrwhkfCyvMCrOFP9cvKQJuOHQROnz9oyJA/L8l3Get0giY/4k8L43WMKwRB1rKK2hKD c6Zg== X-Gm-Message-State: ALQs6tBtC53xozOY4lT2B2vpWVACAYQXyMSqykPXQi/I0oDP2YtN2iVN 4ToY2BfGD38Rs7BBorUWjgOnLw== X-Google-Smtp-Source: AB8JxZr55sHDTU9HmNfgepY67OFsNALe0Urh/H/WSoC/s/dz16dNtcWrMVnyygcqhi8u40WIPNaD1Q== X-Received: by 2002:a2e:7a0c:: with SMTP id v12-v6mr8063659ljc.79.1525100927420; Mon, 30 Apr 2018 08:08:47 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 17:08:37 +0200 Message-Id: <20180430150837.20470-6-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180430150837.20470-1-edgar.iglesias@gmail.com> References: <20180430150837.20470-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PULL v1 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make the TLBX MISS bit read-only. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 8391811900..9d5e6aa8a5 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -273,6 +273,10 @@ void mmu_write(CPUMBState *env, uint32_t rn, uint32_t = v) env->mmu.regs[rn] =3D v; } break; + case MMU_R_TLBX: + /* Bit 31 is read-only. */ + env->mmu.regs[rn] =3D deposit32(env->mmu.regs[rn], 0, 31, v); + break; case MMU_R_TLBSX: { struct microblaze_mmu_lookup lu; --=20 2.14.1