From nobody Wed Oct 29 09:08:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525069712678439.4642652689639; Sun, 29 Apr 2018 23:28:32 -0700 (PDT) Received: from localhost ([::1]:57942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fD2IR-0002XV-A3 for importer@patchew.org; Mon, 30 Apr 2018 02:28:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fD2GT-0001fU-NQ for qemu-devel@nongnu.org; Mon, 30 Apr 2018 02:26:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fD2GS-00019R-UB for qemu-devel@nongnu.org; Mon, 30 Apr 2018 02:26:21 -0400 Received: from [107.173.13.209] (port=50372 helo=ozlabs.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fD2GS-00019G-NM for qemu-devel@nongnu.org; Mon, 30 Apr 2018 02:26:20 -0400 Received: from vpl1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 212EFAE8004D; Mon, 30 Apr 2018 02:24:52 -0400 (EDT) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 16:25:36 +1000 Message-Id: <20180430062536.49077-3-aik@ozlabs.ru> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180430062536.49077-1-aik@ozlabs.ru> References: <20180430062536.49077-1-aik@ozlabs.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [PATCH qemu v2 2/2] object: Handle objects with no parents X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , Paolo Bonzini , Igor Mammedov , "Dr. David Alan Gilbert" , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" At the moment object_get_canonical_path_component() crashes on assert() if the object does not have a parent. Usually it is not called for orphan objects but various HMP/QMP commands can do that (info mtree, qom-get). This adds few more tests in object_get_canonical_path() to prevent QEMU from crashing. Signed-off-by: Alexey Kardashevskiy --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 4677951..e0e300b 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1668,7 +1668,7 @@ gchar *object_get_canonical_path(Object *obj) Object *root =3D object_get_root(); char *newpath, *path =3D NULL; =20 - while (obj !=3D root) { + while (obj && obj->parent && obj !=3D root) { char *component =3D object_get_canonical_path_component(obj); =20 if (path) { --=20 2.11.0