From nobody Wed Oct 29 17:31:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152482183969814.479779495164621; Fri, 27 Apr 2018 02:37:19 -0700 (PDT) Received: from localhost ([::1]:46756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBzoY-00070I-PW for importer@patchew.org; Fri, 27 Apr 2018 05:37:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBza2-0001dD-Or for qemu-devel@nongnu.org; Fri, 27 Apr 2018 05:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBza1-00023Z-PA for qemu-devel@nongnu.org; Fri, 27 Apr 2018 05:22:14 -0400 Received: from ozlabs.org ([203.11.71.1]:45167) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fBza1-00022V-Cm; Fri, 27 Apr 2018 05:22:13 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 40XT2p3gwKz9s7Q; Fri, 27 Apr 2018 19:21:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1524820898; bh=DdkAmcXQ71YfaxnDO8/uKZScIfSqwTtjMOcMnMiPkww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eBnQXYSb2skRSzDxKhA1IX3fhZVqYFl/3wgamF8B50cGyRVQrDF35pKgrMF1sKMqz TlM26qD8Qoe3I6Yt0PVCJ1bF4YkjNTq5ybz1BNLsCt7v3BKCpbFhtLMqTnAI9TigJi o/uuwWSqe/aEC2QnqNYbNykyjhzkEP+F8l3orEMA= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 27 Apr 2018 19:21:07 +1000 Message-Id: <20180427092126.24812-31-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180427092126.24812-1-david@gibson.dropbear.id.au> References: <20180427092126.24812-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 30/49] spapr: drop useless dynamic sysbus device sanity check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, groug@kaod.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Greg Kurz Since commit 7da79a167aa11, the machine class init function registers dynamic sysbus device types it supports. Passing an unsupported device type on the command line causes QEMU to exit with an error message just after machine init. It is hence not needed to do the same sanity check at machine reset. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fc86ba6934..d35a88ca80 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1440,21 +1440,6 @@ void spapr_setup_hpt_and_vrma(sPAPRMachineState *spa= pr) } } =20 -static void find_unknown_sysbus_device(SysBusDevice *sbdev, void *opaque) -{ - bool matched =3D false; - - if (object_dynamic_cast(OBJECT(sbdev), TYPE_SPAPR_PCI_HOST_BRIDGE)) { - matched =3D true; - } - - if (!matched) { - error_report("Device %s is not supported by this machine yet.", - qdev_fw_name(DEVICE(sbdev))); - exit(1); - } -} - static int spapr_reset_drcs(Object *child, void *opaque) { sPAPRDRConnector *drc =3D @@ -1478,9 +1463,6 @@ static void spapr_machine_reset(void) void *fdt; int rc; =20 - /* Check for unknown sysbus devices */ - foreach_dynamic_sysbus_device(find_unknown_sysbus_device, NULL); - spapr_caps_reset(spapr); =20 first_ppc_cpu =3D POWERPC_CPU(first_cpu); --=20 2.14.3