From nobody Tue Feb 10 23:01:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524249580717436.56094818928966; Fri, 20 Apr 2018 11:39:40 -0700 (PDT) Received: from localhost ([::1]:50751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9awd-0003pu-Ne for importer@patchew.org; Fri, 20 Apr 2018 14:39:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9agT-0006mO-MX for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9agR-0004MX-2H for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:22:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9agQ-0004Kz-R5 for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:22:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 281523182F58; Fri, 20 Apr 2018 18:22:54 +0000 (UTC) Received: from localhost (ovpn-116-52.gru2.redhat.com [10.97.116.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09BBE60175; Fri, 20 Apr 2018 18:22:41 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 20 Apr 2018 15:19:42 -0300 Message-Id: <20180420181951.7252-16-ehabkost@redhat.com> In-Reply-To: <20180420181951.7252-1-ehabkost@redhat.com> References: <20180420181951.7252-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 20 Apr 2018 18:22:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 15/24] avocado_qemu: Functional test for RHBZ#1436616 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Luk=C3=A1=C5=A1=20Doktor?= , Fam Zheng , Stefan Hajnoczi , Amador Pahim , Cleber Rosa , Alistair Francis Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Amador Pahim Fixed in commit 243afe858b95765b98d16a1f0dd50dca262858ad. According to the RHBZ1436616, the issue is: usb-storage device under pci-bridge is unusable after migration. Test consists in create a VM with an usb-storage device and check whether it's still available after a live migration. A parameters.yaml file is provided in order to customize the guest image location and credentials. Execute with: avocado run test_nec-usb-xhci.py \ -m test_nec-usb-xhci.py.data/parameters.yaml Signed-off-by: Amador Pahim Signed-off-by: Eduardo Habkost --- tests/avocado/test_nec-usb-xhci.py | 55 ++++++++++++++++++= ++++ .../test_nec-usb-xhci.py.data/parameters.yaml | 4 ++ 2 files changed, 59 insertions(+) create mode 100644 tests/avocado/test_nec-usb-xhci.py create mode 100644 tests/avocado/test_nec-usb-xhci.py.data/parameters.yaml diff --git a/tests/avocado/test_nec-usb-xhci.py b/tests/avocado/test_nec-us= b-xhci.py new file mode 100644 index 0000000000..3f0d645032 --- /dev/null +++ b/tests/avocado/test_nec-usb-xhci.py @@ -0,0 +1,55 @@ +import copy +import os +import tempfile + +from avocado_qemu import test +from avocado.utils import process + +class TestNecUsbXhci(test.QemuTest): + """ + Run with: + + avocado run test_nec-usb-xhci.py \ + -m test_nec-usb-xhci.py.data/parameters.yaml + + :avocado: enable + :avocado: tags=3Dusbstorage + """ + + def setUp(self): + usbdevice =3D os.path.join(self.workdir, 'usb.img') + self.request_image() + process.run('dd if=3D/dev/zero of=3D%s bs=3D1M count=3D10' % usbde= vice) + self.vm.args.extend(['-device', 'pci-bridge,id=3Dbridge1,chassis_n= r=3D1']) + self.vm.args.extend(['-device', 'nec-usb-xhci,id=3Dxhci1,bus=3Dbri= dge1,addr=3D0x3']) + self.vm.args.extend(['-drive', 'file=3D%s,format=3Draw,id=3Ddrive_= usb,if=3Dnone' % usbdevice]) + self.vm.args.extend(['-device', 'usb-storage,drive=3Ddrive_usb,id= =3Ddevice_usb,bus=3Dxhci1.0']) + self.vm.launch() + + def test_available_after_migration(self): + """ + According to the RHBZ1436616, the issue is: usb-storage device + under pci-bridge is unusable after migration. + + Fixed in commit 243afe858b95765b98d16a1f0dd50dca262858ad. + + :avocado: tags=3Dmigration,RHBZ1436616 + """ + console =3D self.vm.get_console() + console.sendline('fdisk -l') + result =3D console.read_nonblocking() + console.close() + self.assertIn('Disk /dev/sdb: 10 MiB, 10485760 bytes, 20480 sector= s', + result) + + self.vm_dst =3D self.vm.migrate() + console =3D self.vm_dst.get_console() + console.sendline('fdisk -l') + result =3D console.read_nonblocking() + console.close() + self.assertIn('Disk /dev/sdb: 10 MiB, 10485760 bytes, 20480 sector= s', + result) + + def tearDown(self): + self.vm.shutdown() + self.vm_dst.shutdown() diff --git a/tests/avocado/test_nec-usb-xhci.py.data/parameters.yaml b/test= s/avocado/test_nec-usb-xhci.py.data/parameters.yaml new file mode 100644 index 0000000000..37a4e9dc37 --- /dev/null +++ b/tests/avocado/test_nec-usb-xhci.py.data/parameters.yaml @@ -0,0 +1,4 @@ +machine_accel: kvm +image_path: /var/lib/images/fedora-25.img +image_user: root +image_pass: p4ssw0rd --=20 2.14.3