From nobody Tue Feb 10 17:07:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524119502842310.64396732193427; Wed, 18 Apr 2018 23:31:42 -0700 (PDT) Received: from localhost ([::1]:53051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f936b-0006zS-TW for importer@patchew.org; Thu, 19 Apr 2018 02:31:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f934R-0005Xp-LN for qemu-devel@nongnu.org; Thu, 19 Apr 2018 02:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f934Q-0005Sr-Nd for qemu-devel@nongnu.org; Thu, 19 Apr 2018 02:29:27 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:55747) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f934Q-0005Qx-CA; Thu, 19 Apr 2018 02:29:26 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 40RTbj5NJPz9s3D; Thu, 19 Apr 2018 16:29:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1524119361; bh=2FjuwKyYB4Mg64QQp85qqTtGmhRHaDnkAqczctqACAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OpwJENgBmslKEXTVOt6s/UX1jzkiF2nmHSWU2Ng/H2hI7/Li/qJyiObchWjDLJhj5 9ZSRxTzdUhqqp+UYtqDSoUYa6dk2KVdYm1zI9sTHbZMq2YGq0+lTHMO+JKfa6+Ub2p X3qS/OUbzrp4EhsaYlS46iicy7bOwr7spGVbKqGE= From: David Gibson To: groug@kaod.org, abologna@redhat.com Date: Thu, 19 Apr 2018 16:29:17 +1000 Message-Id: <20180419062917.31486-8-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180419062917.31486-1-david@gibson.dropbear.id.au> References: <20180419062917.31486-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [RFC for-2.13 7/7] spapr_pci: Remove unhelpful pagesize warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" By default, the IOMMU model built into the spapr virtual PCI host bridge supports 4kiB and 64kiB IOMMU page sizes. However this can be overridden which may be desirable to allow larger IOMMU page sizes when running a guest with hugepage backing and passthrough devices. For that reason a warning was printed when the device wasn't configured to allow the pagesize with which guest RAM is backed. Experience has proven, however, that this message is more confusing than useful. Worse it sometimes makes little sense when the host-available page sizes don't match those available on the guest, which can happen with a POWER8 guest running on a POWER9 KVM host. Long term we do want better handling to allow large IOMMU page sizes to be used, but for now this parameter and warning don't really accomplish it. So, remove the message, pending a better solution. Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 39a14980d3..f936ce63ef 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1717,13 +1717,6 @@ static void spapr_phb_realize(DeviceState *dev, Erro= r **errp) } =20 /* DMA setup */ - if (((sphb->page_size_mask & qemu_getrampagesize()) =3D=3D 0) - && kvm_enabled()) { - warn_report("System page size 0x%lx is not enabled in page_size_ma= sk " - "(0x%"PRIx64"). Performance may be slow", - qemu_getrampagesize(), sphb->page_size_mask); - } - for (i =3D 0; i < windows_supported; ++i) { tcet =3D spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn[i]); if (!tcet) { --=20 2.14.3