From nobody Wed Feb 11 05:11:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523837278842408.1835253957421; Sun, 15 Apr 2018 17:07:58 -0700 (PDT) Received: from localhost ([::1]:53041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7rgR-0007g7-Ck for importer@patchew.org; Sun, 15 Apr 2018 20:07:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7rJz-0005Qp-5Z for qemu-devel@nongnu.org; Sun, 15 Apr 2018 19:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7rJy-0000ze-9o for qemu-devel@nongnu.org; Sun, 15 Apr 2018 19:44:35 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:46900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7rJu-0000vs-Cm; Sun, 15 Apr 2018 19:44:30 -0400 Received: by mail-qk0-x241.google.com with SMTP id l16so13888724qke.13; Sun, 15 Apr 2018 16:44:30 -0700 (PDT) Received: from x1.local ([138.117.48.212]) by smtp.gmail.com with ESMTPSA id d1sm1081394qtk.57.2018.04.15.16.44.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Apr 2018 16:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xspTMRx7ZYXGf08UIQieTQGAgddlTzaxpkHGqf8dMEs=; b=fCmpsADhP9Llnb3M1NvRt48dBPdLWkWGyVgFrIPzU//1GApAVQ+gZli+UYOJZd5vAX t9chPMJArecJrYL/2yAQ/AxxDe4kVh30wMPYcxJNUqFMtJJOgHwOKjSxdw4JcX6ITxFQ pph8L5NaO8nHzczRPKVrtRXF6BcrC15NFUTlBypHlVqzKUflyM/xZVCqwrdtOJjdTp+C dquicz6o8tXWH8tJblRBL3TP0/fw61ck2yjBN5Rth/c+vOqH+3OYCWlZcdGbKYpQdNQa 2vBMlv1m16kDuNcNwSUTVrtpLtMjkfV1q8n6Nf/tQ/Q9NMWfZBY6U9Zct1cxWzUqNhwp ApRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xspTMRx7ZYXGf08UIQieTQGAgddlTzaxpkHGqf8dMEs=; b=PK5pPfsIPq3AxOfWUVonoMZ6Gcf4Q6ZWpl8xBCwkdZzjJfn44WiXhAb9RnRs3Pa3YD HBTQVLzlb8bBL4H2G1nLSwry7TcC/LzHjha2D6MVWKCHKsvfQnCCqOssSLL9ej+6w/I2 I9e2Avxx8jtkqL7CsavVbJKmmFbYwimde4UZyJkViLwrsi7JJpFgzRrY1FeG3ow78hP2 vmTccPb9oTieNeCy4iGFT5HhbzdQ3WNXh9Pc9/9MGtdERfTrB1lYiwCXKcO9reU/tswM kKFSEmO+PiIx3izfm89OR8by/SmwKg6OqZS6n0D7/UjTR5gczqU9cINi7Hbtp/5ssmKZ cPVA== X-Gm-Message-State: ALQs6tBUFndYOT5z4cKV1M7EBCQgMJf2OZYXCSjmuEv+BJ1BLLkm+fhv K3Dyuy16Dt9ssZnW8qumqByC+Gq7 X-Google-Smtp-Source: AIpwx4+WppC2UBv3ZsC2OA/WbQrF/phY3CLhVdHGPCr9Dg2zvxfqXn2NZbxFtiqlB7DPF7ufip0noQ== X-Received: by 10.55.16.91 with SMTP id a88mr10493984qkh.199.1523835869700; Sun, 15 Apr 2018 16:44:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-trivial@nongnu.org, Thomas Huth Date: Sun, 15 Apr 2018 20:42:49 -0300 Message-Id: <20180415234307.28132-24-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180415234307.28132-1-f4bug@amsat.org> References: <20180415234307.28132-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v3 23/41] hw/tricore: Use the BYTE-based definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Bastian Koppelmann --- hw/tricore/tricore_testboard.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c index 8e61dfc3e6..a30a2f8345 100644 --- a/hw/tricore/tricore_testboard.c +++ b/hw/tricore/tricore_testboard.c @@ -19,6 +19,7 @@ =20 =20 #include "qemu/osdep.h" +#include "qemu/units.h" #include "qapi/error.h" #include "qemu-common.h" #include "cpu.h" @@ -72,17 +73,17 @@ static void tricore_testboard_init(MachineState *machin= e, int board_id) cpu =3D TRICORE_CPU(cpu_create(machine->cpu_type)); env =3D &cpu->env; memory_region_init_ram(ext_cram, NULL, "powerlink_ext_c.ram", - 2 * 1024 * 1024, &error_fatal); + 2 * M_BYTE, &error_fatal); memory_region_init_ram(ext_dram, NULL, "powerlink_ext_d.ram", - 4 * 1024 * 1024, &error_fatal); - memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * 102= 4, + 4 * M_BYTE, &error_fatal); + memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * K_B= YTE, &error_fatal); - memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * 102= 4, + memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * K_B= YTE, &error_fatal); memory_region_init_ram(pcp_data, NULL, "powerlink_pcp_data.ram", - 16 * 1024, &error_fatal); + 16 * K_BYTE, &error_fatal); memory_region_init_ram(pcp_text, NULL, "powerlink_pcp_text.ram", - 32 * 1024, &error_fatal); + 32 * K_BYTE, &error_fatal); =20 memory_region_add_subregion(sysmem, 0x80000000, ext_cram); memory_region_add_subregion(sysmem, 0xa1000000, ext_dram); --=20 2.17.0