From nobody Tue Feb 10 12:42:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522077941377238.59114990206854; Mon, 26 Mar 2018 08:25:41 -0700 (PDT) Received: from localhost ([::1]:57354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0U0C-0002eu-Dn for importer@patchew.org; Mon, 26 Mar 2018 11:25:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Tkp-0005I5-NN for qemu-devel@nongnu.org; Mon, 26 Mar 2018 11:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Tko-0002o8-Pz for qemu-devel@nongnu.org; Mon, 26 Mar 2018 11:09:47 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48728 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0Tko-0002nv-LA for qemu-devel@nongnu.org; Mon, 26 Mar 2018 11:09:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E9D34040070; Mon, 26 Mar 2018 15:09:46 +0000 (UTC) Received: from localhost (ovpn-112-61.ams2.redhat.com [10.36.112.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DBEF10B0F20; Mon, 26 Mar 2018 15:09:41 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Mon, 26 Mar 2018 17:08:48 +0200 Message-Id: <20180326150916.9602-11-marcandre.lureau@redhat.com> In-Reply-To: <20180326150916.9602-1-marcandre.lureau@redhat.com> References: <20180326150916.9602-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 26 Mar 2018 15:09:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 26 Mar 2018 15:09:46 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'marcandre.lureau@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v3 10/38] tests: add a few qemu-qmp tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Juan Quintela , Markus Armbruster , "Dr. David Alan Gilbert" , Gerd Hoffmann , Cleber Rosa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Michael Roth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" These 2 tests exhibited two qmp bugs that were fixed in 2.7 (series from commit e64c75a9752c5d0fd64eb2e684c656a5ea7d03c6 to commit 1382d4abdf9619985e4078e37e49e487cea9935e) Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qmp-test.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/tests/qmp-test.c b/tests/qmp-test.c index 07c0b87e27..642f46a332 100644 --- a/tests/qmp-test.c +++ b/tests/qmp-test.c @@ -224,7 +224,50 @@ static void test_qmp_oob(void) } QDECREF(resp); } + qtest_end(); +} + +static void test_object_add_without_props(void) +{ + QDict *ret, *error; + const gchar *klass, *desc; + + qtest_start("-machine none"); =20 + ret =3D qmp("{'execute': 'object-add'," + " 'arguments': { 'qom-type': 'memory-backend-ram', 'id': 'ra= m1' } }"); + g_assert_nonnull(ret); + + error =3D qdict_get_qdict(ret, "error"); + klass =3D qdict_get_try_str(error, "class"); + desc =3D qdict_get_try_str(error, "desc"); + + g_assert_cmpstr(klass, =3D=3D, "GenericError"); + g_assert_cmpstr(desc, =3D=3D, "can't create backend with size 0"); + + QDECREF(ret); + qtest_end(); +} + +static void test_qom_set_without_value(void) +{ + QDict *ret, *error; + const gchar *klass, *desc; + + qtest_start("-machine none"); + + ret =3D qmp("{'execute': 'qom-set'," + " 'arguments': { 'path': '/machine', 'property': 'rtc-time' = } }"); + g_assert_nonnull(ret); + + error =3D qdict_get_qdict(ret, "error"); + klass =3D qdict_get_try_str(error, "class"); + desc =3D qdict_get_try_str(error, "desc"); + + g_assert_cmpstr(klass, =3D=3D, "GenericError"); + g_assert_cmpstr(desc, =3D=3D, "Parameter 'value' is missing"); + + QDECREF(ret); qtest_end(); } =20 @@ -411,13 +454,19 @@ int main(int argc, char *argv[]) =20 g_test_init(&argc, &argv, NULL); =20 + qtest_add_func("qmp/object-add-without-props", + test_object_add_without_props); + qtest_add_func("qmp/qom-set-without-value", + test_qom_set_without_value); qtest_add_func("qmp/protocol", test_qmp_protocol); qtest_add_func("qmp/oob", test_qmp_oob); + qmp_schema_init(&schema); add_query_tests(&schema); =20 ret =3D g_test_run(); =20 qmp_schema_cleanup(&schema); + return ret; } --=20 2.17.0.rc1.1.g4c4f2b46a3