From nobody Sat Oct 25 21:46:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521696165721826.8605030343982; Wed, 21 Mar 2018 22:22:45 -0700 (PDT) Received: from localhost ([::1]:58883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eysgT-0005aH-WA for importer@patchew.org; Thu, 22 Mar 2018 01:22:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyqCS-0002iN-An for qemu-devel@nongnu.org; Wed, 21 Mar 2018 22:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyqCO-0000yD-9P for qemu-devel@nongnu.org; Wed, 21 Mar 2018 22:43:32 -0400 Received: from synology.com ([59.124.61.242]:53142) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyqCN-0000pJ-O0 for qemu-devel@nongnu.org; Wed, 21 Mar 2018 22:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synology.com; s=123; t=1521686595; bh=RiDPBQmOY2/EkO484gDzGTm4a6lMAtB+1dQjzu5OS9M=; h=From:To:Cc:Subject:Date; b=efMDn9efr62+epsIBOfoxvXambGBPsE9iHdE00LSZTBaUwOzpx2qsgSGzlDlBu4dv q84Q4Oaj6c+KOQuM++gPnr75jvdZBGifb/xMR7oehTRy8xA4+80E3cmoFpXuf4RWCk g1A4HaJhnzcH51Vwq+TbcBF0/fzhu69BzSopDl2g= To: qemu-devel@nongnu.org Date: Thu, 22 Mar 2018 10:40:56 +0800 Message-Id: <20180322024056.29599-1-yuchenlin@synology.com> X-Synology-MCP-Status: no X-Synology-Spam-Flag: no X-Synology-Spam-Status: score=0, required 5, WHITELIST_FROM_ADDRESS 0 X-Synology-Virus-Status: no X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 59.124.61.242 X-Mailman-Approved-At: Thu, 22 Mar 2018 01:21:25 -0400 Subject: [Qemu-devel] [PATCH] vmdk: return ENOTSUP before offset overflow X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: yuchenlin--- via Qemu-devel Reply-To: yuchenlin@synology.com Cc: yuchenlin , famz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: yuchenlin VMDK has a hard limitation of extent size, which is due to the size of grain table entry is 32 bits. It means it can only point to a grain located at offset =3D 2^32. To prevent offset overflow and record a useless offset in grain table. We should return un-support here. Signed-off-by: yuchenlin --- block/vmdk.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index f94c49a9c0..d8fc961940 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -47,6 +47,9 @@ #define VMDK4_FLAG_MARKER (1 << 17) #define VMDK4_GD_AT_END 0xffffffffffffffffULL =20 +/* 2TB */ +#define VMDK_EXTENT_SIZE_LIMIT (2199023255552) + #define VMDK_GTE_ZEROED 0x1 =20 /* VMDK internal error codes */ @@ -1645,6 +1648,9 @@ static int vmdk_pwritev(BlockDriverState *bs, uint64_= t offset, return ret; } if (m_data.valid) { + if (cluster_offset > VMDK_EXTENT_SIZE_LIMIT) { + return -ENOTSUP; + } /* update L2 tables */ if (vmdk_L2update(extent, &m_data, cluster_offset >> BDRV_SECTOR_BITS) --=20 2.16.2