From nobody Sat Oct 25 21:42:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15215115112381013.8265874791476; Mon, 19 Mar 2018 19:05:11 -0700 (PDT) Received: from localhost ([::1]:44986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey6eE-0001gr-HF for importer@patchew.org; Mon, 19 Mar 2018 22:05:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey6d1-0001GS-Qb for qemu-devel@nongnu.org; Mon, 19 Mar 2018 22:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey6cy-0004dO-KW for qemu-devel@nongnu.org; Mon, 19 Mar 2018 22:03:55 -0400 Received: from ozlabs.org ([103.22.144.67]:37759) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ey6cy-0004cs-5c; Mon, 19 Mar 2018 22:03:52 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 404x793M7Rz9sVy; Tue, 20 Mar 2018 13:03:49 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1521511429; bh=KLgobPG62d9FfKpjNRflwvd9klndcQQgKDp53h57NKI=; h=From:To:Cc:Subject:Date:From; b=ZFkiykrHHFFpxfndeY+kA8kc97UwpEJsRSxTOziv7GBe4FnVPM5/g+SZMrmK6ZCmy hb+X8h++HF4l2L4OwYxBpl1ra15mibSfy73bh+qvkAfltsHh+ZgyTpDcdNLMdJbaP3 4xnWEvJ4w7WO18PDz3GQ2J2HVa9aKcaI0hDg5b1Y= From: David Gibson To: thuth@redhat.com, groug@kaod.org, peter.maydell@linaro.org, balaton@eik.bme.hu Date: Tue, 20 Mar 2018 13:03:45 +1100 Message-Id: <20180320020345.24930-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PATCH] target/ppc: Initialize lazy_tlb_flush correctly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" ppc_tr_init_disas_context() correctly sets lazy_tlb_flush to true on certain CPU models. However, it leaves it uninitialized, instead of setting it to false on all others. It wasn't caught before now because we didn't have examples in the tests that exercised this path. However it can now be caught using clang's undefined behaviour sanitizer and the sam460ex board. Suggested-by: Peter Maydell Signed-off-by: David Gibson Reviewed-by: Greg Kurz Reviewed-by: Thomas Huth --- target/ppc/translate.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 218665b408..3457d29f8e 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7237,10 +7237,9 @@ static int ppc_tr_init_disas_context(DisasContextBas= e *dcbase, ctx->sf_mode =3D msr_is_64bit(env, env->msr); ctx->has_cfar =3D !!(env->flags & POWERPC_FLAG_CFAR); #endif - if (env->mmu_model =3D=3D POWERPC_MMU_32B || - env->mmu_model =3D=3D POWERPC_MMU_601 || - (env->mmu_model & POWERPC_MMU_64B)) - ctx->lazy_tlb_flush =3D true; + ctx->lazy_tlb_flush =3D env->mmu_model =3D=3D POWERPC_MMU_32B + || env->mmu_model =3D=3D POWERPC_MMU_601 + || (env->mmu_model & POWERPC_MMU_64B); =20 ctx->fpu_enabled =3D !!msr_fp; if ((env->flags & POWERPC_FLAG_SPE) && msr_spe) --=20 2.14.3