From nobody Sat Oct 25 21:42:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521472550181247.6740205383585; Mon, 19 Mar 2018 08:15:50 -0700 (PDT) Received: from localhost ([::1]:42488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwVi-0007XC-6l for importer@patchew.org; Mon, 19 Mar 2018 11:15:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwU2-0006X8-Vi for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:13:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exwTz-0001ou-OI for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:13:58 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]:34710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1exwTz-0001oN-GU for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:13:55 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2JF9JMb024328 for ; Mon, 19 Mar 2018 08:13:54 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0018.outbound.protection.outlook.com [216.32.180.18]) by mx0b-002c1b01.pphosted.com with ESMTP id 2gs14gj32t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 19 Mar 2018 08:13:53 -0700 Received: from tomato.dev.eng.nutanix.com (62.254.189.133) by CY1PR0201MB0938.namprd02.prod.outlook.com (2a01:111:e400:4c07::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Mon, 19 Mar 2018 15:13:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5v+ijHq3Zw6X+gbjs9dJ4ZUogeA7TW5Tnxi2Tr0BBYU=; b=Baro0qqnb6qA6YaHeSiMB53WuoYR3Y1db9odh5tjIFfj3W4fpM8VIxhziiuGsNcfXQcJIoM8HLC/RsBv9y3QoXYeldUaXnFivffbUBJR3CJs7UiENuPsTjw7OcZEAONCRxezvOQgxHfvhb1oJtJ0yscSkNZfyK23i6hFM8cbz78= From: David Vrabel To: qemu-devel@nongnu.org Date: Mon, 19 Mar 2018 15:13:27 +0000 Message-Id: <20180319151327.17989-3-david.vrabel@nutanix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180319151327.17989-1-david.vrabel@nutanix.com> References: <20180319151327.17989-1-david.vrabel@nutanix.com> MIME-Version: 1.0 X-Originating-IP: [62.254.189.133] X-ClientProxiedBy: AM5PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:206:1::47) To CY1PR0201MB0938.namprd02.prod.outlook.com (2a01:111:e400:4c07::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0082a13c-c48e-46f4-7dfe-08d58dac0614 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY1PR0201MB0938; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 3:glGF4uyh7N+kUy67Ej8635Wh46vlC2eiUbejkyGP99ftmY/c6nmLhcdMP+IBWiOLICkIYYJRKMGvt2MxYYZxpbVj7MOmWRDPkkJFImMbKssbVa0pQSCyjBLYUdV96bASQl/IZ+Quqt3Eco5ePLpgTeJZ5qBsqhuo202rP4FhatwvGYAxJRSMrwsekIHozX9vq+Nkbn92mD4mysbs1uLfPKg+HKS7gQUoeWOOCXF5AF6VN6hZRo5FK/yoSXK9YrJ/; 25:S2r9cqNpubPljWacwCi83me3JvdiIOUVc9FBLW+Gmu5QvP0ebPrKeGSiDyp5Amm84Z4hjNfxXdrzgszk4kp6sOUJbC4x37j7eHOovb5V1OoCUVqvjwM3ZB0RmdkFz7oUmMzn8MsBJaKAPMYBTfFG7H6OsnuzovZh0wMLPP8cmoASkYTHd6syLkRZuJbZUU/sz3QY0+BrzA4+c3dTZ1OxCCX8ouoCoTjEilRrGBtoAnuwjOpHo6k8+Ed+Qg1tFH6yii3wFlVdtlU2I8o/DJzaZhBHToLwopb1y87eY9XjoqFjjz2c8cR8QU55xuihlRSMH2/6y8TxZ03eED3SyuXwBw==; 31:Mi78+PvCa4iitkUNUpYSF1R4HX2BMWO6MSf6+Ig5BjlAG3CXdHfzwDmllWk7Wu68tFZKuTU1aaGePLjFFOmofGKW8oi/EBQj1kJQN9PLhVt+h0mmViUvGURyVkK5o4SPQfi2tnIDnC6SCMiXnnvWB4GDSxyMkpVJRPsU5xdAdSzFE1eunqzA7uLbGtlsK6KvGaxogg3ufJvPHssbgBmOx3lmVaez6n0WtJbCvnlq9yw= X-MS-TrafficTypeDiagnostic: CY1PR0201MB0938: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 20:CyBxR724DXDSmLF548xZ0hH4LPSk+PabYSm0SqKNDyhhgTVpqOL1nt0PuFRzsvoFbn2bQNzlh2//pczo8B/QQoqYPHtmeo+Geq9AbaZeTV/iCB/v9F3k4RSbgzSBatDm0YCikppFolQiY26m156x6RcHh5zm2LMxPJVHwlRGifzYRUAFVIiZRK1QsuHf63MEcLw9iNCyN1nmLwyH7uEiU7YzTffLlNhIm8bNdYK652EBUO4SGiLloKpqBVCpDdiE08LnynbRQVOmYnrZon2ov4e02Yl//SxHV09BlM3sQqRqLk0MhoPm/ZNaGUoK4sf5/b8CJ5B+8DLJDwC2bGwABXKTHlSZIW2E8dMai27qn/Vmm+siZm9iPZ+PM368Td2pwGn/oFO+7FI6lWeumHmhiobK7a6izJcQf2yB5eGLlp6pyzGNJ/hpoYymElMyNa5JAf/GsAoKYCoWy1W1nBHPGlSXgc6jIpayjPEVlPtxyx6imHk+XyAZkDOhu598QNeTggecsi2GQ7ywsITJUah6sxVnzNQ/yB6lrJbaX2S3tLaMExzhG50nqb8s6MG+L9DnlSHVPMtRl7HWY3InAEtea89zcOP/TtnElde5Tqhc3T0=; 4:dEm7Rho4m4kPGcXNAtOGg+XoBCLmzAxN5QxjopTFGqULaPhIfjp0rJLTytCTX0R7iKu7R4J/+5WPGfNao4w5U91t5YippdmyGU3V7kBJa3WUoPCHhp6uLB92Xy833dFBo7VAMZSVRuNGRL1lfYQ8N/Sz2s5oH0Qs2k0noL4G5/KU+6iiDt3fMP5hWQerFD/TZx+qATh6VeDC7J155HrvQoPCVnyNcCkNePULoWdMRgS1MfLTWdcghXDTO/E2k1oQT2743kBCLhMmDJgJjvRDhGCgXiHGFfM9EaVwM+WiGCGwaQUUNulxw6IZnFQjD64T X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(52384705835673); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501244)(52105095)(3002001)(10201501046)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR0201MB0938; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0201MB0938; X-Forefront-PRVS: 06167FAD59 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(199004)(189003)(48376002)(25786009)(8936002)(50226002)(478600001)(4326008)(2361001)(305945005)(7736002)(8676002)(106356001)(81156014)(105586002)(50466002)(97736004)(81166006)(386003)(26005)(316002)(16586007)(86362001)(6916009)(2950100002)(186003)(53936002)(76176011)(6486002)(52116002)(6666003)(107886003)(51416003)(7696005)(3846002)(1076002)(2351001)(47776003)(6116002)(36756003)(2906002)(68736007)(16526019)(66066001)(5660300001)(64030200001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0201MB0938; H:tomato.dev.eng.nutanix.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: nutanix.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0201MB0938; 23:Qf1K8efS9gWUHzMztYIL1xUlyNQqaRRykk4RZ4f?= =?us-ascii?Q?8QglRpWI8PeaIKL+NI4eapkKZ4mZKuT3KefL9EYwxorfrITvdbbCYGc6WPuo?= =?us-ascii?Q?sZgjyvp/Xb0s694eurrBI66YmjGsUWiAdGXBjWX6Zoy79azTzl9vsXJn1u5q?= =?us-ascii?Q?UZNHkndLptW14ReeP0bYb2VCIHoMlshpC3NOq3qF7DsZzBdcjydcu8eKA4Am?= =?us-ascii?Q?ncxXoAUTMg8hIO/chYwJm39Imu0gRaOuvJgDA73p3XTQyeqiPU+ws27p0BmB?= =?us-ascii?Q?cU0BSgYRH86bSx1SP1hAjwo+85TnqjorimqfN2CpvIFmiPz/yzpBJcyp/JuH?= =?us-ascii?Q?bDLArj1YmiI3GFRi6MQtGhmUqym+WWAM8y/1PNyF8AShJ+xmBZXcgE67pYeM?= =?us-ascii?Q?OfQfWBhHSGDhORYmlyP3e2myncNb1mYrYLmZ9HhKy4IEnZXAaEUEuWNlLsai?= =?us-ascii?Q?9PeVzeDIqGI0uZWzioY7l3WMFpaQ3q0F61idD6z7mtZdmtFsmqcgxkPNcMa6?= =?us-ascii?Q?yLwksGYCczBGvyolY1yJJyiFPYqCLe36xiV4pMp55ceyQPSj+hl9tl2HM9uP?= =?us-ascii?Q?2cvJZgBq+2LQ7Xwxc7yyz1fybQ/lSL6L5MNcVimEk2xRa5MhEQqMPJGzS1dV?= =?us-ascii?Q?Unhr2Kc41+zhqssnQA6R7qG0v+NKD7w1u8+JQPwOt2jMYu+zYljM/Fby+GBh?= =?us-ascii?Q?rg9YddB93y/fwB5+Wi3kRSYZry+WuIkRjiJnaDlA83OjJ9NBsr/GMVXrf1Ko?= =?us-ascii?Q?hVSfUaBFE++IE4ZzJjTepOXUuP9SIeCO8XUr08vxZkRrxBbsigDcojQP8wJA?= =?us-ascii?Q?Z378mqxhTsswSuwRTH+1Y+7uaSta5j9k93ECyDpmYh8K/Q7KxwgT8yI+slhZ?= =?us-ascii?Q?KpVsPSE09Xyf/DUbevCJP5RpM9G7O0kWa1cUSMFEuqIU1BLGQ/73JpQoAv8m?= =?us-ascii?Q?4d236UrEqBzzrnqE0zjX9akWC5b/Rf0DK70B6/PDq3awfb34UB0a0DcVimsB?= =?us-ascii?Q?egHoJFiIX4eRePXVeMrK3VyGIhMmRX8qY37IjF0ttj32FVFsvzPOWp56pqYu?= =?us-ascii?Q?yjcJHCPnXKwCx4Vath6+hD2zTyTdZYVWv01pshPY+vN3gNZ+jt8WusQKkXfj?= =?us-ascii?Q?8y9uhGrdhHbKUnUdl/YEJS5o3T9HPraS1cq+klbj5CVk1hIJDL6rVnIJ4XGN?= =?us-ascii?Q?LbWTYxz5ZFiQsb/Q=3D?= X-Microsoft-Antispam-Message-Info: I/pUB3NNVkIAsa6bM4s9i0Ulg0NjWLEWKZ81u59XIwJP50+ly9oiJj5m8J+Ih1YQztRD0tcZujDpDOqbdt1nAVKNSoYXREDNYFROxs5QyRgsj8BC3tXE7Bsa++oGcNF7+ZYb4LtqyuTFyc9/daFo6boSFP6l+lSUiNcMTlN2ov3ofCb98p6/exxadLWCmcS0 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 6:Xo083fexR5U4gluFY42sZdFZQStnAY1Aj0VnpH6AOUBfUrg6POowyz1aEqYoG5HAZe7GiXaseWv2l2W7YSvmmYYMU7FloZkQIrGeBzp5YJ+0j1b+46sOO0u8wlJmoXlq6cqOiUnNz2zfQL5YYsWoB11F9xbOpguNvoUsYbFr0ozq83piBSQwbtg+aGgSDo0WREGoxCBsAAueXQY0ormKPe9/VslDeiRSNvnlU9nHrrAT0YsbXo7RZ61jUzY93KH6cSlZSg4Iozbo1YdUlVrnHqcMy1F4ewRGPChZRCidazTz9l2zPXQo2Jw5d91MiTitIhbe30A3DuJ+y7czZO3axsmxL7B+f4XkfS0+QO1nqEs=; 5:vnoSvnJVqK/b7ZA3qSpPfMk7qhPnoaKyJTAbMa9h+XpEQiOtkGYJs9RmlCzkBkUH01SOfxH14QMqvaWw/lmPgQrFc+Wmb/TVXN0T+Ag10A1qaL5LdrD+LQwojGu+VMmZU7y9vmObLQ44Mx9N+izgFVjt3uJMxNqb/RMiwJj/r2U=; 24:hZWBSqnft713nHVA/D7NcTtjCs8wMcCetHCnsZWxh1Z7IV0y+ZtSULt2URSV2ZEl3BzKwvZylTEnTT2pBQFyMqEqxabfSvV5zJbEbyjdPJ4=; 7:jHEix00wuMvpnEEqfQ4uyH2nauLOGZshDM6qy2FNh7sECvP2pEdeVP40IeJC6jts2F+nZb1f+BlH3lg5E9ummradkNi8FZ8XuAoCKmXesNqQe3b4aw+0cr9ER9swUy2BTCTF2AXHZKj83JeJX0uRcmngloIC6nFd75BNuWNo+Qe/dpbWVv2XJsG5JSlsaASHGd1WOBZAhCgqvmdME4UDm7TsyvGvHgK8ADnJDQKHZSXhiNLvk4xGK8+AhYKoyQv5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2018 15:13:51.2128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0082a13c-c48e-46f4-7dfe-08d58dac0614 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0938 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-03-19_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803190172 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.155.12 Subject: [Qemu-devel] [PATCH 2/2] vhost-user-scsi: reset the device if supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Vrabel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting, potentially putting into an inoperable state. Signed-off-by: David Vrabel --- hw/scsi/vhost-user-scsi.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index 9389ed48e0..15e2dabebb 100644 --- a/hw/scsi/vhost-user-scsi.c +++ b/hw/scsi/vhost-user-scsi.c @@ -37,6 +37,10 @@ static const int user_feature_bits[] =3D { VHOST_INVALID_FEATURE_BIT }; =20 +enum VhostUserProtocolFeature { + VHOST_USER_PROTOCOL_F_RESET_DEVICE =3D 8, +}; + static void vhost_user_scsi_set_status(VirtIODevice *vdev, uint8_t status) { VHostUserSCSI *s =3D (VHostUserSCSI *)vdev; @@ -60,6 +64,25 @@ static void vhost_user_scsi_set_status(VirtIODevice *vde= v, uint8_t status) } } =20 +static void vhost_user_scsi_reset(VirtIODevice *vdev) +{ + VHostSCSICommon *vsc =3D VHOST_SCSI_COMMON(vdev); + struct vhost_dev *dev =3D &vsc->dev; + + /* + * Historically, reset was not implemented so only reset devices + * that are expecting it. + */ + if (!virtio_has_feature(dev->protocol_features, + VHOST_USER_PROTOCOL_F_RESET_DEVICE)) { + return; + } + + if (dev->vhost_ops->vhost_reset_device) { + dev->vhost_ops->vhost_reset_device(dev); + } +} + static void vhost_dummy_handle_output(VirtIODevice *vdev, VirtQueue *vq) { } @@ -172,6 +195,7 @@ static void vhost_user_scsi_class_init(ObjectClass *kla= ss, void *data) vdc->get_features =3D vhost_user_scsi_get_features; vdc->set_config =3D vhost_scsi_common_set_config; vdc->set_status =3D vhost_user_scsi_set_status; + vdc->reset =3D vhost_user_scsi_reset; fwc->get_dev_path =3D vhost_scsi_common_get_fw_dev_path; } =20 --=20 2.11.0