From nobody Sat Oct 25 21:42:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521472550234403.2642329315041; Mon, 19 Mar 2018 08:15:50 -0700 (PDT) Received: from localhost ([::1]:42489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwVk-0007cK-Ua for importer@patchew.org; Mon, 19 Mar 2018 11:15:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwU1-0006Wv-QT for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:14:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exwTy-0001o8-IS for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:13:57 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]:43092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1exwTy-0001mq-C5 for qemu-devel@nongnu.org; Mon, 19 Mar 2018 11:13:54 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2JF9JcA023321 for ; Mon, 19 Mar 2018 08:13:52 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0021.outbound.protection.outlook.com [216.32.180.21]) by mx0b-002c1b01.pphosted.com with ESMTP id 2gtdrf06f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 19 Mar 2018 08:13:52 -0700 Received: from tomato.dev.eng.nutanix.com (62.254.189.133) by CY1PR0201MB0938.namprd02.prod.outlook.com (2a01:111:e400:4c07::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Mon, 19 Mar 2018 15:13:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0PivYuIGmvu2DbQiPgnY8HI/09JzkduJPjfzEmZ0M60=; b=iUFlFTbar4OaE8jJ38TAqnnQEeBlrHi6EC9uds2hVIvxZ0ro7CTpfAtswUJyKFlrLAtcbL4pz/LPMp0q84OJCBrPiH15LFApn9B8bHKzTU9O13PX6uKEgTldMF6z5+M/vnCbJfq5yjqWyOQ+GYkuER3DuEeiJyTuTT9bBKrxGU8= From: David Vrabel To: qemu-devel@nongnu.org Date: Mon, 19 Mar 2018 15:13:26 +0000 Message-Id: <20180319151327.17989-2-david.vrabel@nutanix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180319151327.17989-1-david.vrabel@nutanix.com> References: <20180319151327.17989-1-david.vrabel@nutanix.com> MIME-Version: 1.0 X-Originating-IP: [62.254.189.133] X-ClientProxiedBy: AM5PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:206:1::47) To CY1PR0201MB0938.namprd02.prod.outlook.com (2a01:111:e400:4c07::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d019fc2d-63fd-416e-5deb-08d58dac0572 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY1PR0201MB0938; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 3:ASYBHqqSpap4qFo7KZnOshfcuokaRiRKt+44kcGs+sXl3QfEuvgnoFHPwBWobP9CeEZqtSfBfLCWGqSZUvt10tYBbCdMYe9qTKVytOtfECaRglh7fbgT8JxpfJfBapEUhotZe2jblf1O7JuvJ4HVxaM91CFCCmiZdJenB337fawRGMcXD9m/S+QcLQZfOoyaqWGTki8fvjIDFjYPNBHCuOd1v3mdB5vbgB5BJB4yv2aH2T4X6bvRDD9U6Y5JCUT1; 25:eiMQf56cl+uItnrOJEqkmn0X12g2FqVn6TXk9mGtTpXtG6x4LZN5h/iUHPG0Fjm/bdDieWJbywBYki7pn3rSXWmPzQRn74xnILiG7aReSCBTB9d4TEY3DU8acKSo3ZkmIDtmFhOBw7lNYjiKVxipNSQOokeChv40vX+/wfapLSjwHvteb1rCCjjWiBnSojvPcDCG+6WqaFvUcW2uxfJtda/5KFcB+kab+/m1U5N8wuG6p+va5Rlhso8Z3u80lrA+SbTWtHIifUO0F8Y+C+/6lfnFXvgGGvb/N4JeI3PZHbXtJmnjaSVOuvDE3tK3ByYJbdBmW1JfQ3BfbxxLZ/aM3w==; 31:O/ZYXiV7VyJcIdII6tg/uY3gjW6WG5oK+9yvVeP1Jbc3lI3ECiT6FLQRQcdtlym5f1oYw3fIxliqr8CapryBmcRYscROe6RGVsSZN8BLmluwO+vxvHgsj0Qksc+xg2HH4O0Uz1SSYLeHJ+A5r78nLpkXZ7jlOJ/zSTdLr5sXF7GyRIfiOUcc8nl/egjUYGm6vdQnOzQkq5YVTpjLF64yxl1vAohc6Duwlli+o/TK3c8= X-MS-TrafficTypeDiagnostic: CY1PR0201MB0938: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 20:7AT0O9ylFj/UH4SlD/WBetdCkHEjNWJk9fQz/gLnLkSokcqcAtvVx8JyjKzSivOqxoLy+ZIOAuwkXueH1XkIwujhPqt1dROZke+2Cnynr57C/Niou53L9rndg5TkLm+wvBDAaOtjsoqe7b/KSp4rpGGZtFca87lt0gpXATV1+Xx/4HDwEfRgOFF2FKn0cbuo+2zO0Cyb6xLR8ghdhE24ShPLcVDdby9AUWrsrrhEIuF3hNe4emu5K4xFe/CzBHFtSc95iOR3oeCzjX/4wTb/6Wydib7CsrwnzV/QeyH9c9cNzqW+MYPvKmeao0GwDGUXNfo9qkJuFzuYn+fuBARD6L+oBskISb8zMyuqOUsiGxMVutlooIsEGb5Ln4CQmvysApr7duUHqL0Ia2ft4L3/KK096ES+3LCkhLD0CarXg3R4Uz/T/jn9scDLoafLiV1cUe8L9ai/cNVqUBy0HJmVxHha+/TyvJysRv3hKsK9LQ+ZSDFRI7/tuXVM4mbap0SzMsmH8AMXkadMVPRUv9nliuP6n2pxj+KRafyK9zs7iwrwIaadcmf/b+gWM9GvxLQCGlVgAdpUAQAyQiuxsIZS/IeKTCD+dS6Wgk5kL007loM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(52384705835673); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501244)(52105095)(3002001)(10201501046)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR0201MB0938; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0201MB0938; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 4:8q5f1nSjdINNAE1hQbW0lyG25gApixiB3mSdZ8jKUY9xOeMhaOT/2WeRLMrWhIgRjnZJGTpnLPqfaz5OisejcM/+3i8N9WDsOFBleiHajk36AnepXIwuoOj3SFAb1GTZBK4qrrhnWMHZG1b6ZNp/CUBm/mVemh25y9axL972MC9xy0HWtfGAHblazRuqXtF7dLCY1QTD0pdWaxhFrncWGuSqxwdjUS3HgcryGM00jv7a3rRllc2k4mW4J+j+Nv1mU2MRT6YLYarqbMaIUdhSuKcJ/2aOgZmMLJUVTKknV7Y0RXc/P7DYPAdBtMp3Z0ynrp9daHEwY+acT1yUbM+4CdLbM/mt2leiY2b8e/Xt3X8= X-Forefront-PRVS: 06167FAD59 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(199004)(189003)(48376002)(25786009)(8936002)(50226002)(478600001)(4326008)(2361001)(305945005)(7736002)(8676002)(106356001)(81156014)(105586002)(50466002)(97736004)(81166006)(386003)(26005)(59450400001)(316002)(16586007)(86362001)(6916009)(2950100002)(186003)(53936002)(76176011)(6486002)(52116002)(6666003)(107886003)(51416003)(7696005)(3846002)(1076002)(2351001)(47776003)(6116002)(36756003)(2906002)(68736007)(16526019)(66066001)(5660300001)(64030200001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0201MB0938; H:tomato.dev.eng.nutanix.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: nutanix.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0201MB0938; 23:2AwHSaDLbMAXU7bVEGHFoNgykHRayyK/7nfhfus?= =?us-ascii?Q?aAV1So4ReFdT87sFvrAmfNUEiQ1NekaC8wg58N5zNa420LON3GjirH2wq51R?= =?us-ascii?Q?cTcAm6YyLY6z5mAkc1/cn/rmTxvoOaiIdWb5ekYvmPCyEVQPu0w5jecR8X7l?= =?us-ascii?Q?1WqORtT2fWG/wZXMmYuZkPcWRHqr09XFjwJFcGlG2vkjjlKD5ne2YlSHEUNQ?= =?us-ascii?Q?0JqlTXvie2UyqfhepukzV0wp47a9IPS6g4dQp27avH1fMQoBc3JqoldlG54o?= =?us-ascii?Q?Z6qTdrPe1MkEQqRh6ny88md4nds2okrs/jG8Wq9Xv1RCDFbvBWHwQBOJUEIf?= =?us-ascii?Q?YoIDlC6XAT1OPbsE+KM96q5/8st5Dq0hN4iNKJPmXUGhiOcfSxOThtMvrowx?= =?us-ascii?Q?lOsFM8uN6P8Of1Np0GSXZmRzZJyAnfE/5eERuhDQVcrd/cpktvKSEtAYeIYJ?= =?us-ascii?Q?le4848QYI/QXvpc81QnjFDBiGi6o6tRCcGLkpsB3s0vxKUohQOCYbU1OhY5X?= =?us-ascii?Q?izh68ZvXr3d+Of+SNWwVwzZQ3ABEnHHKy6vgKQ2n6bEEnJ2zg2LXGvdhm7kX?= =?us-ascii?Q?sO2f+EYO5+tMkHYuCoMl4y75zKCi6laFRDBBP/0yO2QUWv4ncW5JY/DPaR53?= =?us-ascii?Q?vQ3i+Jwng3XwtNu9Jb4P3HhMymWaDh5/Jtu//s5MF90koEmpOmqimzg/itmb?= =?us-ascii?Q?jbgzv8eO2k/Co+EL1r8fa31NqxQF96IWfec3Tv/n641heAoGOBM/OTsK//xB?= =?us-ascii?Q?z9JDvIKaLpaZjLy/peqhVELIfGACmo7bgVTEPM7yKdyI5i9/0+II7dl4ml3L?= =?us-ascii?Q?p4G9EqtrkpmCZSRrpjt4ArswRSjv7RUO5q5r6XIKSb+ePXlx98gYdD15fVaI?= =?us-ascii?Q?xnmN4DeRrgQwpM4kSLIYKJ7iQH7ASqaa5FtMe3PllhV3Y01qFzoa9R1Vpf2E?= =?us-ascii?Q?sSzy+kZ1xHyslaJMJlNCylSFXzeriztVmmP2vqtfE2qY8yyKyrnW5H79YLzS?= =?us-ascii?Q?nZciUlcNsxuUHII7mIxl5oU1KpQtIb1e6kYMWKXXr8ZIXu5wgoSKqyRozqZ1?= =?us-ascii?Q?RLXRTGxA+H73ja8BPNnLASzSJ6Mnb54n/UGKyJxG9/ZYKWKN99eoig3bQLjV?= =?us-ascii?Q?VwRzecgflR/APp5ALhB/xQ/eV5Vuoxp1BG0R9qqQ+t7nS9noeFnnVyhgP7cz?= =?us-ascii?Q?Ya1gV76oL7fPR//nV+inCctnOSzVcNSHhagF2?= X-Microsoft-Antispam-Message-Info: Tb6sLzOp8Oi9TO03OeYEuavXyssRxT12y/Uw6KVVnr+RVxGK5KnOakQC/E80+7Z2HEC63kwwsUNc5qsV/weVVlZ0JvPAvNAVKCAMB8rwBV4ZGyg9iCtOkjYFOZfIMwMPcETkI9m7xLIxWUX23CSqMLsRZsYhAKOabBUkiWKbDmmFSeC6tqitDV1OaDZ9MbTY X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB0938; 6:N3yFsoIy+cYUIx7hpBg0obJlIbqCy4QuWtQsNQmT8ZetVDCxiCHQc0K6dMuGNRuHgrTSqw1EiCgVyPPHeDELPnbvTske/idWsA9z3/3sKnVbKIPr0CjuobrJdUmXr8/KKoIUD27jjC7pt62OLekS0jN6Jp2Jk76syrYo3UOytNOPRmm10hNK9QaFeq/dO9O4rv06rx2GyOcWvebQp3PG2OKcNtJlsMSZpPnZXjh8ITuEVvwbkZ/pFdxAKk40xa9vzJ8j9UKa4GQk3L9/ZQMXmyVgzG+b6VfHHkheNCqskSw+NcvXpZIJIPOKLqYiBsaojAU+SUrnYh3sPshW+6M/DZmsr1QxDtwTOXFdEYcpauo=; 5:LSpfc0p4VSKOPcUt+/hxVWYBq0t9pm5nCefkZ3hB/eqI7lo0WMrnRldUA0PpChA4bOhCe/lpBVKelcZAvw/n+IgLI2R8hfnroanPjKxv3YNHZLsHpGQqjlyZm4tiI3QDU55HjDgHM7oOxi8wkDJst24BH80RLKnzZdD0gnFGZpo=; 24:sO+jDkncYxmRNtbnLqBBaD/ZKDn+tAM+AaIPvNja35wgXMCNBxevOZNe+BZe9Fg7QzSw/tTrwWPXevjsNSjRTUMcYcxdQomPmCaGaIaJU90=; 7:X8ck2CMxCFafh7Auk2pcJliswqKBfpw4HxKsi2+qWkhcCr/aMcbw6AnXpGoxlteNGUg18ugnQR+K5tXixDYvB5bFHpEmgEWPPVAsWdsBMd6+CvumFvT3hNgavgBqFS7jUy9TvQExS7l/kKxjK21JjqmV40Xr7fZ1ijoIuTt6Bq1wGe8ixtQ4RR5SrxqJ45U72OpypEehFJJg7vJW1jpQ2VFUn13wVf++flXTocVzKqwocmAroMEf40HHl7U/HzVy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2018 15:13:50.1815 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d019fc2d-63fd-416e-5deb-08d58dac0572 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0938 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-03-19_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803190172 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.155.12 Subject: [Qemu-devel] [PATCH 1/2] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Vrabel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE protocol feature bit. If it does so, the new message is used instead of sending a RESET_OWNER which has had inconsistent implementations. Signed-off-by: David Vrabel --- docs/interop/vhost-user.txt | 16 ++++++++++++++++ hw/virtio/vhost-user.c | 8 +++++++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt index cb3a7595aa..c5faa9fff8 100644 --- a/docs/interop/vhost-user.txt +++ b/docs/interop/vhost-user.txt @@ -369,6 +369,7 @@ Protocol features #define VHOST_USER_PROTOCOL_F_SLAVE_REQ 5 #define VHOST_USER_PROTOCOL_F_CROSS_ENDIAN 6 #define VHOST_USER_PROTOCOL_F_CRYPTO_SESSION 7 +#define VHOST_USER_PROTOCOL_F_RESET_DEVICE 8 =20 Master message types -------------------- @@ -689,6 +690,21 @@ Master message types feature has been successfully negotiated. It's a required feature for crypto devices. =20 + * VHOST_USER_RESET_DEVICE + + Id: 28 + Equivalent ioctl: N/A + Master payload: N/A + Slave payload: N/A + + Ask the vhost user backend to disable all rings and reset all + internal device state to the initial state, ready to be + reinitialized. The backend retains ownership of the device + throughout the reset operation. + + Only valid if the VHOST_USER_PROTOCOL_F_RESET_DEVICE protocol + feature is set by the backend. + Slave message types ------------------- =20 diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 41ff5cff41..67207bfe8a 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -41,6 +41,7 @@ enum VhostUserProtocolFeature { VHOST_USER_PROTOCOL_F_SLAVE_REQ =3D 5, VHOST_USER_PROTOCOL_F_CROSS_ENDIAN =3D 6, VHOST_USER_PROTOCOL_F_CRYPTO_SESSION =3D 7, + VHOST_USER_PROTOCOL_F_RESET_DEVICE =3D 8, =20 VHOST_USER_PROTOCOL_F_MAX }; @@ -76,6 +77,7 @@ typedef enum VhostUserRequest { VHOST_USER_SET_CONFIG =3D 25, VHOST_USER_CREATE_CRYPTO_SESSION =3D 26, VHOST_USER_CLOSE_CRYPTO_SESSION =3D 27, + VHOST_USER_RESET_DEVICE =3D 28, VHOST_USER_MAX } VhostUserRequest; =20 @@ -641,10 +643,14 @@ static int vhost_user_set_owner(struct vhost_dev *dev) static int vhost_user_reset_device(struct vhost_dev *dev) { VhostUserMsg msg =3D { - .hdr.request =3D VHOST_USER_RESET_OWNER, .hdr.flags =3D VHOST_USER_VERSION, }; =20 + msg.hdr.request =3D virtio_has_feature(dev->protocol_features, + VHOST_USER_PROTOCOL_F_RESET_DEVIC= E) + ? VHOST_USER_RESET_DEVICE + : VHOST_USER_RESET_OWNER; + if (vhost_user_write(dev, &msg, NULL, 0) < 0) { return -1; } --=20 2.11.0