From nobody Sat Oct 25 11:05:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521446903661868.7698404889048; Mon, 19 Mar 2018 01:08:23 -0700 (PDT) Received: from localhost ([::1]:40754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1expq1-00073V-KG for importer@patchew.org; Mon, 19 Mar 2018 04:08:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1expp3-0006hy-IA for qemu-devel@nongnu.org; Mon, 19 Mar 2018 04:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1expp0-0005lt-Al for qemu-devel@nongnu.org; Mon, 19 Mar 2018 04:07:13 -0400 Received: from relay.sw.ru ([185.231.240.75]:55208) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1expp0-0005jv-1U; Mon, 19 Mar 2018 04:07:10 -0400 Received: from msk-vpn.virtuozzo.com ([195.214.232.6] helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1expov-0002Q7-UK; Mon, 19 Mar 2018 11:07:06 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Mon, 19 Mar 2018 11:07:05 +0300 Message-Id: <20180319080705.10310-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.11.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jsnow@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- If it appropriate for 2.12, let's push it. If not - then for 2.13. v2: - squash 02 (indentation fix) to 01 - drop comment from qcow2_check_metadata_overlap() - set @ign to QCOW2_OL_BITMAP_DIRECTORY for in-place case in bitmap_list_store. I don't think non-inplace case should be changed, as it don't touch active bitmap directory. block/qcow2.h | 45 ++++++++++++++++++++++++--------------------- block/qcow2-bitmap.c | 7 ++++++- block/qcow2-refcount.c | 10 ++++++++++ block/qcow2.c | 22 ++++++++++++++-------- 4 files changed, 54 insertions(+), 30 deletions(-) diff --git a/block/qcow2.h b/block/qcow2.h index 6f0ff15dd0..896ad08e5b 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -98,6 +98,7 @@ #define QCOW2_OPT_OVERLAP_SNAPSHOT_TABLE "overlap-check.snapshot-table" #define QCOW2_OPT_OVERLAP_INACTIVE_L1 "overlap-check.inactive-l1" #define QCOW2_OPT_OVERLAP_INACTIVE_L2 "overlap-check.inactive-l2" +#define QCOW2_OPT_OVERLAP_BITMAP_DIRECTORY "overlap-check.bitmap-directory" #define QCOW2_OPT_CACHE_SIZE "cache-size" #define QCOW2_OPT_L2_CACHE_SIZE "l2-cache-size" #define QCOW2_OPT_REFCOUNT_CACHE_SIZE "refcount-cache-size" @@ -398,34 +399,36 @@ typedef enum QCow2ClusterType { } QCow2ClusterType; =20 typedef enum QCow2MetadataOverlap { - QCOW2_OL_MAIN_HEADER_BITNR =3D 0, - QCOW2_OL_ACTIVE_L1_BITNR =3D 1, - QCOW2_OL_ACTIVE_L2_BITNR =3D 2, - QCOW2_OL_REFCOUNT_TABLE_BITNR =3D 3, - QCOW2_OL_REFCOUNT_BLOCK_BITNR =3D 4, - QCOW2_OL_SNAPSHOT_TABLE_BITNR =3D 5, - QCOW2_OL_INACTIVE_L1_BITNR =3D 6, - QCOW2_OL_INACTIVE_L2_BITNR =3D 7, - - QCOW2_OL_MAX_BITNR =3D 8, - - QCOW2_OL_NONE =3D 0, - QCOW2_OL_MAIN_HEADER =3D (1 << QCOW2_OL_MAIN_HEADER_BITNR), - QCOW2_OL_ACTIVE_L1 =3D (1 << QCOW2_OL_ACTIVE_L1_BITNR), - QCOW2_OL_ACTIVE_L2 =3D (1 << QCOW2_OL_ACTIVE_L2_BITNR), - QCOW2_OL_REFCOUNT_TABLE =3D (1 << QCOW2_OL_REFCOUNT_TABLE_BITNR), - QCOW2_OL_REFCOUNT_BLOCK =3D (1 << QCOW2_OL_REFCOUNT_BLOCK_BITNR), - QCOW2_OL_SNAPSHOT_TABLE =3D (1 << QCOW2_OL_SNAPSHOT_TABLE_BITNR), - QCOW2_OL_INACTIVE_L1 =3D (1 << QCOW2_OL_INACTIVE_L1_BITNR), + QCOW2_OL_MAIN_HEADER_BITNR =3D 0, + QCOW2_OL_ACTIVE_L1_BITNR =3D 1, + QCOW2_OL_ACTIVE_L2_BITNR =3D 2, + QCOW2_OL_REFCOUNT_TABLE_BITNR =3D 3, + QCOW2_OL_REFCOUNT_BLOCK_BITNR =3D 4, + QCOW2_OL_SNAPSHOT_TABLE_BITNR =3D 5, + QCOW2_OL_INACTIVE_L1_BITNR =3D 6, + QCOW2_OL_INACTIVE_L2_BITNR =3D 7, + QCOW2_OL_BITMAP_DIRECTORY_BITNR =3D 8, + + QCOW2_OL_MAX_BITNR =3D 9, + + QCOW2_OL_NONE =3D 0, + QCOW2_OL_MAIN_HEADER =3D (1 << QCOW2_OL_MAIN_HEADER_BITNR), + QCOW2_OL_ACTIVE_L1 =3D (1 << QCOW2_OL_ACTIVE_L1_BITNR), + QCOW2_OL_ACTIVE_L2 =3D (1 << QCOW2_OL_ACTIVE_L2_BITNR), + QCOW2_OL_REFCOUNT_TABLE =3D (1 << QCOW2_OL_REFCOUNT_TABLE_BITNR), + QCOW2_OL_REFCOUNT_BLOCK =3D (1 << QCOW2_OL_REFCOUNT_BLOCK_BITNR), + QCOW2_OL_SNAPSHOT_TABLE =3D (1 << QCOW2_OL_SNAPSHOT_TABLE_BITNR), + QCOW2_OL_INACTIVE_L1 =3D (1 << QCOW2_OL_INACTIVE_L1_BITNR), /* NOTE: Checking overlaps with inactive L2 tables will result in bdrv * reads. */ - QCOW2_OL_INACTIVE_L2 =3D (1 << QCOW2_OL_INACTIVE_L2_BITNR), + QCOW2_OL_INACTIVE_L2 =3D (1 << QCOW2_OL_INACTIVE_L2_BITNR), + QCOW2_OL_BITMAP_DIRECTORY =3D (1 << QCOW2_OL_BITMAP_DIRECTORY_BITNR), } QCow2MetadataOverlap; =20 /* Perform all overlap checks which can be done in constant time */ #define QCOW2_OL_CONSTANT \ (QCOW2_OL_MAIN_HEADER | QCOW2_OL_ACTIVE_L1 | QCOW2_OL_REFCOUNT_TABLE |= \ - QCOW2_OL_SNAPSHOT_TABLE) + QCOW2_OL_SNAPSHOT_TABLE | QCOW2_OL_BITMAP_DIRECTORY) =20 /* Perform all overlap checks which don't require disk access */ #define QCOW2_OL_CACHED \ diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index f45e46cfbd..fb750ba8d3 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -776,7 +776,12 @@ static int bitmap_list_store(BlockDriverState *bs, Qco= w2BitmapList *bm_list, } } =20 - ret =3D qcow2_pre_write_overlap_check(bs, 0, dir_offset, dir_size); + /* Actually, even in in-place case ignoring QCOW2_OL_BITMAP_DIRECTORY = is not + * necessary, because we drop QCOW2_AUTOCLEAR_BITMAPS when updating bi= tmap + * directory in-place (actually, turn-off the extension), which is che= cked + * in qcow2_check_metadata_overlap() */ + ret =3D qcow2_pre_write_overlap_check( + bs, in_place ? QCOW2_OL_BITMAP_DIRECTORY : 0, dir_offset, dir_= size); if (ret < 0) { goto fail; } diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 3de1ab51ba..275a303cfa 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -2585,6 +2585,16 @@ int qcow2_check_metadata_overlap(BlockDriverState *b= s, int ign, int64_t offset, } } =20 + if ((chk & QCOW2_OL_BITMAP_DIRECTORY) && + (s->autoclear_features & QCOW2_AUTOCLEAR_BITMAPS)) + { + if (overlaps_with(s->bitmap_directory_offset, + s->bitmap_directory_size)) + { + return QCOW2_OL_BITMAP_DIRECTORY; + } + } + return 0; } =20 diff --git a/block/qcow2.c b/block/qcow2.c index 1914a940e5..23f36a67c7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -655,6 +655,11 @@ static QemuOptsList qcow2_runtime_opts =3D { .help =3D "Check for unintended writes into an inactive L2 tab= le", }, { + .name =3D QCOW2_OPT_OVERLAP_BITMAP_DIRECTORY, + .type =3D QEMU_OPT_BOOL, + .help =3D "Check for unintended writes into the bitmap directo= ry", + }, + { .name =3D QCOW2_OPT_CACHE_SIZE, .type =3D QEMU_OPT_SIZE, .help =3D "Maximum combined metadata (L2 tables and refcount b= locks) " @@ -682,14 +687,15 @@ static QemuOptsList qcow2_runtime_opts =3D { }; =20 static const char *overlap_bool_option_names[QCOW2_OL_MAX_BITNR] =3D { - [QCOW2_OL_MAIN_HEADER_BITNR] =3D QCOW2_OPT_OVERLAP_MAIN_HEADER, - [QCOW2_OL_ACTIVE_L1_BITNR] =3D QCOW2_OPT_OVERLAP_ACTIVE_L1, - [QCOW2_OL_ACTIVE_L2_BITNR] =3D QCOW2_OPT_OVERLAP_ACTIVE_L2, - [QCOW2_OL_REFCOUNT_TABLE_BITNR] =3D QCOW2_OPT_OVERLAP_REFCOUNT_TABLE, - [QCOW2_OL_REFCOUNT_BLOCK_BITNR] =3D QCOW2_OPT_OVERLAP_REFCOUNT_BLOCK, - [QCOW2_OL_SNAPSHOT_TABLE_BITNR] =3D QCOW2_OPT_OVERLAP_SNAPSHOT_TABLE, - [QCOW2_OL_INACTIVE_L1_BITNR] =3D QCOW2_OPT_OVERLAP_INACTIVE_L1, - [QCOW2_OL_INACTIVE_L2_BITNR] =3D QCOW2_OPT_OVERLAP_INACTIVE_L2, + [QCOW2_OL_MAIN_HEADER_BITNR] =3D QCOW2_OPT_OVERLAP_MAIN_HEADER, + [QCOW2_OL_ACTIVE_L1_BITNR] =3D QCOW2_OPT_OVERLAP_ACTIVE_L1, + [QCOW2_OL_ACTIVE_L2_BITNR] =3D QCOW2_OPT_OVERLAP_ACTIVE_L2, + [QCOW2_OL_REFCOUNT_TABLE_BITNR] =3D QCOW2_OPT_OVERLAP_REFCOUNT_TABLE, + [QCOW2_OL_REFCOUNT_BLOCK_BITNR] =3D QCOW2_OPT_OVERLAP_REFCOUNT_BLOCK, + [QCOW2_OL_SNAPSHOT_TABLE_BITNR] =3D QCOW2_OPT_OVERLAP_SNAPSHOT_TABLE, + [QCOW2_OL_INACTIVE_L1_BITNR] =3D QCOW2_OPT_OVERLAP_INACTIVE_L1, + [QCOW2_OL_INACTIVE_L2_BITNR] =3D QCOW2_OPT_OVERLAP_INACTIVE_L2, + [QCOW2_OL_BITMAP_DIRECTORY_BITNR] =3D QCOW2_OPT_OVERLAP_BITMAP_DIRECTO= RY, }; =20 static void cache_clean_timer_cb(void *opaque) --=20 2.11.1