From nobody Sat Oct 25 13:17:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521088000928954.0387700188686; Wed, 14 Mar 2018 21:26:40 -0700 (PDT) Received: from localhost ([::1]:49678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewKTI-0005A0-IN for importer@patchew.org; Thu, 15 Mar 2018 00:26:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewKMJ-00074O-H5 for qemu-devel@nongnu.org; Thu, 15 Mar 2018 00:19:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewKMF-00041j-Fw for qemu-devel@nongnu.org; Thu, 15 Mar 2018 00:19:19 -0400 Received: from ozlabs.org ([103.22.144.67]:45891) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ewKME-0003zO-LZ; Thu, 15 Mar 2018 00:19:15 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 401wMc3sFlz9sVV; Thu, 15 Mar 2018 15:19:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1521087548; bh=APBmlWA0ZLBkMcVHZDJxBebmAE+7wiPq9uCpvbF5AdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AhcDxGteXD9ZKOYF4Y5L8ouPmUzzOoQnGOt2dzj3Ttfwpj3wb0yj1ldeVGczEWEkf FZJLdD16XU7RiHWD1l7NAqv8B64tGI2kYYup8SAT5XV2OEJSJPnQlvcid3uvAylwOF BbzNp0zfQu/sIYy1UANwAxvscIa0+4Z6JE2+uxu0= From: David Gibson To: peter.maydell@linaro.org Date: Thu, 15 Mar 2018 15:18:58 +1100 Message-Id: <20180315041903.10046-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180315041903.10046-1-david@gibson.dropbear.id.au> References: <20180315041903.10046-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 4/9] hw/misc/macio: Mark the macio devices with user_creatable = false X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Thomas Huth , surajjs@au1.ibm.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The macio devices currently cause a crash when the user tries to instantiate them on a different machine: $ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device macio-newworld: Device 'serial0' is in use Aborted (core dumped) These devices are clearly not intended to be creatable by the user since they are using serial_hds[] directly in their instance_init function. So let's mark them with user_creatable =3D false. Signed-off-by: Thomas Huth Reviewed-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c index af1bd46b4b..454244f59e 100644 --- a/hw/misc/macio/macio.c +++ b/hw/misc/macio/macio.c @@ -406,6 +406,8 @@ static void macio_class_init(ObjectClass *klass, void *= data) k->class_id =3D PCI_CLASS_OTHERS << 8; dc->props =3D macio_properties; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); + /* Reason: Uses serial_hds in macio_instance_init */ + dc->user_creatable =3D false; } =20 static const TypeInfo macio_oldworld_type_info =3D { --=20 2.14.3