From nobody Tue Dec 16 07:07:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520984597898587.5679350418345; Tue, 13 Mar 2018 16:43:17 -0700 (PDT) Received: from localhost ([::1]:43594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evtZU-0002vP-19 for importer@patchew.org; Tue, 13 Mar 2018 19:43:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsiq-0006UV-US for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evsim-0004Ci-Ib for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:44 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:33976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evsim-0004C0-Bw for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:40 -0400 Received: by mail-wr0-x241.google.com with SMTP id o8so2599429wra.1 for ; Tue, 13 Mar 2018 15:48:40 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.48.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=GahpV3pSBQjcTUHRybvZOQ7iXVz0wfAQy2xOoWpHmzA=; b=LsQbkohjLWS1gG93GOl2lArgQasReeB3ooaNT7AQ8wLNBm2KE3ViBn/KMMjsVD2F1C YHDGO9TV3ZwSR9/hbCWFQF6NTU10M40k3WIzLzu5p+UYzFqri/vj6bzLbuHF5FjCoUnD fMD6jpvgYNYwz8FKPZzaDWz8CavOaBmwpkN+VVopvQwCzVNY1zG+juSoJ4RKG/VSmg5i wr69VWyhJwEceIRG4eweYqUgkepT3Z7WKNfYvc3/J7GWes9ywdhV880kL2OPttfvUq4z lxoQmAG2C7ptPMTC3SzWHu7KcM8x2pUDgZryPxqiHaF4ObrlazlrtYoa2V71fuuvlHlM dKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=GahpV3pSBQjcTUHRybvZOQ7iXVz0wfAQy2xOoWpHmzA=; b=mea1H4IxQgwhJDmuES0cQDujJoQtTYw+ng6tco/UDE5NaJ5VMIL8Pgur70/dfbE0RX ydbyE/DUDfOqO0lkg+Hh/oRWm6EYeEa078qwLE9U5anfRAhnUVMLfSrIdGI4t6EgJw3R 6CkDI+KKzozK+kNnpKOc4e0RbI/GXaFz2uIc5ioGkrxW4eD/DWnwSfTcXEoPCT+4XYDC SC+Sxhctgq/9w6GfUVTZs10X5s3P1Jh1GgTDM/WCz4qzkJKnHVl34nO+nsQQb/ZFwmaZ 3toEgKy9QCOAGQ/NesDBDCcqu6UBqAStbalbUX9SP8ykBTdEMJQw99d8UP+VzKDx6V9u RG7w== X-Gm-Message-State: AElRT7GEx/7ZnrK93DNzBm2rd3g4idEiMaOpXWhb0J7W0XVFeX8PJ0b+ lf2tKwPCz7xNzhMO3pmrhncasW3l X-Google-Smtp-Source: AG47ELvyGoawrHGe9ovjF5iio8y1EfHgFaQGlaVXbpronKXcwCe1KZWZEl7LePk9+HIu8DLuDzfq6g== X-Received: by 10.223.133.182 with SMTP id 51mr1799936wrt.226.1520981318953; Tue, 13 Mar 2018 15:48:38 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:47:13 +0100 Message-Id: <20180313224719.4954-64-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 63/69] replay: check return values of fwrite X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk This patch adds error reporting when fwrite cannot completely save the buffer to the file. Signed-off-by: Pavel Dovgalyuk Message-Id: <20180227095259.1060.86410.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/replay/replay-internal.c b/replay/replay-internal.c index 8e7474f787..b077cb5fd5 100644 --- a/replay/replay-internal.c +++ b/replay/replay-internal.c @@ -24,12 +24,23 @@ static QemuMutex lock; =20 /* File for replay writing */ +static bool write_error; FILE *replay_file; =20 +static void replay_write_error(void) +{ + if (!write_error) { + error_report("replay write error"); + write_error =3D true; + } +} + void replay_put_byte(uint8_t byte) { if (replay_file) { - putc(byte, replay_file); + if (putc(byte, replay_file) =3D=3D EOF) { + replay_write_error(); + } } } =20 @@ -62,7 +73,9 @@ void replay_put_array(const uint8_t *buf, size_t size) { if (replay_file) { replay_put_dword(size); - fwrite(buf, 1, size, replay_file); + if (fwrite(buf, 1, size, replay_file) !=3D size) { + replay_write_error(); + } } } =20 --=20 2.14.3