From nobody Tue Dec 16 05:38:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520983934769981.7707597007742; Tue, 13 Mar 2018 16:32:14 -0700 (PDT) Received: from localhost ([::1]:43524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evtOp-0002Ex-RK for importer@patchew.org; Tue, 13 Mar 2018 19:32:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsik-0006Oi-Aq for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evsij-0004Au-DH for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:38 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:54943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evsij-0004AO-5x for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:37 -0400 Received: by mail-wm0-x241.google.com with SMTP id h76so872886wme.4 for ; Tue, 13 Mar 2018 15:48:36 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.48.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=f89+1xjoNOupEoqpSPNpB12CPh9goqHHqSk48G/2Cro=; b=YcSmzJ9qZtiHEnrqRhCvXuIQQDf87vd/ok94AjAjD/ShivPLSONXzBtd7TFAQTU6vU zWizIxe2CzImGx/m5MNTRXquiuF40v5F0fFdcVUBoQm2Izju67gtW4or6H8xf3ZqxFCb lAmHZ1oeiIhbuueen0JPaIabMfwMZbNEVItyu9y5JPRjcTWQPehOCGJ9F3aZt7z4/x+1 t09KIsILcB0bpzgYa3QVDH3/ChMFrYVt2xtxIW7La0D8BCwW/FX+IODcG0OWo+vCXK5N vvt1u0VJUj6yI6LzBGILlwpmwCLtklwkPCYfGxehHKePncmJXbmaosEg/hH9CvKxaLXr TeEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=f89+1xjoNOupEoqpSPNpB12CPh9goqHHqSk48G/2Cro=; b=jznIplMIu1d8apeJt1IbDM+9+S3QzVMEM3qpRn5dF98Q4rYlYHuhOqce7cSYQ05B+J RUWTqyGK1DwzFDNxUmov5wzXPkzWkPDqN7U4IvP/inVu3heHMyH3Jf34YGjVgTDCANLr Tce+qlPd1E/PwAqLVDFDMQ2xMrOrKoAX4/KH/VdiyjbpzLfnBVoE+SsUF/utHAqD8IsM AsQxqef7CsA4TaZ/SvZPI0xvToQ++P9X4fVNapnzx69qTVuexYkRnsBwkd9r1iQGVP7d FA/aWZ/l67cwCFFQR3DvVhLKrPBjQVhM2HD4ejAzEk3Bi/nbYZheHanPWx2U+fenZgGc 5X4w== X-Gm-Message-State: AElRT7FkSbGsVxeeqp28V9ZT3xidvQu3442Z/uN7sZ7i4pdKrHqG6wDw dHfFk5nEs+EufRivA1xHqhyumw2x X-Google-Smtp-Source: AG47ELtzsLbH1EOVEC0PmRMiioSELxkFt/MaToWnzn2YUvX0nDHvRzjeP2Zd6D2MK/A5fSLtRUoBPA== X-Received: by 10.28.54.11 with SMTP id d11mr1221432wma.104.1520981315776; Tue, 13 Mar 2018 15:48:35 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:47:11 +0100 Message-Id: <20180313224719.4954-62-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 61/69] replay: don't destroy mutex at exit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk Replay mutex is held by vCPU thread and destroy function is called from atexit of the main thread. Therefore we cannot destroy it safely. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini Message-Id: <20180227095254.1060.96971.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 5 ----- replay/replay-internal.h | 1 - replay/replay.c | 1 - 3 files changed, 7 deletions(-) diff --git a/replay/replay-internal.c b/replay/replay-internal.c index 7cdefeaa04..fa7bba6dfd 100644 --- a/replay/replay-internal.c +++ b/replay/replay-internal.c @@ -176,11 +176,6 @@ void replay_mutex_init(void) qemu_mutex_init(&lock); } =20 -void replay_mutex_destroy(void) -{ - qemu_mutex_destroy(&lock); -} - bool replay_mutex_locked(void) { return replay_locked; diff --git a/replay/replay-internal.h b/replay/replay-internal.h index 41eee66e9b..d4037058e4 100644 --- a/replay/replay-internal.h +++ b/replay/replay-internal.h @@ -104,7 +104,6 @@ void replay_get_array_alloc(uint8_t **buf, size_t *size= ); * synchronisation between vCPU and main-loop threads. */ =20 void replay_mutex_init(void); -void replay_mutex_destroy(void); bool replay_mutex_locked(void); =20 /*! Checks error status of the file. */ diff --git a/replay/replay.c b/replay/replay.c index 9cddb6bfc9..5d05ee0460 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -358,7 +358,6 @@ void replay_finish(void) replay_snapshot =3D NULL; =20 replay_finish_events(); - replay_mutex_destroy(); } =20 void replay_add_blocker(Error *reason) --=20 2.14.3