From nobody Tue Dec 16 05:37:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152098630573960.68354473106376; Tue, 13 Mar 2018 17:11:45 -0700 (PDT) Received: from localhost ([::1]:43507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evtM4-0000c7-K8 for importer@patchew.org; Tue, 13 Mar 2018 19:29:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsii-0006Mh-Cn for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evsih-00049M-Bw for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:36 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:37059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evsih-00048O-6J for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:35 -0400 Received: by mail-wm0-x244.google.com with SMTP id 139so881430wmn.2 for ; Tue, 13 Mar 2018 15:48:35 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.48.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kwu9R4Oqu/XdgRnje5Q8FcF8hFd8m9i/JhVoPskPzvQ=; b=jepM2SVe01KD/NOj0IQ6G4vnE5Joqti+6K5tT7WuQ++XgCN2rW7hgujMiVN5NjYAov 9sHlGpHFxgyHmLwW9W77P3I0x6uv+Np9GeCn5tPW7peIQl19K1IodkAqlTfDIhAKJvKL 9OWR4jpVonw9Pduf2XS0B7ibBMdYPtNrnP9Ded1vYTOxaFHPceYCun3XeYmV8fGAUPwg iIXCQbKqLFDYtd10AhM1HLokUCTpVhjEIAam0GEOkTCwDs0aWDUBjRje1pjmQCM3eG0Q JkLBrNGtAlncs0PPXutFbLVJARcgJyyqISc2Z9/4AWuE4cSrZV7QwUPvM4ePsBspgIKm pMsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Kwu9R4Oqu/XdgRnje5Q8FcF8hFd8m9i/JhVoPskPzvQ=; b=SPAItG5r07TxvrHIbPovY3Z/7/dCKjJ4BaGhR14InKv5R0+llzDreXDowTT/Bjh8+o oyAGlcr4biscp73+9rS165WfGOzZDK1ZaK8KBG+udaEMkYkqtdwNUoIbDxLxILlDoa8q Vv3uZteVUvXTod2ddPD9DSKMG8nx9hlCIcToNaho+u8iiMc1BM/Wvo4urpwRorf13rcw GZNyBnAbHARgvE58tEI2K20s+Gavz230D1+0G+fG5X+/WD3DvHgcZ8SwLNv5AtAP6SyP MC8meK3m0lnFvtXa/bLMD27qL9encvBuxa3zUFdRueCJc0REvBjib2a8xYRgofch2snu zgpA== X-Gm-Message-State: AElRT7F3/G+O6Vi14RFeCvLd2+Ul157wR0x1RWW5xs7OyZepHyggKNkR JO9A1lEYL4itip7odOerSgFW6glC X-Google-Smtp-Source: AG47ELt4zd7/NS6jOMxL7FZEspjimppvogGf6Z8a9sG09OLFkO6GuXZlaw9694eEEzpkXSup0Urolw== X-Received: by 10.28.144.5 with SMTP id s5mr2084180wmd.98.1520981313802; Tue, 13 Mar 2018 15:48:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:47:09 +0100 Message-Id: <20180313224719.4954-60-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PULL 59/69] replay/replay-internal.c: track holding of replay_lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Alex Benn=C3=A9e This is modelled after the iothread mutex lock. We keep a TLS flag to indicate when that thread has acquired the lock and assert we don't double-lock or release when we shouldn't have. Signed-off-by: Alex Benn=C3=A9e Tested-by: Pavel Dovgalyuk Message-Id: <20180227095237.1060.44661.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini --- replay/replay-internal.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/replay/replay-internal.c b/replay/replay-internal.c index fca8514012..0d7e1d6bc4 100644 --- a/replay/replay-internal.c +++ b/replay/replay-internal.c @@ -169,6 +169,8 @@ void replay_finish_event(void) replay_fetch_data_kind(); } =20 +static __thread bool replay_locked; + void replay_mutex_init(void) { qemu_mutex_init(&lock); @@ -179,13 +181,22 @@ void replay_mutex_destroy(void) qemu_mutex_destroy(&lock); } =20 +static bool replay_mutex_locked(void) +{ + return replay_locked; +} + void replay_mutex_lock(void) { + g_assert(!replay_mutex_locked()); qemu_mutex_lock(&lock); + replay_locked =3D true; } =20 void replay_mutex_unlock(void) { + g_assert(replay_mutex_locked()); + replay_locked =3D false; qemu_mutex_unlock(&lock); } =20 --=20 2.14.3