From nobody Tue Dec 16 05:37:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520983424844291.19025191483126; Tue, 13 Mar 2018 16:23:44 -0700 (PDT) Received: from localhost ([::1]:43476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evtGi-0002Pq-3O for importer@patchew.org; Tue, 13 Mar 2018 19:23:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsif-0006Jh-Hr for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evsib-00044h-6a for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:33 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:36937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evsia-000444-Vx for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:29 -0400 Received: by mail-wr0-x242.google.com with SMTP id z12so2563700wrg.4 for ; Tue, 13 Mar 2018 15:48:28 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.48.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=298X1TXy5qi3jxahN8yymiR5sm+0Q0Al552aCZLr0wY=; b=Elf3/FsRZf6KBM426PPO99jPeyO2Ug4skRNxUk0kLjO8EfCQLtIskc+vUDz4ErLRK4 4HruvzOj6V8xiMgav7MVMzvlvi+ateqQsNrv+C1KJdUr4a64COmzJBT2t3iY2pJWr+9o qFFwVHeStPn4T+/D3HzKJKceSBcRoBDbkBxliKeueQivMWbs11IpLvk2KsxRR2YY/ghw zi6s/V1G89EB5fuP6yxgzF7i80wCxv0w2HguLtcMOk93+MJqvkZeu2/aM3C04WL8G6LB pI0HqtbDN7erZi4qU7SgLjHTA4di/oa8/TFkdwMBrzl5KyCIkP58O7boG2CAJflDYU1P nvDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=298X1TXy5qi3jxahN8yymiR5sm+0Q0Al552aCZLr0wY=; b=jvzJNQk2E2sas6IAuaOGlh93LLNv5LMXJ31IQj23qGmFzjIfxT52WtfjDWZuKJis3c dIQEEEOVKDareA8rOG+bFYJuCjcQQbZ/AENE7c6urWLCbsXK7WuVJuGr0TDwnngDNLPK TD91e6cYqTlIjJDKb3avOH4QtSpX33TKbVljwcn4A5xyLIupoZCEBzNCs7wWCfwQK70M s+53PyGo/qhERgDSnOGC6aCVo4YjEMJ+8E+suLoQNcnB8QEKy/8XZ6X6r2jDkuMn57xF 968pPO+0tixxf9oUAbqZDIrOtL6O3c5GO+jddm/lJTD/OdPS7HcjFyB7+hL5/LynzOpf MpPg== X-Gm-Message-State: AElRT7EGiClZPipnaRxLYOZCHcVgqo89wulTv29/4vBhnqWvDsAtiMfy O4GOiHD73lDdoFgqGyLrtBcNbHsl X-Google-Smtp-Source: AG47ELuBJGqb03XnIJax+FVpk0udCtQ0JZa1bqT4oqrnOtpnRe61aNbiYzATRT/jJVyMLwPIrn6H4w== X-Received: by 10.223.170.157 with SMTP id h29mr1910381wrc.107.1520981307577; Tue, 13 Mar 2018 15:48:27 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:47:04 +0100 Message-Id: <20180313224719.4954-55-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 54/69] replay: fixed replay_enable_events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk This patch fixes assignment to internal events_enabled variable. Now it is set only in record/replay mode. This affects the behavior of the external functions that check this flag. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini Message-Id: <20180227095209.1060.45884.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/replay/replay-events.c b/replay/replay-events.c index 768b505f3d..e858254074 100644 --- a/replay/replay-events.c +++ b/replay/replay-events.c @@ -67,7 +67,9 @@ static void replay_run_event(Event *event) =20 void replay_enable_events(void) { - events_enabled =3D true; + if (replay_mode !=3D REPLAY_MODE_NONE) { + events_enabled =3D true; + } } =20 bool replay_has_events(void) @@ -141,7 +143,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind, =20 void replay_bh_schedule_event(QEMUBH *bh) { - if (replay_mode !=3D REPLAY_MODE_NONE && events_enabled) { + if (events_enabled) { uint64_t id =3D replay_get_current_step(); replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id); } else { @@ -161,7 +163,7 @@ void replay_add_input_sync_event(void) =20 void replay_block_event(QEMUBH *bh, uint64_t id) { - if (replay_mode !=3D REPLAY_MODE_NONE && events_enabled) { + if (events_enabled) { replay_add_event(REPLAY_ASYNC_EVENT_BLOCK, bh, NULL, id); } else { qemu_bh_schedule(bh); --=20 2.14.3