From nobody Tue Dec 16 05:37:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520983258980859.2976414230397; Tue, 13 Mar 2018 16:20:58 -0700 (PDT) Received: from localhost ([::1]:43460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evtDy-0007eN-PK for importer@patchew.org; Tue, 13 Mar 2018 19:20:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsie-0006Ig-6P for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evsiZ-00043W-Jy for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:31 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:54941) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evsiZ-00042y-CY for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:48:27 -0400 Received: by mail-wm0-x241.google.com with SMTP id h76so872351wme.4 for ; Tue, 13 Mar 2018 15:48:27 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.48.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=gQDAssWwvpvTdPo4MmLUEmGj1LK/+5tdRoynRD0rk6Y=; b=pUX3j9rADtOpNoLFPE52e8zjE5Rt1p9ZGjKMkAeLUMU/LDX8HcuSpSskVHt/+7z00R kvU/Ekp/RDqoP0+uflJalt7K1Wgcw81XBY16v+uxS9g/r5zHa/uC6G+hYzh2vyZH2S7j ZQR/0elhCcbVwyJSvNLP2pRGu0BxIQI/Y+vJIaXSByRVmeLlopDvfSyIlSpwaZSSxKkc 5dCqm0Mq2Dc9eGdO8LGsghOBxLzA7dKUJr2iaPz84ZGMSIu4uZdtyHpwWux6dkipQdnI bjGpzgcObRUPXcllAOjBmkAwCBN36Cjm/XVj0cH1cM7jWXo7lRgT7prkxfOIkt4SYM3p cp0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=gQDAssWwvpvTdPo4MmLUEmGj1LK/+5tdRoynRD0rk6Y=; b=PsfL1Nte2LD3L9yWfMirKv3qJ11fuPpoQflZtRghAsv8fxRLhw0fdFwL22CRwFqreZ NtJ6JMo8ylfIs5fp3upoKWsXrzD9ox/jQx/HocZ0/hHgIXTLSXWVx21TzGPne9ZtTrsF 0Oe4p+VvWkHER3+RxctKRx0ELaGvxdw0AJXI9MNxCA4BHaHtkR2ZOniQBIymy4CDmsuC sj1zknMWlEflIuxvBc6NK03TQASovlZrVO2rmpQnsVxdG617BdM+9Qa+7iWg9nu+l4Jc PjSUVdVSX2Qu0hXcKJVy/HUb/IKT6d65p3jRzSWjgw16gOgBhxG7fCFDhkwOqjgBMeXM DGpQ== X-Gm-Message-State: AElRT7EYQNCilFIOBajIxWxBwrJh+VBOoSwVI0MZa/IyTUwuYJoO04Z3 2GjbHRxdceqRTPSaYb9ZvleImnpx X-Google-Smtp-Source: AG47ELuzLwc+Oqo3ybqlryRd0LeXfawh6HnevQLZZHU71f/FY8n7eqEBymO6Dj42VcRTlc8PC9Z61w== X-Received: by 10.28.207.73 with SMTP id f70mr8936wmg.92.1520981306002; Tue, 13 Mar 2018 15:48:26 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:47:03 +0100 Message-Id: <20180313224719.4954-54-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 53/69] replay: fix processing async events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk Asynchronous events saved at checkpoints may invoke callbacks when processed. These callbacks may also generate/read new events (e.g. clock reads). Therefore event processing flag must be reset before callback invocation. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini Message-Id: <20180227095203.1060.70831.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/replay/replay-events.c b/replay/replay-events.c index 94a6dcccfc..768b505f3d 100644 --- a/replay/replay-events.c +++ b/replay/replay-events.c @@ -295,13 +295,13 @@ void replay_read_events(int checkpoint) if (!event) { break; } + replay_finish_event(); + read_event_kind =3D -1; replay_mutex_unlock(); replay_run_event(event); replay_mutex_lock(); =20 g_free(event); - replay_finish_event(); - read_event_kind =3D -1; } } =20 --=20 2.14.3