From nobody Tue Dec 16 07:06:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520982323262740.7380432528594; Tue, 13 Mar 2018 16:05:23 -0700 (PDT) Received: from localhost ([::1]:43369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evsyw-0003LW-Aq for importer@patchew.org; Tue, 13 Mar 2018 19:05:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evshr-0005Y7-MV for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:47:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evshq-00033V-QX for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:47:43 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:42346) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evshq-00032U-JU for qemu-devel@nongnu.org; Tue, 13 Mar 2018 18:47:42 -0400 Received: by mail-wr0-x241.google.com with SMTP id s18so2505702wrg.9 for ; Tue, 13 Mar 2018 15:47:42 -0700 (PDT) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id x107sm1557951wrb.97.2018.03.13.15.47.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 15:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BY+Necp4Mpvv48CjfR6C29VX7sXN9k6ii0bVCQH3u2Y=; b=DuyUM3gSNp2LkQkCPJqDZkA/4SHM3lTvKkcN/+/WlMqJk0VHjaFGHA+lVG8C7BXJVy m0oBjpixg0FH0LSsfmLcG3aZZDV6BMA8jaW3X32e/QWkwkpXMaFw2Hu5neZ6wVk4gKur aoFkv+0Gfc8b4PJs9So3quO9/vKIig4hqoO0irP/MxB6lS6FNExVBNPm5Kus95Jn7CxM CWcoC9XF2d6XFprGymdlLzPveXZSjXr1FbEL6gxEzCxVnIReK9bp106Gm4X18wxlAw1F hgGvdEsBJ2O1+6VD+ov4c48bl1Z2sAaY+7TLgFTWP1EAJtnDF/6YgIoBfW8EFtxrPoH1 +UgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BY+Necp4Mpvv48CjfR6C29VX7sXN9k6ii0bVCQH3u2Y=; b=eDo4UiswlRSWmn7LM+AmUoOYxD4S8UgS3VH0m6/5m7VC7yMZsfYIcWEDJSrvCaNm3c Wf7ZNoLQXkGFIEpoIKN7dIuMhjS1kWo/j6jTmVNGNJQTnwWIFhPIeQ0pmwxpGm58kXEF ltYIzKDTmWS85aghGxvzAPZHr13GqoZ3WagoW0NibXMXAi0Lp95TR0DPaZHcV7H0C0jJ IXdOvkn+ambnAvpIjaLfFr9cVvfJydh6oidoztY1HQ/hnxrP58axLySdwkVM+DHjPNdk azp4keGTqYWqFaad0HLIYszTy2LnvtuM0+qDEwiCn8ne4z/0NNYqDtHJF6/mt1LHrcbJ M4/g== X-Gm-Message-State: AElRT7H2O+I+GQ21arHK6jxMejiN1FCOHcKOQm2WXPPitvJjzRtK8GVJ fl83Z3z6pT8+N0dMw9bk+QaMEY2S X-Google-Smtp-Source: AG47ELvPfO5YPZCxh6SzMmBpU9pwrip/IoyLN/zBnhrcpWfocNqrN0myA+kE1tydCnXfgIegOP5Y6g== X-Received: by 10.223.195.206 with SMTP id d14mr2024743wrg.0.1520981261186; Tue, 13 Mar 2018 15:47:41 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 23:46:26 +0100 Message-Id: <20180313224719.4954-17-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313224719.4954-1-pbonzini@redhat.com> References: <20180313224719.4954-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 16/69] chardev: tcp: postpone async connection setup X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Xu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Peter Xu This patch allows the socket chardev async connection be setup with non-default gcontext. We do it by postponing the setup to machine done, since until then we can know which context we should run the async operation on. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Xu Message-Id: <20180306053320.15401-8-peterx@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Paolo Bonzini --- chardev/char-socket.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 09aa345869..f6ad6ee4d8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1005,9 +1005,8 @@ static void qmp_chardev_open_socket(Chardev *chr, s->reconnect_time =3D reconnect; } =20 - if (s->reconnect_time) { - tcp_chr_connect_async(chr); - } else { + /* If reconnect_time is set, will do that in chr_machine_done. */ + if (!s->reconnect_time) { if (s->is_listen) { char *name; s->listener =3D qio_net_listener_new(); @@ -1139,6 +1138,17 @@ char_socket_get_connected(Object *obj, Error **errp) return s->connected; } =20 +static int tcp_chr_machine_done_hook(Chardev *chr) +{ + SocketChardev *s =3D SOCKET_CHARDEV(chr); + + if (s->reconnect_time) { + tcp_chr_connect_async(chr); + } + + return 0; +} + static void char_socket_class_init(ObjectClass *oc, void *data) { ChardevClass *cc =3D CHARDEV_CLASS(oc); @@ -1154,6 +1164,7 @@ static void char_socket_class_init(ObjectClass *oc, v= oid *data) cc->chr_add_client =3D tcp_chr_add_client; cc->chr_add_watch =3D tcp_chr_add_watch; cc->chr_update_read_handler =3D tcp_chr_update_read_handler; + cc->chr_machine_done =3D tcp_chr_machine_done_hook; =20 object_class_property_add(oc, "addr", "SocketAddress", char_socket_get_addr, NULL, --=20 2.14.3