From nobody Tue Feb 10 03:39:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520966304827585.619621497374; Tue, 13 Mar 2018 11:38:24 -0700 (PDT) Received: from localhost ([::1]:41964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evooa-0005Q3-17 for importer@patchew.org; Tue, 13 Mar 2018 14:38:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evnoi-000093-P2 for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evnog-0007yp-6F for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:28 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:43713) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evnof-0007xJ-To for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:26 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0LyPw2-1ebiIX0LyQ-015tF8; Tue, 13 Mar 2018 18:34:11 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 18:33:55 +0100 Message-Id: <20180313173355.4468-19-laurent@vivier.eu> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313173355.4468-1-laurent@vivier.eu> References: <20180313173355.4468-1-laurent@vivier.eu> X-Provags-ID: V03:K0:QHskIiiOwRBpS13p83d8m3f4FkWHhvvqISkU92C7DwNwr716PvA I+Td38q+L8TcwB+6eXdmHpsbovx3r2zhY9mwBNrgPcbIRU1tN1/UIKg7nB1TdFhppcgCpyb W8mEUAaihtO8lrL17O4J3nwYxAXZLLsm5MZZBmL4ZxBY8Rn/sQPYAUQLaeBxPS9lngz+N0q GDDFUTrHtFwGofw+weNFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CP+mLCLdT00=:FFXM4d+EphBwT10PS2CCJ7 Udp0KqpdutLodP/qDMEGb9gdmvUTh8K6vwCvtBaD/fgGL5S87fAMqCY/bsfc8pRxjdtQFCIYZ 9nlE9EbbLXjPtKrJVMtuLobtIHKUgQzOaqU6DCLYxFRjZeVY/npf7T0y7sI+Qxw7dOCZTSc/U Uxf25P+jlcKsp2Ng9zOm2dralVmB8kjLtSdSx861q1bdPHZR5VUttHCzDdmQUumauz/Nc7d+5 2faWbk0VJ7lL3xs+r3lFBCfrHM7eO/Qv3MLju7rzKivQJ6anCFny6xBu6DKJmC6DS5PmuVjtb y4uPqmhc0XTjulueRPZYuVB+ycqR4JtnPTD9OPZuFRkxa0o7Ae9yYqZDN+Rldm1bDlIVPezNE LypfWg30dGrh1KtT2kz5gKg8Jv8G/7+KX/T7pJ5vvBpkSDeb98hLm0rAt20kwD2I0B5CiXUB1 OiNTkKP1qvLPKto62iOiN8JDrj7gzXG0ZxC56U679ClUSPM2hHM8EJqOKPyQ5wwOg/Ir4BPHY SFPPgO7iHO7GqgNAKmZJrWJM7PVbEE/KuhAh3yJQ8xwgYU2NkcL4Zv8dXd0y+P04OqP2FsZLq NByzCgy7XR/VDJyyKX0bHUSn/YS3lhwtQe1ftOJnqK7bSaVlQG3wS+0COf4bdG9jNItx3yWNV NkY5gINqV1aXPKNoMtY/RjRod5m3E2n+ObFR5NDaKStXjzEZXkV/L3lWQOyIyqsxks2u/55Mk XmUMxmO3CqhFH/ZsOHhupe9yGagv4wXJcYojwA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL 18/18] linux-user: init_guest_space: Add a comment about search strategy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luke Shumaker , Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Luke Shumaker Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-10-lukeshu@lukeshu.com> Reviewed-by: Peter Maydell Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 5c64299961..9d10a5f592 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1910,6 +1910,10 @@ unsigned long init_guest_space(unsigned long host_st= art, * happen often. Probably means we got unlucky and host * address space randomization put a shared library somewhere * inconvenient. + * + * This is probably a good strategy if host_start, but is + * probably a bad strategy if not, which means we got here + * because of trouble with ARM commpage setup. */ munmap((void *)real_start, real_size); current_start +=3D qemu_host_page_size; --=20 2.14.3