From nobody Tue Feb 10 03:39:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520964519744697.4427720374787; Tue, 13 Mar 2018 11:08:39 -0700 (PDT) Received: from localhost ([::1]:41741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evoLi-0004nr-QG for importer@patchew.org; Tue, 13 Mar 2018 14:08:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evnoh-00007B-Bz for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evnof-0007xo-Dr for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:27 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:47571) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evnof-0007wH-2I for qemu-devel@nongnu.org; Tue, 13 Mar 2018 13:34:25 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MDkte-1eqtjj2eRa-00H60M; Tue, 13 Mar 2018 18:34:09 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2018 18:33:52 +0100 Message-Id: <20180313173355.4468-16-laurent@vivier.eu> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180313173355.4468-1-laurent@vivier.eu> References: <20180313173355.4468-1-laurent@vivier.eu> X-Provags-ID: V03:K0:WkxBN5hY50LbmGMxW+p3d66kRdSazfiAiaJBRVJUnKj/st70GWK se7i1eiIb3uC7lLhe/ebMRv/NUGkQG4hqbDmcaRs1+PFl2w1oMFxypvDIkKPR4fyO4zZ/fU T1QM2wh1ce0/Ur+fu6Tb3zD30CPghaUnJWyPkNz7hHYaJgy+CSxf4bi/JUoj93ShYzs5fH4 u5LdQf4P9inXdIMyKH7lQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:e0G/VGmQ4jA=:3FoqVEEuXz7neolIQntbiw deVRqD9cFqV0RQsUU//C+jJ7vLemArgHEAV/k2DrB2JjEVoVqjLi71G6H9Cc5P/g8lre67s1e zyr7jxYPuXoYje8vS0cr7suAmlNiajqGhjvdD0F63C3AJOEF4FKetmq1LdTu0eVwtmk5NdyGM dSQVzW1xTTv9PgzSjodYmfHYevHLvJWIWiXzKRDmKnpmbE4dd8QvcEFjb45l/7Q9M6J5rA7ZV z2fVj1DQxKXIbzI814iEbDZ++By9YXLZBCjP9DqZiLu0KzSuFveGX0xVHZTwWtu3d2UgScR3/ 8Wg9q+9ir3VUQ3SpjXWlMji9640h5C10pCFlfjIQdoZKBBbpZ/V+yy1MkyFM9Wg+1Q0hEebiU RQWJsH6JkLYcv/Mebh1g8wba2TCC0F/MAVgdtfWgUBMWqgN6oDkRjUgyNQJK/ZP9tHn2pwfcd NAnt5WPtl8uY8NvsMbM1jQdo8s1495ZrHVU9u2DSSXw+el3S2K32bllMUtIE/mqxkH9cT2Wjt 68LlZGZS9xxlOjeeAqQYPsa6mbxyknZs4uSG7aTlZrYuX4VUtFltcuoSIXfcHMF1u3/EirXjI P4tipv9ekzWmDNQQgPOM8EdA2V1nAwzz3dp7zQIo5Ff0bTQzwqaQXcQNQL/EC8iME1SUG9rcp ikGWqmbL7/wL6PfZx1UYZDUPN/lpMgfr/ujA5gi9wWBe0/JEJdLXSs+Xizjdf+P4cAMDL/Jdu v3I1LgDQOYr3RhL0Hmx+HANiAtRP7qJhq+m0Jw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL 15/18] linux-user: init_guest_commpage: Add a comment about size check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luke Shumaker , Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Luke Shumaker Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-7-lukeshu@lukeshu.com> Reviewed-by: Peter Maydell Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 653157876c..8699f430b1 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -374,6 +374,11 @@ static int init_guest_commpage(unsigned long guest_bas= e, =20 /* If the commpage lies within the already allocated guest space, * then there is no way we can allocate it. + * + * You may be thinking that that this check is redundant because + * we already validated the guest size against MAX_RESERVED_VA; + * but if qemu_host_page_mask is unusually large, then + * test_page_addr may be lower. */ if (test_page_addr >=3D guest_base && test_page_addr < (guest_base + guest_size)) { --=20 2.14.3