From nobody Fri May 3 00:15:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520868981928947.710698288015; Mon, 12 Mar 2018 08:36:21 -0700 (PDT) Received: from localhost ([::1]:59625 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evPUq-0004Rz-UZ for importer@patchew.org; Mon, 12 Mar 2018 11:36:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evPT1-0003Mg-SU for qemu-devel@nongnu.org; Mon, 12 Mar 2018 11:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evPSy-0003TN-NN for qemu-devel@nongnu.org; Mon, 12 Mar 2018 11:34:27 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:38584) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evPSy-0003Si-Fc for qemu-devel@nongnu.org; Mon, 12 Mar 2018 11:34:24 -0400 Received: by mail-wm0-x242.google.com with SMTP id z9so16935037wmb.3 for ; Mon, 12 Mar 2018 08:34:24 -0700 (PDT) Received: from localhost.localdomain ([185.222.219.238]) by smtp.gmail.com with ESMTPSA id d30sm3951171edd.79.2018.03.12.08.34.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Mar 2018 08:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zXaIgMhWuaqqSVAqSqi0a/vpN62itoimhHe6rlEpyxI=; b=ZUqKVh5wqxjOEphjFOcMD2J8ul8Cnw6fajbMYAbEBoEZq3hP1n3iHDhBq2D0OxFtIs m2CRwtDwhJkulaJRWuSK1T2GR3PsDFh9YgfcK8nym6vsgrc9uuVlaLGTuN63a26v3eOa B8wK4hxYaKMCFrQRoGEXjngbCBtyiTZw8Qrmbe+WVro5FyoLD8yTjdWHaAkccbbVpey1 YD4/WJCx8LD8I84EnEEV4sfyGo+Jyu/b8PKkukKU3/34+cP6ejy7bU1EIIRnRZ1/N8yj P8Ho5HJSgziz8rIhGSOJqZKJerQlPWSiXYo+cDWB1XmrjUQ9pb2WbKoWdGTSLrg+ZtIe aFgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zXaIgMhWuaqqSVAqSqi0a/vpN62itoimhHe6rlEpyxI=; b=aqUUPazfaWCsk3uZzi95juO0kdHiByRw+/qRmXMlSKsiUgCI6i1o9235E4GjpnuxfQ nigUqow3Pc4wss9QuNAWO+AJWV596rtm/Jc3dcG0Rou4A9pwaBIHkkjylY+UBqJra3cZ vr2P+OMMjznV2FywY6Jf3eSo1Ex0NdtW9QBBAmI/UpkrZOjGVeg5vclqYJwLC4tD4Q/E sPgSNsXrBqeyD1iLFXyrIcBlI2BEwzVysvRCbEaNoLykZKsyTgOcQtFfAI4teHn3dd7+ 88bWxUl1UNDTK5S02en6ds2Or4bGGJo28Nc50pgXX0ObVZmYjT1ExFT3L1yzRXsHcVRh TRnQ== X-Gm-Message-State: AElRT7FRZ4UlBF8lvHLJ06Or1wXtR6HE4STARRavnU5JQf8vo0oYOhFr Kb/sY4O8tI6uvTgOQyV3/lilkg== X-Google-Smtp-Source: AG47ELuNyA7IxB1E3NcgJgFMR6x25I1QMvu1QoD/GQrB/18koHeft62kJxP7mOUR7F8iWF+sPvEfoA== X-Received: by 10.80.200.203 with SMTP id k11mr10756943edh.161.1520868863152; Mon, 12 Mar 2018 08:34:23 -0700 (PDT) From: Nia Alarie To: qemu-devel@nongnu.org Date: Mon, 12 Mar 2018 15:33:44 +0000 Message-Id: <20180312153344.23453-1-nia.alarie@gmail.com> X-Mailer: git-send-email 2.16.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH v2] 9p: Convert use of atoi to qemu_strtoi to allow error checking X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@gmail.com, jim@groklearning.com, Nia Alarie , groug@kaod.org, joel@jms.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Nia Alarie --- hw/9pfs/9p.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48fa48e720..254385dfa4 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -15,6 +15,7 @@ #include #include "hw/virtio/virtio.h" #include "qapi/error.h" +#include "qemu/cutils.h" #include "qemu/error-report.h" #include "qemu/iov.h" #include "qemu/sockets.h" @@ -2213,8 +2214,14 @@ static void coroutine_fn v9fs_create(void *opaque) } v9fs_path_copy(&fidp->path, &path); } else if (perm & P9_STAT_MODE_LINK) { - int32_t ofid =3D atoi(extension.data); - V9fsFidState *ofidp =3D get_fid(pdu, ofid); + int ofid; + V9fsFidState *ofidp; + + if (qemu_strtoi(extension.data, NULL, 10, &ofid)) { + err =3D -EINVAL; + goto out; + } + ofidp =3D get_fid(pdu, (int32_t)ofid); if (ofidp =3D=3D NULL) { err =3D -EINVAL; goto out; --=20 2.16.2