[Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h

Stefan Hajnoczi posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180312132204.23683-1-stefanha@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test s390x passed
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
[Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
Posted by Stefan Hajnoczi 6 years ago
The include/block/aio-wait.h header file was added by commit
7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f409f3b158..7adc04e477 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1331,6 +1331,7 @@ F: util/aio-*.c
 F: block/io.c
 F: migration/block*
 F: include/block/aio.h
+F: include/block/aio-wait.h
 F: scripts/qemugdb/aio.py
 T: git git://github.com/stefanha/qemu.git block
 
-- 
2.14.3


Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
Posted by Eric Blake 6 years ago
On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote:
> The include/block/aio-wait.h header file was added by commit
> 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.

A shame checkpatch.pl and/or patchew still doesn't flag this, even 
though it's been proposed as a syntax check.

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f409f3b158..7adc04e477 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1331,6 +1331,7 @@ F: util/aio-*.c
>   F: block/io.c
>   F: migration/block*
>   F: include/block/aio.h
> +F: include/block/aio-wait.h
>   F: scripts/qemugdb/aio.py
>   T: git git://github.com/stefanha/qemu.git block
>   
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
Posted by Fam Zheng 6 years ago
On Mon, 03/12 09:05, Eric Blake wrote:
> On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote:
> > The include/block/aio-wait.h header file was added by commit
> > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
> 
> A shame checkpatch.pl and/or patchew still doesn't flag this, even though
> it's been proposed as a syntax check.

Re checkpatch.pl vs patchew, IMO this check fits better in the former.

Fam

Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
Posted by Stefan Hajnoczi 6 years ago
On Mon, Mar 12, 2018 at 01:22:04PM +0000, Stefan Hajnoczi wrote:
> The include/block/aio-wait.h header file was added by commit
> 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan