From nobody Sat May 4 09:34:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520861184815207.82222874684942; Mon, 12 Mar 2018 06:26:24 -0700 (PDT) Received: from localhost ([::1]:58794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evNT2-0002Oh-AU for importer@patchew.org; Mon, 12 Mar 2018 09:26:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evNLA-0003rT-HQ for qemu-devel@nongnu.org; Mon, 12 Mar 2018 09:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evNL7-0006MI-Ao for qemu-devel@nongnu.org; Mon, 12 Mar 2018 09:18:12 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51910 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1evNL7-0006KL-6K for qemu-devel@nongnu.org; Mon, 12 Mar 2018 09:18:09 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FB4881A6D2B; Mon, 12 Mar 2018 13:18:08 +0000 (UTC) Received: from localhost (unknown [10.36.118.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1BCF215CDA7; Mon, 12 Mar 2018 13:18:07 +0000 (UTC) From: Stefan Hajnoczi To: Date: Mon, 12 Mar 2018 13:18:06 +0000 Message-Id: <20180312131806.23209-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 12 Mar 2018 13:18:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 12 Mar 2018 13:18:08 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'stefanha@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Warn if files are added/renamed/deleted without MAINTAINERS file changes. This has helped me in Linux and we could benefit from this check in QEMU. This patch is a manual cherry-pick of Linux commit 13f1937ef33950b1112049972249e6191b82e6c9 ("checkpatch: emit a warning on file add/move/delete") by Joe Perches . Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster --- Note the 80-char lines are from upstream code. Keep them as-is. scripts/checkpatch.pl | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d1fe79bcc4..d0d8f63d48 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1177,6 +1177,7 @@ sub process { our $clean =3D 1; my $signoff =3D 0; my $is_patch =3D 0; + my $reported_maintainer_file =3D 0; =20 our @report =3D (); our $cnt_lines =3D 0; @@ -1379,6 +1380,24 @@ sub process { } } =20 +# Check if MAINTAINERS is being updated. If so, there's probably no need = to +# emit the "does MAINTAINERS need updating?" message on file add/move/dele= te + if ($line =3D~ /^\s*MAINTAINERS\s*\|/) { + $reported_maintainer_file =3D 1; + } + +# Check for added, moved or deleted files + if (!$reported_maintainer_file && + ($line =3D~ /^(?:new|deleted) file mode\s*\d+\s*$/ || + $line =3D~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ || + ($line =3D~ /\{\s*([\w\/\.\-]*)\s*\=3D\>\s*([\w\/\.\-]*)\s*\}/ && + (defined($1) || defined($2))))) { + $is_patch =3D 1; + $reported_maintainer_file =3D 1; + WARN("added, moved or deleted file(s), does MAINTAINERS need updating?\= n" . + $herecurr); + } + # Check for wrappage within a valid hunk of the file if ($realcnt !=3D 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("patch seems to be corrupt (line wrapped?)\n" . --=20 2.14.3