From nobody Sat Oct 25 08:57:37 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520799264302273.2492418811437; Sun, 11 Mar 2018 13:14:24 -0700 (PDT) Received: from localhost ([::1]:55479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev7MF-0004SR-3K for importer@patchew.org; Sun, 11 Mar 2018 16:14:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev7LR-0003x8-IJ for qemu-devel@nongnu.org; Sun, 11 Mar 2018 16:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev7LO-0005Jp-Cx for qemu-devel@nongnu.org; Sun, 11 Mar 2018 16:13:25 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:56125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ev7LO-0005Iq-6N for qemu-devel@nongnu.org; Sun, 11 Mar 2018 16:13:22 -0400 Received: by mail-wm0-x241.google.com with SMTP id q83so12676232wme.5 for ; Sun, 11 Mar 2018 13:13:21 -0700 (PDT) Received: from localhost.localdomain ([185.222.219.238]) by smtp.gmail.com with ESMTPSA id x16sm4169913edd.52.2018.03.11.13.13.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 13:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=JcEFwCDtXwF7YBlQ1NVo2Jy2Uk7Sm6nMKW2QjzM+PUI=; b=XZW2Ui0XKlqNMwXsRZFNCEdvDR6AcrtjxsT8Kd5onjlxbAoQgjINEnmYGuBMN7aOb5 f7qK1XM+VJe2YcKnEsMCmNRapdN1d6VnMC9pxBVjJmHHDdWxi3cQf4MCZWJjIHL9Abqr lWvdPOH06SkL3AQ9ToMQK9I0v65kLApvGB+2f/Z+uir4eENqeV8Z9uMZ/0rEnmjDUijY hFrfV+V47Rk0MieenZnXL1rRL93b5X1FBiK3xf9X7kjIi9xmZJb5zl7LHTyVfgmU4FtQ fVJW5hCqHN40IMcop3KzQAGIMvki0Bkum4SHbf6qzSEpMa2/uN3p+k3FAd34tzGs19+E jMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JcEFwCDtXwF7YBlQ1NVo2Jy2Uk7Sm6nMKW2QjzM+PUI=; b=DJBf73aTUcYnMGnseGFNP1ma8snAFkvKuyRGhym0uRvg7C9nOzzYdjkLoqXQDUruFp 3dEgdRhofF/sCVKwgYWqcr0aodwn5y/xUavjwKurWN15FsGO1PoP2LfM74SMMbYIkBnh 6o4bcSR/yi/TluyCr6lLPYvEru91lLiZ6lj18WS6LJVYktETQ6shsQQFpc9Ru9MGdoYN lrU4s1lu8pH9hKMNA3I60OTBQ4+PDMSOVJAcA63GyqCesB8PCdcEDDVvpNZWOys2foJT /zMjdT1DvWFPugQPC6kzR7EYGQzRIXkW+udL6r4t0ioFIbSxYKYxwMcXewz1ksbD0ag+ TViA== X-Gm-Message-State: AElRT7Hs1mORcRJECaSsORkaWKHdww4LQ3jot7sdDMJFwbaBB21f2avv WK1zIB6i3+GXKh3TiZ4j5lQqjQ== X-Google-Smtp-Source: AG47ELtNVhMATMMMvYHtuJt71DEf1S2kovT+OsIY1KbfgM09eNzvIkjtZO4K3bAH0at/Du4teDCMfA== X-Received: by 10.80.138.155 with SMTP id j27mr7955200edj.36.1520799200529; Sun, 11 Mar 2018 13:13:20 -0700 (PDT) From: Nia Alarie To: qemu-devel@nongnu.org Date: Sun, 11 Mar 2018 20:12:39 +0000 Message-Id: <20180311201239.25506-1-nia.alarie@gmail.com> X-Mailer: git-send-email 2.16.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@gmail.com, jim@groklearning.com, Nia Alarie , groug@kaod.org, joel@jms.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Nia Alarie --- hw/9pfs/9p.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48fa48e720..64f3bb976c 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -15,6 +15,7 @@ #include #include "hw/virtio/virtio.h" #include "qapi/error.h" +#include "qemu/cutils.h" #include "qemu/error-report.h" #include "qemu/iov.h" #include "qemu/sockets.h" @@ -2213,8 +2214,15 @@ static void coroutine_fn v9fs_create(void *opaque) } v9fs_path_copy(&fidp->path, &path); } else if (perm & P9_STAT_MODE_LINK) { - int32_t ofid =3D atoi(extension.data); - V9fsFidState *ofidp =3D get_fid(pdu, ofid); + long ofid; + V9fsFidState *ofidp; + + if (qemu_strtol(extension.data, NULL, 10, &ofid) || + ofid > INT32_MAX || ofid < INT32_MIN) { + err =3D -EINVAL; + goto out; + } + ofidp =3D get_fid(pdu, (int32_t)ofid); if (ofidp =3D=3D NULL) { err =3D -EINVAL; goto out; --=20 2.16.2