From nobody Sat Oct 25 19:45:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520627641449307.04096864716416; Fri, 9 Mar 2018 12:34:01 -0800 (PST) Received: from localhost ([::1]:47963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euOiG-0003t8-Lz for importer@patchew.org; Fri, 09 Mar 2018 15:34:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euOdL-00007F-BU for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:28:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euOdI-0006sg-70 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:28:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1euOdI-0006sU-1O for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:28:52 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57F7BC0587E5; Fri, 9 Mar 2018 20:28:51 +0000 (UTC) Received: from localhost (ovpn-116-64.gru2.redhat.com [10.97.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF8E7183B7; Fri, 9 Mar 2018 20:28:45 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 9 Mar 2018 17:28:24 -0300 Message-Id: <20180309202827.12085-6-ehabkost@redhat.com> In-Reply-To: <20180309202827.12085-1-ehabkost@redhat.com> References: <20180309202827.12085-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 09 Mar 2018 20:28:51 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 5/8] device-crash-test: Remove runnable-machine check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This optimization to skip tests if the machine is not runnable is unreliable and makes the script ignore actual QEMU crashes, so we're safer simply removing it. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index b9a7470efc..f406890519 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -372,33 +372,6 @@ class QemuBinaryInfo(object): finally: vm.shutdown() =20 - def machineInfo(self, machine): - """Query for information on a specific machine-type - - Results are cached internally, in case the same machine- - type is queried multiple times. - """ - if machine in self._machine_info: - return self._machine_info[machine] - - mi =3D {} - args =3D ['-S', '-machine', '%s' % (machine)] - dbg("querying machine info for binary=3D%s machine=3D%s", self.bin= ary, machine) - vm =3D QEMUMachine(binary=3Dself.binary, args=3Dargs) - try: - vm.launch() - mi['runnable'] =3D True - except KeyboardInterrupt: - raise - except: - dbg("exception trying to run binary=3D%s machine=3D%s", self.b= inary, machine, exc_info=3Dsys.exc_info()) - dbg("log: %r", vm.get_log()) - mi['runnable'] =3D False - - vm.shutdown() - self._machine_info[machine] =3D mi - return mi - def defaultMachine(self): """Default machine-type for the QEMU binary =20 @@ -613,9 +586,7 @@ def main(): total +=3D 1 =20 expected_match =3D findExpectedResult(t) - if (args.quick and - (expected_match or - not getBinaryInfo(args, t['binary']).machineInfo(t['machi= ne'])['runnable'])): + if args.quick and expected_match: dbg("skipped: %s", formatTestCase(t)) skipped +=3D 1 continue --=20 2.14.3