From nobody Wed Feb 11 00:59:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520610039048337.18699327271383; Fri, 9 Mar 2018 07:40:39 -0800 (PST) Received: from localhost ([::1]:46025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euK8I-0000bR-E1 for importer@patchew.org; Fri, 09 Mar 2018 10:40:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euK4s-0006Jv-Va for qemu-devel@nongnu.org; Fri, 09 Mar 2018 10:37:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euK4r-0008BT-29 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 10:37:02 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:32840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euK4q-0008Az-N7 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 10:37:00 -0500 Received: by mail-wm0-x241.google.com with SMTP id s206so3968075wme.0 for ; Fri, 09 Mar 2018 07:37:00 -0800 (PST) Received: from x1.local (ABayonne-654-1-76-150.w86-222.abo.wanadoo.fr. [86.222.219.150]) by smtp.gmail.com with ESMTPSA id m191sm1584175wma.21.2018.03.09.07.36.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Mar 2018 07:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nhrZTibFV1HAW43jOOeBY1azsR9k1jXCwqjY/Rw7MVI=; b=PVRL1kWHhytHErDX2QjLmM0Dr7IyMOEsdN2wJKKf45LAJ1IiaQ/fVLWxG5fJiDFkWG j1/5FIKlpfXBQGgtA9ENFZ6N00RYwJiu/is4tN1DJdEHGOHW9qL1Vj8fLqaEs9/6A4XM RWhL8DPVzXtSaT28o2QBVpA283Mp6aL7eYqcuj0YCtmbFPDlljvnzhtzdur/Kc1GC88J lRyvXJky7zsrgPLnqdH9w7utBz0CmiRCc9Dv+10T+kWdrxyb+IFitBbH/72Jf8lzPbb6 dWe6U5ZYDsBDQpyCSSrXRMsUxSKWZPnRJWl5sjeatB7xCVaW3HIsd9V7T0zaVGYNZIOi DaMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nhrZTibFV1HAW43jOOeBY1azsR9k1jXCwqjY/Rw7MVI=; b=gM98wkN9CsNgCirGM+KFPQBoT9d0Pp8zK1sv2D1RS2/mIvlvkHHBR/QLvuiDU+xbrk cNAy+Cs4TFbZ8ke9vpjuRs7UIs1eL3yaGwkZRvBw/h+0kMCayotGYzBx5y9ensqvyR9M QVjNO2kyVo1oHhG0BObNMoyNOn0imefnVaEXjDTwHYlBP3NyQINxPWxD39xx+TuRRvZe IfTxHVT7uXVVp5v4daNCRpDcB5MdzQU3dc00bSiOniWmHgQJZgWZxsvGCOihpc0fKTRC 443NmrMpd3KEZxplsRUtHa9am8aaL+tTBsd0rPHW9LgaHxX/AUh7tjcy0NJPzSRh+adv IxQQ== X-Gm-Message-State: AElRT7EAvK6IhzPP7TtIl7JtPveHjC8KviRTI8dF0bYpAHlINJPIfqHr bXAo44pyNmXhaiw3GQOBmYM3M38x X-Google-Smtp-Source: AG47ELtGAomQhcxNhzqh3NXTMcWtL9gJTcX+k7zSzUaSc8aAGn/KhxFx79s1P2Vf30tbwcHaTWgnTA== X-Received: by 10.28.192.24 with SMTP id q24mr2393017wmf.91.1520609819589; Fri, 09 Mar 2018 07:36:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , "Edgar E . Iglesias" Date: Fri, 9 Mar 2018 16:36:47 +0100 Message-Id: <20180309153654.13518-2-f4bug@amsat.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180309153654.13518-1-f4bug@amsat.org> References: <20180309153654.13518-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH 1/8] sdcard: Do not trace CMD55, except when we already expect an ACMD X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/sd/sd.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 933890e86f..4a9520e38e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -866,13 +866,18 @@ static void sd_lock_command(SDState *sd) sd->card_status &=3D ~CARD_IS_LOCKED; } =20 -static sd_rsp_type_t sd_normal_command(SDState *sd, - SDRequest req) +static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) { uint32_t rca =3D 0x0000; uint64_t addr =3D (sd->ocr & (1 << 30)) ? (uint64_t) req.arg << 9 : re= q.arg; =20 - trace_sdcard_normal_command(req.cmd, req.arg, sd_state_name(sd->state)= ); + /* CMD55 precedes an ACMD, so we are not interested in tracing it. + * However there is no ACMD55, so we want to trace this particular cas= e. + */ + if (req.cmd !=3D 55 || sd->expecting_acmd) { + trace_sdcard_normal_command(req.cmd, req.arg, + sd_state_name(sd->state)); + } =20 /* Not interpreting this as an app command */ sd->card_status &=3D ~APP_CMD; --=20 2.16.2