[Qemu-devel] [PULL 0/8] M68k for 2.12 patches

Laurent Vivier posted 8 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180309142630.2170-1-laurent@vivier.eu
Test checkpatch failed
Test docker-mingw@fedora passed
There is a newer version of this series
target/m68k/fpu_helper.c            |   35 ++
target/m68k/helper.h                |    7 +
target/m68k/softfloat.c             | 1019 +++++++++++++++++++++++++++++++++++
target/m68k/softfloat.h             |    8 +
target/m68k/softfloat_fpsp_tables.h |  374 +++++++++++++
target/m68k/translate.c             |   21 +
6 files changed, 1464 insertions(+)
create mode 100755 target/m68k/softfloat_fpsp_tables.h
[Qemu-devel] [PULL 0/8] M68k for 2.12 patches
Posted by Laurent Vivier 6 years ago
The following changes since commit e1ee9ee139ed7091c2c592d5b784fbb7227bfc0d:

  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180306' into staging (2018-03-06 10:21:35 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu-m68k.git tags/m68k-for-2.12-pull-request

for you to fetch changes up to 2c7c1717175c9a522746fb43316a63e16a636c7b:

  target/m68k: implement ftentox (2018-03-09 15:10:42 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Laurent Vivier (8):
  target/m68k: define floatx80_move()
  target/m68k: implement flognp1
  target/m68k: implement flogn
  target/m68k: implement flog10
  target/m68k: implement flog2
  target/m68k: implement fetox
  target/m68k: implement ftwotox
  target/m68k: implement ftentox

 target/m68k/fpu_helper.c            |   35 ++
 target/m68k/helper.h                |    7 +
 target/m68k/softfloat.c             | 1019 +++++++++++++++++++++++++++++++++++
 target/m68k/softfloat.h             |    8 +
 target/m68k/softfloat_fpsp_tables.h |  374 +++++++++++++
 target/m68k/translate.c             |   21 +
 6 files changed, 1464 insertions(+)
 create mode 100755 target/m68k/softfloat_fpsp_tables.h

-- 
2.14.3


Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches
Posted by no-reply@patchew.org 6 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180309142630.2170-1-laurent@vivier.eu
Subject: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180309142630.2170-1-laurent@vivier.eu -> patchew/20180309142630.2170-1-laurent@vivier.eu
 * [new tag]               patchew/20180309143704.13420-1-kraxel@redhat.com -> patchew/20180309143704.13420-1-kraxel@redhat.com
Switched to a new branch 'test'
5e3764cd71 target/m68k: implement ftentox
129d677ada target/m68k: implement ftwotox
938c4bd99b target/m68k: implement fetox
7364da0f5a target/m68k: implement flog2
7e25fb5a48 target/m68k: implement flog10
e2e2db69d6 target/m68k: implement flogn
a4de7c4950 target/m68k: implement flognp1
cd93226a31 target/m68k: define floatx80_move()

=== OUTPUT BEGIN ===
Checking PATCH 1/8: target/m68k: define floatx80_move()...
Checking PATCH 2/8: target/m68k: implement flognp1...
ERROR: do not set execute permissions for source files
#281: FILE: target/m68k/softfloat_fpsp_tables.h

total: 1 errors, 0 warnings, 408 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/8: target/m68k: implement flogn...
Checking PATCH 4/8: target/m68k: implement flog10...
Checking PATCH 5/8: target/m68k: implement flog2...
Checking PATCH 6/8: target/m68k: implement fetox...
Checking PATCH 7/8: target/m68k: implement ftwotox...
Checking PATCH 8/8: target/m68k: implement ftentox...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches
Posted by Peter Maydell 6 years ago
On 9 March 2018 at 14:45,  <no-reply@patchew.org> wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:

> Checking PATCH 2/8: target/m68k: implement flognp1...
> ERROR: do not set execute permissions for source files
> #281: FILE: target/m68k/softfloat_fpsp_tables.h
>
> total: 1 errors, 0 warnings, 408 lines checked

Oops. Could you fix the file permissions and resend, please,
Laurent ?

(I don't normally worry about checkpatch issues on pull requests,
but this one seems significant enough to be worth fixing.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches
Posted by Laurent Vivier 6 years ago
Le 09/03/2018 à 15:50, Peter Maydell a écrit :
> On 9 March 2018 at 14:45,  <no-reply@patchew.org> wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
> 
>> Checking PATCH 2/8: target/m68k: implement flognp1...
>> ERROR: do not set execute permissions for source files
>> #281: FILE: target/m68k/softfloat_fpsp_tables.h
>>
>> total: 1 errors, 0 warnings, 408 lines checked
> 
> Oops. Could you fix the file permissions and resend, please,
> Laurent ?

Yes, I'm doing that now.

Thanks,
Laurent