From nobody Sun Feb 8 12:38:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520449368442654.1218317254504; Wed, 7 Mar 2018 11:02:48 -0800 (PST) Received: from localhost ([::1]:35048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eteKt-0006AG-L4 for importer@patchew.org; Wed, 07 Mar 2018 14:02:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eteIQ-0004Ub-Gb for qemu-devel@nongnu.org; Wed, 07 Mar 2018 14:00:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eteIP-0004MR-D5 for qemu-devel@nongnu.org; Wed, 07 Mar 2018 14:00:14 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58754 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eteIL-0004IK-Au; Wed, 07 Mar 2018 14:00:09 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC9918182D17; Wed, 7 Mar 2018 19:00:08 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-216.ams2.redhat.com [10.36.116.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DB36202322A; Wed, 7 Mar 2018 19:00:07 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Wed, 7 Mar 2018 19:59:16 +0100 Message-Id: <20180307185946.29366-8-kwolf@redhat.com> In-Reply-To: <20180307185946.29366-1-kwolf@redhat.com> References: <20180307185946.29366-1-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 07 Mar 2018 19:00:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 07 Mar 2018 19:00:08 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'kwolf@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v4 07/37] qcow2: Use QCryptoBlockCreateOptions in qcow2_co_create() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jdurgin@redhat.com, pkrempa@redhat.com, mitake.hitoshi@lab.ntt.co.jp, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, namei.unix@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Instead of passing the encryption format name and the QemuOpts down, use the QCryptoBlockCreateOptions contained in BlockdevCreateOptions. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 62 +++++++++++++++++++++++++++++++++++++++++++------------= ---- 1 file changed, 45 insertions(+), 17 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index b7df2d5cab..e1821eb3c8 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2449,13 +2449,10 @@ static int qcow2_crypt_method_from_format(const cha= r *encryptfmt) } } =20 -static int qcow2_set_up_encryption(BlockDriverState *bs, const char *encry= ptfmt, - QemuOpts *opts, Error **errp) +static QCryptoBlockCreateOptions * +qcow2_parse_encryption(const char *encryptfmt, QemuOpts *opts, Error **err= p) { - BDRVQcow2State *s =3D bs->opaque; QCryptoBlockCreateOptions *cryptoopts =3D NULL; - QCryptoBlock *crypto =3D NULL; - int ret =3D -EINVAL; QDict *options, *encryptopts; int fmt; =20 @@ -2478,10 +2475,31 @@ static int qcow2_set_up_encryption(BlockDriverState= *bs, const char *encryptfmt, error_setg(errp, "Unknown encryption format '%s'", encryptfmt); break; } - if (!cryptoopts) { - ret =3D -EINVAL; - goto out; + + QDECREF(encryptopts); + return cryptoopts; +} + +static int qcow2_set_up_encryption(BlockDriverState *bs, + QCryptoBlockCreateOptions *cryptoopts, + Error **errp) +{ + BDRVQcow2State *s =3D bs->opaque; + QCryptoBlock *crypto =3D NULL; + int fmt, ret; + + switch (cryptoopts->format) { + case Q_CRYPTO_BLOCK_FORMAT_LUKS: + fmt =3D QCOW_CRYPT_LUKS; + break; + case Q_CRYPTO_BLOCK_FORMAT_QCOW: + fmt =3D QCOW_CRYPT_AES; + break; + default: + error_setg(errp, "Crypto format not supported in qcow2"); + return -EINVAL; } + s->crypt_method_header =3D fmt; =20 crypto =3D qcrypto_block_create(cryptoopts, "encrypt.", @@ -2489,8 +2507,7 @@ static int qcow2_set_up_encryption(BlockDriverState *= bs, const char *encryptfmt, qcow2_crypto_hdr_write_func, bs, errp); if (!crypto) { - ret =3D -EINVAL; - goto out; + return -EINVAL; } =20 ret =3D qcow2_update_header(bs); @@ -2499,10 +2516,9 @@ static int qcow2_set_up_encryption(BlockDriverState = *bs, const char *encryptfmt, goto out; } =20 + ret =3D 0; out: - QDECREF(encryptopts); qcrypto_block_free(crypto); - qapi_free_QCryptoBlockCreateOptions(cryptoopts); return ret; } =20 @@ -2768,8 +2784,7 @@ static uint64_t qcow2_opt_get_refcount_bits_del(QemuO= pts *opts, int version, } =20 static int coroutine_fn -qcow2_co_create(BlockdevCreateOptions *create_options, QemuOpts *opts, - const char *encryptfmt, Error **errp) +qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp) { BlockdevCreateOptionsQcow2 *qcow2_opts; QDict *options; @@ -2999,8 +3014,8 @@ qcow2_co_create(BlockdevCreateOptions *create_options= , QemuOpts *opts, } =20 /* Want encryption? There you go. */ - if (encryptfmt) { - ret =3D qcow2_set_up_encryption(blk_bs(blk), encryptfmt, opts, err= p); + if (qcow2_opts->has_encrypt) { + ret =3D qcow2_set_up_encryption(blk_bs(blk), qcow2_opts->encrypt, = errp); if (ret < 0) { goto out; } @@ -3058,6 +3073,7 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt int version; uint64_t refcount_bits; char *encryptfmt =3D NULL; + QCryptoBlockCreateOptions *cryptoopts =3D NULL; BlockDriverState *bs =3D NULL; Error *local_err =3D NULL; int ret; @@ -3074,6 +3090,7 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt ret =3D -EINVAL; goto finish; } + encryptfmt =3D qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT_FORMAT); if (encryptfmt) { if (qemu_opt_get(opts, BLOCK_OPT_ENCRYPT)) { @@ -3085,6 +3102,14 @@ static int coroutine_fn qcow2_co_create_opts(const c= har *filename, QemuOpts *opt } else if (qemu_opt_get_bool_del(opts, BLOCK_OPT_ENCRYPT, false)) { encryptfmt =3D g_strdup("aes"); } + if (encryptfmt) { + cryptoopts =3D qcow2_parse_encryption(encryptfmt, opts, errp); + if (cryptoopts =3D=3D NULL) { + ret =3D -EINVAL; + goto finish; + } + } + cluster_size =3D qcow2_opt_get_cluster_size_del(opts, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -3158,6 +3183,8 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt .backing_file =3D backing_file, .has_backing_fmt =3D (backing_fmt !=3D NULL), .backing_fmt =3D backing_drv, + .has_encrypt =3D (encryptfmt !=3D NULL), + .encrypt =3D cryptoopts, .has_cluster_size =3D true, .cluster_size =3D cluster_size, .has_preallocation =3D true, @@ -3168,7 +3195,7 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt .refcount_bits =3D refcount_bits, }, }; - ret =3D qcow2_co_create(&create_options, opts, encryptfmt, errp); + ret =3D qcow2_co_create(&create_options, errp); if (ret < 0) { goto finish; } @@ -3176,6 +3203,7 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt finish: bdrv_unref(bs); =20 + qapi_free_QCryptoBlockCreateOptions(cryptoopts); g_free(backing_file); g_free(backing_fmt); g_free(encryptfmt); --=20 2.13.6