From nobody Sat Oct 25 08:57:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520285107052884.4495894415708; Mon, 5 Mar 2018 13:25:07 -0800 (PST) Received: from localhost ([::1]:51612 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esxbW-0000Pf-8A for importer@patchew.org; Mon, 05 Mar 2018 16:25:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esxWR-0004MB-UG for qemu-devel@nongnu.org; Mon, 05 Mar 2018 16:19:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esxWR-0001ZX-3J for qemu-devel@nongnu.org; Mon, 05 Mar 2018 16:19:51 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:34821) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esxWQ-0001Z6-SZ; Mon, 05 Mar 2018 16:19:51 -0500 Received: by mail-wr0-x241.google.com with SMTP id l43so18816358wrc.2; Mon, 05 Mar 2018 13:19:50 -0800 (PST) Received: from x1.local (ABayonne-654-1-79-224.w86-222.abo.wanadoo.fr. [86.222.222.224]) by smtp.gmail.com with ESMTPSA id g96sm12904808wrd.73.2018.03.05.13.19.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 13:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IDISHE/WXhKazKS9RqpzgTEj/9/+RmtPBdEpXusdzis=; b=G6hlohkLdhIud1NH183EbVhsvrSaRQ1Q1JjA/asdjl8HV0jsFkOUavRQvXJmfTmpT4 VPpxLLFpSIGnrR9TRgQCl2IxhSLxqxL5e8x3phmt/+9+vkNMKMJtKtcN6nUqJ7CZfeef IiLfX0EPgfFIaxiXLRHgzGhPVWmxWtjei54zpqT2C0V87vUIARKTWeaMZX2GiTCmwSp3 fEfFNwWcTWxRooglMZ46R8vr8qsSjZTSL4t5utk+lhKzQf3Ir+cd/uhl0OiTYmt8P2Ht BS25TwKnMUQwu18Qxr6TULnrX3SQoVFNeU0e228JykaUFDzNGVvedsrklYGejwgFiObH BKXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IDISHE/WXhKazKS9RqpzgTEj/9/+RmtPBdEpXusdzis=; b=LhTLi7k7hjtIjemQUs9v1DWuLR9mui4eFNJg7DgoY5M30MpitPY+8nQ1euRh+CZQaa T7FG8dEkDrumN52V/YqO+qBWJXpuVaYy/UjwZIPmAb+37xGrgLDjPaslvuHTDtfgaw5m 0T85MzyslxK0dGFZSf/T/etNetbqlXHGVjJnrY+lHzzUk0ksBUzPVIvTkFYyHJPdNuzI FO9A++gtNAta/+Etwm8eFkakMzy0IuKp9m+UxTGHXp52vUdHUHaCZmDZ6BWmsIoW+xge 9RLQoldxxCdlgRApohj0mD5dQsfwWiZGhRJ+ClSQma94JwMmfH0S6HU6UzyXqHU4zxxe e/wQ== X-Gm-Message-State: APf1xPCiN2gQFGtX3u2BNWZTKZC/vUBo1WcRUCY7sg5R0m/qlisRTtnh d7ErcQ58NTPvijJtZBQxZUs= X-Google-Smtp-Source: AG47ELuJbMR02sB1BQrgvcdLtP57Lyy/3wVEXdeqXoTtBWX4fsZ45NZjwS4jXBb/n0LjM5vxX1nwdg== X-Received: by 10.223.133.214 with SMTP id 22mr14521545wru.130.1520284789906; Mon, 05 Mar 2018 13:19:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Paolo Bonzini , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , Aurelien Jarno , Mark Cave-Ayland , Alexey Kardashevskiy , Thomas Huth Date: Mon, 5 Mar 2018 18:19:14 -0300 Message-Id: <20180305211928.466-9-f4bug@amsat.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180305211928.466-1-f4bug@amsat.org> References: <20180305211928.466-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [RFC PATCH v2 08/22] hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, "open list:PReP" , Guan Xuetao , Yongbok Kim , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/isa/pc87312.h | 6 ++++-- hw/isa/pc87312.c | 11 ++++++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h index b65b219a8a..f3761d6fe1 100644 --- a/include/hw/isa/pc87312.h +++ b/include/hw/isa/pc87312.h @@ -25,14 +25,16 @@ #ifndef QEMU_PC87312_H #define QEMU_PC87312_H =20 -#include "hw/isa/isa.h" +#include "hw/isa/superio.h" =20 =20 #define TYPE_PC87312_SUPERIO "pc87312" #define PC87312(obj) OBJECT_CHECK(PC87312State, (obj), TYPE_PC87312_SUPERI= O) =20 typedef struct PC87312State { - ISADevice dev; + /*< private >*/ + ISASuperIODevice parent_dev; + /*< public >*/ =20 uint16_t iobase; uint8_t config; /* initial configuration */ diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index fda91fed21..6b8100ff56 100644 --- a/hw/isa/pc87312.c +++ b/hw/isa/pc87312.c @@ -270,6 +270,7 @@ static void pc87312_realize(DeviceState *dev, Error **e= rrp) ISABus *bus; Chardev *chr; DriveInfo *drive; + Error *local_err =3D NULL; char name[5]; int i; =20 @@ -279,6 +280,12 @@ static void pc87312_realize(DeviceState *dev, Error **= errp) isa_register_ioport(isa, &s->io, s->iobase); pc87312_hard_reset(s); =20 + ISA_SUPERIO_GET_CLASS(dev)->parent_realize(dev, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + if (is_parallel_enabled(s)) { /* FIXME use a qdev chardev prop instead of parallel_hds[] */ chr =3D parallel_hds[0]; @@ -381,7 +388,9 @@ static Property pc87312_properties[] =3D { static void pc87312_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + ISASuperIOClass *sc =3D ISA_SUPERIO_CLASS(klass); =20 + sc->parent_realize =3D dc->realize; dc->realize =3D pc87312_realize; dc->reset =3D pc87312_reset; dc->vmsd =3D &vmstate_pc87312; @@ -392,7 +401,7 @@ static void pc87312_class_init(ObjectClass *klass, void= *data) =20 static const TypeInfo pc87312_type_info =3D { .name =3D TYPE_PC87312_SUPERIO, - .parent =3D TYPE_ISA_DEVICE, + .parent =3D TYPE_ISA_SUPERIO, .instance_size =3D sizeof(PC87312State), .instance_init =3D pc87312_initfn, .class_init =3D pc87312_class_init, --=20 2.16.2