From nobody Sat Oct 25 08:57:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520285111536331.499450977243; Mon, 5 Mar 2018 13:25:11 -0800 (PST) Received: from localhost ([::1]:51613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esxba-0000TB-NE for importer@patchew.org; Mon, 05 Mar 2018 16:25:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esxWc-0004X5-C7 for qemu-devel@nongnu.org; Mon, 05 Mar 2018 16:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esxWb-0001hZ-Im for qemu-devel@nongnu.org; Mon, 05 Mar 2018 16:20:02 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:32817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esxWb-0001gs-Ce for qemu-devel@nongnu.org; Mon, 05 Mar 2018 16:20:01 -0500 Received: by mail-wm0-x242.google.com with SMTP id s206so15056368wme.0 for ; Mon, 05 Mar 2018 13:20:01 -0800 (PST) Received: from x1.local (ABayonne-654-1-79-224.w86-222.abo.wanadoo.fr. [86.222.222.224]) by smtp.gmail.com with ESMTPSA id g96sm12904808wrd.73.2018.03.05.13.19.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 13:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IV0pzBsGANS34ps4xxZJbR881CnlULNAoIhbunxpJU4=; b=aJWNhwctfI6xHQimuuWwx2QPEVJWFMK/6tqik9iF0SP/1sCUYeBeoKGePXWMex8qLv cbNAx3JE8E/jgbNtqtDvGkGHD1mSvyCb+WheiaHzKhyAj0cIxdC/cU+l1kEQHp2pAmvq K3IHObNNc+dh0d5DROUb8KEDawQ5efKH8aojU85a4Urq5Rt10RZjIIqsk7qWKfejyFmu wDdnsoU06dW6X7m7wzoBlMU5FwUuAVuwshHsMMzXtM2kJKtKEgswXTkSbk4y3NNDX5P8 m7rzFGRpDMLm5JfCAZwoalXvJSQd5TXQ9Van6IdAF6x/UkXZSKGs1iXzM/gqCHrEulaw Jiig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IV0pzBsGANS34ps4xxZJbR881CnlULNAoIhbunxpJU4=; b=eP+3gnxhMlfs3fXVY7vDE367lmBon1xp71+XHQxaMrkxlDtGZr+W9w0Vp0YpQrIooo D+xlcVdSqOVqfsPBgtCUB5d6utupwJq/PqMH7viF1YS1xOv918zcUzHAYU6r/CnLB87P JtNWog5sOvel4R5x7GqgN4ruVOLIWJMq/7CZrt3inOJV0Mv3nH24IzAlsdMK0HWFzhVd RBbupeFsAE2aBhI8IbBLk/kUEyJjEHHwLRheAnjBFa1KN0yZOD6N/qQZtLS0OLfHo2Cv bXvjQ01TUQfsuhZ+rSoLcsfwGkyadGPEICpkO2Mxe4FxbFWU2yiNLYRe8T+T4yrsNxR2 gycA== X-Gm-Message-State: AElRT7G9e+GQlmcaBwZemSjMIWIhRQeC6xlpoR1wsByYCHu/iY1v1Wk9 3tQL4t1YGnDTe0r3oTlxYKI= X-Google-Smtp-Source: AG47ELt/0fzswqgZ/w/ChWzO+nL7C2EQuKXbZDEQ2nV/jeSviHyTucqqC26DX2rGRA8ptORFoq7iIg== X-Received: by 10.28.69.29 with SMTP id s29mr8150643wma.152.1520284800496; Mon, 05 Mar 2018 13:20:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Paolo Bonzini , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , Aurelien Jarno , Mark Cave-Ayland , Alexey Kardashevskiy , Thomas Huth Date: Mon, 5 Mar 2018 18:19:20 -0300 Message-Id: <20180305211928.466-15-f4bug@amsat.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180305211928.466-1-f4bug@amsat.org> References: <20180305211928.466-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [RFC PATCH v2 14/22] hw/mips/malta: Code movement X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Guan Xuetao , Yongbok Kim , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Move the SouthBridge peripherals first, and keep the Super I/O peripherals last. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/mips_malta.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index cd7bd0eef6..9e0724ca5a 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -1062,10 +1062,6 @@ void mips_malta_init(MachineState *machine) memory_region_add_subregion(system_memory, 512 << 20, ram_low_post= io); } =20 - /* generate SPD EEPROM data */ - generate_eeprom_spd(&smbus_eeprom_buf[0 * 256], ram_size); - generate_eeprom_serial(&smbus_eeprom_buf[6 * 256]); - #ifdef TARGET_WORDS_BIGENDIAN be =3D 1; #else @@ -1208,15 +1204,19 @@ void mips_malta_init(MachineState *machine) pci_create_simple(pci_bus, piix4_devfn + 2, "piix4-usb-uhci"); smbus =3D piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100, isa_get_irq(NULL, 9), NULL, 0, NULL); - smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size); - g_free(smbus_eeprom_buf); pit =3D i8254_pit_init(isa_bus, 0x40, 0, NULL); i8257_dma_init(isa_bus, 0); + mc146818_rtc_init(isa_bus, 2000, NULL); + + /* generate SPD EEPROM data */ + generate_eeprom_spd(&smbus_eeprom_buf[0 * 256], ram_size); + generate_eeprom_serial(&smbus_eeprom_buf[6 * 256]); + smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size); + g_free(smbus_eeprom_buf); =20 /* Super I/O */ isa_create_simple(isa_bus, TYPE_I8042); =20 - mc146818_rtc_init(isa_bus, 2000, NULL); serial_hds_isa_init(isa_bus, 0, 2); parallel_hds_isa_init(isa_bus, 1); =20 --=20 2.16.2