From nobody Wed Feb 11 06:00:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520239450841111.02671113882445; Mon, 5 Mar 2018 00:44:10 -0800 (PST) Received: from localhost ([::1]:47849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eslj7-0001m1-Un for importer@patchew.org; Mon, 05 Mar 2018 03:44:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eslcH-0004Of-Pi for qemu-devel@nongnu.org; Mon, 05 Mar 2018 03:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eslcG-0004VC-VN for qemu-devel@nongnu.org; Mon, 05 Mar 2018 03:37:05 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:39250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eslcG-0004Tl-Ok; Mon, 05 Mar 2018 03:37:04 -0500 Received: by mail-wm0-x244.google.com with SMTP id i3so13698189wmi.4; Mon, 05 Mar 2018 00:37:04 -0800 (PST) Received: from donizetti.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id y23sm13206739wra.9.2018.03.05.00.37.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Mar 2018 00:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=b9au6Bz5trrEEsaT+D8yfYVFu77Dm718I7mlEyVY4vw=; b=o7LGFajFx61mQ9M2NMcRZOqk0eZxuZjIQNRHTuODG3WbnJR5GWLzZ+KbABTDbYdtg/ hk2HvluhLsg8/Jloc6tBg13W6KAZUWynEr7/0zAxCU9BGPqBZ43b7WiSaPrPdKOoSjcv CLvbhyxOvNXYCSbHeucwU66DMRjJnfgF6eJnD5FGK8RR64o3dV8tfo0R9qWrHE3c+Yqb c343BRmBtwMoaCLMrtBKCg9V/tbkeeBSIqIR9r+PhBlHnODLZmPvsEe2/js816dMUBL4 ytzi5+up+1J2yMh9efdcCsorOCFkKD/alGzEoWOu6V3zQwfKDm0yxjMv/h4ZTFnFIue0 HRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=b9au6Bz5trrEEsaT+D8yfYVFu77Dm718I7mlEyVY4vw=; b=irepREHafWyVzCwTIQJi7u4azESZfgMokLrVq7MFuyEzxAvua2v4dtVCX/HS+tc9n/ JX68ANDDkKQJlrdFef6lL6SGEPz6SiADD3n5Yln13Teb+6IRomNhE4Ho6aJcdjfyaUGQ /Pcxh+V9S06jhNkxI1dWYe1mVO7QU692TP67fZT4S7vsHw2maKiHGw9bq+2uhDDdiMMz Lu9/WOTXwW1aH/vxaNAdyzOAmE2L3oWhxLCT5s7g6oRdG2IdrOabpk/P5zS/uC0N6f3F pF9Js/VDw/J33eFmK9qv8SvhcnjsOu0ee+ThEq3nFhErOWEWMZHxK+KSVabmv3ZyxU1I Tbng== X-Gm-Message-State: AElRT7GlFNJUuc+n9ENkMccUKg0pDMRs2eZdarHx0/9vN1Ra+B2rFmi9 K4793916JA7ACILjss/osFlHYutL X-Google-Smtp-Source: AG47ELvQSvuGp1kgvojmp0DzGVreUm6AvG8TVeNaM747Rv9bejfqbDcGYA5XDy8FpQwuJvislSZqHw== X-Received: by 10.28.124.5 with SMTP id x5mr7032787wmc.11.1520239023359; Mon, 05 Mar 2018 00:37:03 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 5 Mar 2018 09:36:54 +0100 Message-Id: <20180305083655.6186-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180305083655.6186-1-pbonzini@redhat.com> References: <20180305083655.6186-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PATCH 6/7] address_space_map: address_space_to_flatview needs RCU lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , qemu-stable@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" address_space_map is calling address_space_to_flatview but it can be called outside the RCU lock. The function itself is calling rcu_read_lock/rcu_read_unlock, just in the wrong place, so the fix is easy. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Alexey Kardashevskiy --- exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 177583c2ee..070eaff3e7 100644 --- a/exec.c +++ b/exec.c @@ -3464,7 +3464,7 @@ void *address_space_map(AddressSpace *as, hwaddr l, xlat; MemoryRegion *mr; void *ptr; - FlatView *fv =3D address_space_to_flatview(as); + FlatView *fv; =20 if (len =3D=3D 0) { return NULL; @@ -3472,6 +3472,7 @@ void *address_space_map(AddressSpace *as, =20 l =3D len; rcu_read_lock(); + fv =3D address_space_to_flatview(as); mr =3D flatview_translate(fv, addr, &xlat, &l, is_write); =20 if (!memory_access_is_direct(mr, is_write)) { --=20 2.14.3