From nobody Fri Oct 24 21:57:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520084476691186.74151491787882; Sat, 3 Mar 2018 05:41:16 -0800 (PST) Received: from localhost ([::1]:40272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1es7PX-00024j-Jl for importer@patchew.org; Sat, 03 Mar 2018 08:41:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1es6q1-0000ab-Jj for qemu-devel@nongnu.org; Sat, 03 Mar 2018 08:04:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1es6px-0004jO-Ig for qemu-devel@nongnu.org; Sat, 03 Mar 2018 08:04:33 -0500 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:45219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1es6px-0004hw-A0; Sat, 03 Mar 2018 08:04:29 -0500 Received: by mail-pl0-x244.google.com with SMTP id v9-v6so7236836plp.12; Sat, 03 Mar 2018 05:04:28 -0800 (PST) Received: from localhost.localdomain ([185.216.48.174]) by smtp.gmail.com with ESMTPSA id x4sm14857574pgv.72.2018.03.03.05.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 05:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ncl6cl82cPnNlcO+nu/SVvqyHoYotQbSC5DvJhATnMQ=; b=e5MXnw7rHrlTXDFK4zCLUIWNV0peoil7st5+zxNH0d5bOy6OQDGi5/dv3o5MubGX6+ H6RI4rOmWN5SDjNeFoNFX7mN1xp5exYzMPb4W435VKwkaa5Xvv4tQZaQXalaGIEyYiMW PpKQDRR3xslnJoQf+VrFlF2n5QBC2QBe7CYyM9Hcko1TTWSflNt4uDxFnT+IPzSfCEUE cr/PHcaM99AWsC5VunPEyuYFUrTE40eZkzSGcpzGsXY1MFhMPkucJTa1nD70ErVRtgo3 BBd2p4/DxzPoojqncpOv3cP6582h9f97IdMuXZPQb395rV1nubGtAY81BR1RszLt+kpo XPCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ncl6cl82cPnNlcO+nu/SVvqyHoYotQbSC5DvJhATnMQ=; b=sMzadQEuvLarqd0jRdxV9/PKafNjQE52z5ErY6bWkp4b9YUa0j2YdYUWHJuKt5EhWX EgtIdBszXAwjRTBlnYmHq4RR5WaYsuleMP/e7pcbDS8grTSxlz0nR07fDV2H+XmGLdOb RLA6f0AUuPRvJe8lk3ZWpjomGVliiaTX0DfezFLxpn8ZmdSMmun8JIslJBvtjG7+13+0 GqFHLgTXwJ+LyujGRlnKmti4gnzR/YHN5JIgbVNh2b2wKLaMbWrw+dUA+9mMN5tGp9Tx hwWuiQSvSHs5Orgrxk0JjcnlKdWWkJcps1HAGtJs5SqIhQlSc/Trcq2FqwLY/rEF5NzQ arIQ== X-Gm-Message-State: APf1xPDeMNE68gL2/aqw7NmTMmPlATvToV8c3GFUr8kFpWf5YEG+rJsY BWULIdpF1Xe7LUJT2CRvWmc+93H+ X-Google-Smtp-Source: AG47ELsm8MUbGjMTfL/4Wso0zWeKpAJctjWsnghQjUrSSVoh+sxuha2dRVHXNt92IeLsz71LBU08ZQ== X-Received: by 2002:a17:902:33c2:: with SMTP id b60-v6mr8326129plc.222.1520082267498; Sat, 03 Mar 2018 05:04:27 -0800 (PST) From: Nia Alarie To: qemu-devel@nongnu.org Date: Sat, 3 Mar 2018 13:02:26 +0000 Message-Id: <20180303130226.26906-1-nia.alarie@gmail.com> X-Mailer: git-send-email 2.16.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 X-Mailman-Approved-At: Sat, 03 Mar 2018 08:38:28 -0500 Subject: [Qemu-devel] [PATCH] PPC: e500: Add check for NULL return value from qemu_find_file. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jim@groklearning.com, stefanha@gmail.com, agraf@suse.de, qemu-ppc@nongnu.org, joel@jms.id.au, nia.alarie@gmail.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This prints a message and exits if the e500 BIOS firmware can't be found, to avoid dereferencing a null pointer. Signed-off-by: Nia Alarie --- hw/ppc/e500.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index a40d3ec3e3..6ce03d6ff4 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -1005,6 +1005,10 @@ void ppce500_init(MachineState *machine, PPCE500Para= ms *params) } } filename =3D qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); + if (!filename) { + error_report("Could not find firmware '%s'", bios_name); + exit(1); + } =20 bios_size =3D load_elf(filename, NULL, NULL, &bios_entry, &loadaddr, N= ULL, 1, PPC_ELF_MACHINE, 0, 0); --=20 2.16.2