From nobody Fri Oct 24 22:18:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519853088859156.96156648141027; Wed, 28 Feb 2018 13:24:48 -0800 (PST) Received: from localhost ([::1]:47025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er9DT-0004U2-7f for importer@patchew.org; Wed, 28 Feb 2018 16:24:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er90Q-0001Qh-0o for qemu-devel@nongnu.org; Wed, 28 Feb 2018 16:11:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er90M-0005vV-BZ for qemu-devel@nongnu.org; Wed, 28 Feb 2018 16:11:17 -0500 Received: from mail-sn1nam02on0081.outbound.protection.outlook.com ([104.47.36.81]:17351 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1er90M-0005tr-14 for qemu-devel@nongnu.org; Wed, 28 Feb 2018 16:11:14 -0500 Received: from wsp141597wss.amd.com (165.204.78.1) by DM2PR12MB0155.namprd12.prod.outlook.com (2a01:111:e400:50ce::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Wed, 28 Feb 2018 21:11:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2DFtgqwVUgcxVVo6D8Y4SyRXve2OmdSb12VfhrX6DHc=; b=EcqJf8ax9Gfr1/CQYCdlW4itZEspVMRqKTaADR4pbuuHoIHqniFR44FAjBhPzI8QNRlIE/nhJlP8ee3onFCEY4BFnlLrRpgi06V2hrQV9r9g/rm3RPe0j6LPYau+04Qw32rUyS1hjp9Yl7wgWelT2uV9JtPxX2+Ey9PZ/0RChII= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; From: Brijesh Singh To: qemu-devel@nongnu.org Date: Wed, 28 Feb 2018 15:10:20 -0600 Message-Id: <20180228211028.83970-21-brijesh.singh@amd.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180228211028.83970-1-brijesh.singh@amd.com> References: <20180228211028.83970-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR10CA0008.namprd10.prod.outlook.com (2603:10b6:4:2::18) To DM2PR12MB0155.namprd12.prod.outlook.com (2a01:111:e400:50ce::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d6b3798b-c898-4921-0c3f-08d57eefcbf9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM2PR12MB0155; X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 3:FGMjAjBal7X5ftLUO7H7cZnZbVx7dP+LYPQu0x5JhztK/cTBs1AnFnCjnkiX0d7D8uZcf6etw7+vLeGyWJAi0AAmZ+7RA1JWzLSnl5uQFT/UDPOqP+1qosO3HoPPYzSl1Ra74HwCb7QEm0g7Q7qNymMpRHnw5K1YAGHdVfZPkIYy30BmfMBZ8qY0ZGmcqPOg5G9KdwbkKG4982zLprJaVxmIGdHbfH/FEDxr9kr5Jfg+o0dSUE2Ev1m4RF9K3EmA; 25:U5B2RC3KEZzzz7LSTQVxRSuBBu0xW47cHATkaXhIz9+DHlNXa9wnn4JhZHHDX+N4cePCpk7Hh/BWxwGRHOmWtm4PteZSLrs3qIukEB8j+Mbkn1TlxJDKRAGLBxpYmaUnPFafZV3Cyv3L3fQviMdPlXBvt4kVUhEMzhgP8+Rd84x1cVQcBhL0q428ajKdDHqGnctla6PwDWwXNTzO3qHgGlHbiWFKJAyqy6m19SyBmHyLHOEVWZ81q5HPQTkBucoxSODR37TVU+Fuar5riKBnMUPjFI3T1o006J6Jor5d8JaxJ0UtW2bLs5ueohL+XP4ffG1QpT9atponHFUlIqfUmw==; 31:VNp7aFRpHJ41iFL0UXxKYr5fIFYPknELJGTYy54U/L+Vqkc7ZyQXHiXE76nyWSkmMh4xSavVJH46LuuhL2Bn0uaS9oq6zSv4nzGfO8J2Q2QvxelEuS3cGHKJeVLx+nEQAmvvZYnz94gogQTu4+zx5SiLx6jmeb96ZBNDtJeE2lZdAeB2htSi0De+7hqlGDDUnKu0hX23rnqsaUCrqvjCQgicHVtCMjCht5ZOB37mWi8= X-MS-TrafficTypeDiagnostic: DM2PR12MB0155: X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 20:BI0HHtjtvRxW0ufAkHZN5qB/rBX0JNmgDOL5qYIXU/sQAuudgMj1IYq3n8w+nhE8WH10pxYbgYKqGcLw9NAuJVmEULmX1Prnch5scx/83iQ9LyWTwF9kBxJoS71BWZ2fXm1qTJv+UW0hsyXJfcMrdYRgits4Af1eepSXSBzlRTHvY4yLTzjQrsQjH8fYMmbiKCZtvt8ncA2J6GBShwGajc5SYRab34WmAvQatBgUwAnvss5fLGKYCP1vtwy+/KuiHUSZOMQInnP+VOwzsvzAvF3mdxePcV1HOCF9BE+ASAUAAuDN0MtkHH4SfcQBV2c149YhOBnX96R4iMs6hVFmufWA+ZwMIp8aCM252dEtxQhtXVdajuO8yexHaqSJ9k/QUFsEvgJsjhHlbNZJlX3jlRGP1KeWdb9/vo06wLQb3/8BZbP+9KASNb65iYilbNGuvHCGKxqaBLVmTpNZDeJsPQuIlSS7YS59hrUTGw+qp7W/Zvd+IpYM/NWm/tlKnSc8; 4:NmEhuj2Qm8+o/LYc9QN9qqWkJM9+MuC8i7nIncL3g8F7rY5Jhcia78lfk5cvWN5MC/C5JSgB7hzFJfdoqh5BSW8r+6Cb9PYAO1k7e1uf+LIB+pbTx/O165+aDDyNjU/jTqzwuxwjXjNhpZnaTNKIqQ//Y6TuAmVhjQB2KKT6Y6vWMNRMlP18vFuSzZX8Box1228eglKlMJACv6nr6D4oxVJHz5NcHtCSWYfWv5siAGBt3DIjm84aSRFTPpMw1n7OIg5CT5EgozPOlpxyN2AqDNt9K60dBQiwjuART1WaIcrC6XrgZOGV7D1rCv7tfmm7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501219)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM2PR12MB0155; BCL:0; PCL:0; RULEID:; SRVR:DM2PR12MB0155; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39860400002)(39380400002)(396003)(346002)(366004)(376002)(189003)(199004)(6486002)(6116002)(1076002)(2351001)(36756003)(16526019)(16586007)(54906003)(53416004)(26005)(53936002)(66066001)(186003)(47776003)(59450400001)(2361001)(478600001)(8666007)(316002)(81166006)(50226002)(8676002)(8936002)(386003)(106356001)(97736004)(5660300001)(2950100002)(6666003)(305945005)(4326008)(76176011)(7736002)(39060400002)(8656006)(105586002)(68736007)(50466002)(7696005)(51416003)(25786009)(48376002)(52116002)(3846002)(2906002)(86362001)(81156014)(7416002)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR12MB0155; H:wsp141597wss.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR12MB0155; 23:tQTzEebpmZiF2s3fbgV2Eq90p03U8L0mRO3a/OyHb?= =?us-ascii?Q?KQrFywTXzI2klBKLyL/zMIZQDeN1SgAI7qqR6HbYKV/AkOPm1plMz4mRcAwE?= =?us-ascii?Q?Gol7HfMNFt163guBvuPW/hfjURs1faKWNWS9AhLNXFICvZaoXJpKC2tRS273?= =?us-ascii?Q?bmgesuaxWGkrHHoVSFs06CDvTllaM5oygCS/tlrVe0eIM4+JSOtPX9tRYv78?= =?us-ascii?Q?UBaKEoXfdB7STN/TljPz9z+IedYax7CvnAEkI4kYnjNQt41BrKj2wytYukJp?= =?us-ascii?Q?viIgylEqVr5yCJznzddQh4zYiyh4kmKJzZbyJQkYZ8Ie0QrhrbiuwkyL5vFa?= =?us-ascii?Q?eVtKnvVwnHBEbjeq/4BfDY3YfIg/fY+/B8bKDd9IVYvLqxxan0tBLlQ+1c/w?= =?us-ascii?Q?U4LXykA+jQuUEauVXd/z0ZtnHBEme4/qcBijheTEqYjxtrxBkYIYtO5g4luM?= =?us-ascii?Q?7YCJnRYx6CjQjUMa132h4Of/H7Bwc4X5V9HgHFYn8JobqNa+VOWjJChjcNvq?= =?us-ascii?Q?sb0ViZd7djP6eIeAgS93zYYf7E2hi0El80zOxrv43qNh4MIR5VskloV+itxU?= =?us-ascii?Q?0UsZjH4jRi5QZyR17w3u5iU3eIuJrMZTwkZ4BjCinyvbB73iFo3qXmKyyovS?= =?us-ascii?Q?vsM0wLp5QRs6v6Edl7r00ayJW2Eu8XTf9IayA0vzi6L/iolIqWYGaDCP242e?= =?us-ascii?Q?NILsTzHRcJw9SZYSRjDmLr24j2QJw6kOWIZ35rEcJqPcCFkbHQ0M1FZdnl3h?= =?us-ascii?Q?W+0hUDpzpzn2NQTNbUjmW/cpxiBVKo+Ax7HSH0ns/tB4XMhU6rVMhVN4XKEV?= =?us-ascii?Q?BRc5Ui+EnuO3XOLVekPZ5OJWAstV7NEFNEv56Z9omlo9UItyH1gf9vN/C1Hz?= =?us-ascii?Q?hx36Km+ZX2oqU1Ts6+S+uS83Oa5kdsxlIonXJEY41M4cSSBJ1Mteev/jpxCA?= =?us-ascii?Q?esJ1qX217iOoH60YNUrmmatNXe+ZrRnfXIFwQgKg6s9mWWCJalbOVQ9rOd68?= =?us-ascii?Q?LQxILLdybEMXQe1WkXJAyO7F64edUDUge/ZS4TS+peAW1IojZsb9pWKfgXjZ?= =?us-ascii?Q?m+8Uti9MvILb4Po7qLm6e/shFsd2/T9dZKlTzwhkKRVRs+X7qN2OH794Uk7o?= =?us-ascii?Q?NVMmNbEJ6sSHW5vfbCF1CL7PfKNpfvY9puJ95E48W6gEh9P44ago2dxlgba0?= =?us-ascii?Q?Zj/g83KkhU6hgd5ScFvYiTeGMYRvSIpUCMQn1VLniW83iAheAFKDoOpu1f6r?= =?us-ascii?Q?oe8ucMcsUZAk56G2++WHFPcEKMz2uHBlXYVv7fjANuCNStF4FDh5O9Nn7hxZ?= =?us-ascii?Q?TqddW/gHTeEZ+9yt/MzjWo=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 6:jpqbEBkck95zNDcjRFukcu54L7kC6ay9SLSJ50WHBuyQDMa4msMy2P140w73vaa/0HMORlseqVGy+p161hUD+wHrHEFz7KUq5JbAUbRvglNKr0vevM8/X7cqqG8ZK/zxAktkmjc52AgaZPfTpfCxQLNNDjD0WRWHqjwYxFuJvok1fs4xc4oXgvimGicIwhistcCs5F1v2nmQzF0DV7l33GihthLUF3vc80ubMVqxna49TcIchZ/l/Bp3gDPpnFCX3hJpD/YFznozwZa/6X9EFpfF4FJGLN4btOfzPtbFIm1cA6EGpCahwe1QvrjB0/oVPJDeL0NFtMvmIcqsC0YMt6bZoQVi7OQT74VuzKOF2uI=; 5:1MlpFeep1QKYL9veydfnc57+Tc+b4kAJhB3WJqw8yLEU3mb327hcfNnMjsl1CotYlZJtOiDm1h72erLNlX+vaIX1u6dVVbhiZK2ADZB2G9rcUYwpnbbdbgPeTmd4jrnG2LyFr8tns3bdlGJk9cdLMATZbgesskyxUgcRj7WpO5A=; 24:WiykqPKeTBkD0MUwwsy7S0cLtY12WlWD0s0funN2IiF32j+jb1n+awAg2Rl6isHzsdAYOHa9bpMQB2Yof7uq8aSVIudu4jp2rKX0lK9PBsw=; 7:yrsalKBnbHbuQmofytf94bPZBhH5NtX3ZMEfyW04upVC9LxPa3UwTP5whbuOU2zY87f0kIqJ4lSuLQS6OphainMgFm7Ejy/h5P4tSP4OVnBXShuuqBNqe3v+DTmcBvX6qKvWutS4Yx3LqzZuenOnE869dW3XM3H7dGuet8EJUtA3hDjs1Qw7x7gap78bn61NK5TIU4n/k887fjHbWsK9QNNtdSCAmkipwfMClhOzDvWDOUV96rL5JvebA4AN0pl2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 20:yCUdXhunuGZdQugtIN6qmU1gqzTTgwahO0TapeuHtLxAOYMzc/LQHjBqIalNkOBjh0/263W++rzhWSmYc/ZGOZWBqVTFIYoB/0T7zMwResBkqphSvUGPQV7nRRLzLYIWm40oyFfCatzZHlBKNTYLkxEhLyVJj+6zbKRFhqSwRsf8v2zGcUmhX3RfW0gporxcbNHQLiv9G8d3TyPEdZo5ATgHvDUa4BN4hRZ3+D+W63OI2CfptkYWJFV+ckKiLfHb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2018 21:11:11.9204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6b3798b-c898-4921-0c3f-08d57eefcbf9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0155 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.81 Subject: [Qemu-devel] [PATCH v10 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Brijesh Singh , kvm@vger.kernel.org, "Michael S. Tsirkin" , Stefan Hajnoczi , Alexander Graf , "Edgar E. Iglesias" , Markus Armbruster , Bruce Rogers , Christian Borntraeger , Marcel Apfelbaum , Borislav Petkov , Thomas Lendacky , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Alistair Francis , Cornelia Huck , Richard Henderson , Peter Crosthwaite , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When memory encryption is enabled, the guest RAM and boot flash ROM will contain the encrypted data. By setting the debug ops allow us to invoke encryption APIs when accessing the memory for the debug purposes. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Signed-off-by: Brijesh Singh --- hw/i386/pc.c | 9 +++++++++ hw/i386/pc_sysfw.c | 6 ++++++ 2 files changed, 15 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 55e69d66fe6f..53ddecef369c 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1360,6 +1360,15 @@ void pc_memory_init(PCMachineState *pcms, e820_add_entry(0x100000000ULL, pcms->above_4g_mem_size, E820_RAM); } =20 + /* + * When memory encryption is enabled, the guest RAM will be encrypted = with + * a guest unique key. Set the debug ops so that any debug access to t= he + * guest RAM will go through the memory encryption APIs. + */ + if (kvm_memcrypt_enabled()) { + kvm_memcrypt_set_debug_ops(ram); + } + if (!pcmc->has_reserved_memory && (machine->ram_slots || (machine->maxram_size > machine->ram_size))) { diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c index 73ac783f2055..845240f97293 100644 --- a/hw/i386/pc_sysfw.c +++ b/hw/i386/pc_sysfw.c @@ -181,6 +181,12 @@ static void pc_system_flash_init(MemoryRegion *rom_mem= ory) error_report("failed to encrypt pflash rom"); exit(1); } + + /* + * The pflash ROM is encrypted, set the debug ops so that = any + * debug accesses will use memory encryption APIs. + */ + kvm_memcrypt_set_debug_ops(flash_mem); } } } --=20 2.14.3