From nobody Wed Oct 22 13:01:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519795136629285.0506525304188; Tue, 27 Feb 2018 21:18:56 -0800 (PST) Received: from localhost ([::1]:42292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1equ8l-0000Sy-Fm for importer@patchew.org; Wed, 28 Feb 2018 00:18:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqtxb-0008G2-4H for qemu-devel@nongnu.org; Wed, 28 Feb 2018 00:07:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqtxa-0000nl-9X for qemu-devel@nongnu.org; Wed, 28 Feb 2018 00:07:23 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47018 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqtxa-0000nf-5U for qemu-devel@nongnu.org; Wed, 28 Feb 2018 00:07:22 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D399887ABA for ; Wed, 28 Feb 2018 05:07:21 +0000 (UTC) Received: from xz-mi.redhat.com (ovpn-12-95.pek2.redhat.com [10.72.12.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 915702024CA6; Wed, 28 Feb 2018 05:07:18 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Wed, 28 Feb 2018 13:06:29 +0800 Message-Id: <20180228050633.7410-11-peterx@redhat.com> In-Reply-To: <20180228050633.7410-1-peterx@redhat.com> References: <20180228050633.7410-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 28 Feb 2018 05:07:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 28 Feb 2018 05:07:21 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , Markus Armbruster , peterx@redhat.com, "Dr . David Alan Gilbert" , Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It will be used in multiple threads in follow-up patches. Let it start to have refcounts. Signed-off-by: Peter Xu --- include/io/task.h | 3 +++ io/task.c | 23 ++++++++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/include/io/task.h b/include/io/task.h index 9dbe3758d7..c6acd6489c 100644 --- a/include/io/task.h +++ b/include/io/task.h @@ -322,4 +322,7 @@ gpointer qio_task_get_result_pointer(QIOTask *task); */ Object *qio_task_get_source(QIOTask *task); =20 +void qio_task_ref(QIOTask *task); +void qio_task_unref(QIOTask *task); + #endif /* QIO_TASK_H */ diff --git a/io/task.c b/io/task.c index 204c0be286..00d3a5096a 100644 --- a/io/task.c +++ b/io/task.c @@ -32,6 +32,7 @@ struct QIOTask { Error *err; gpointer result; GDestroyNotify destroyResult; + uint32_t refcount; =20 /* Threaded QIO task specific fields */ GSource *idle_source; /* The idle task to run complete routine */ @@ -57,6 +58,8 @@ QIOTask *qio_task_new(Object *source, =20 trace_qio_task_new(task, source, func, opaque); =20 + qio_task_ref(task); + return task; } =20 @@ -165,7 +168,7 @@ void qio_task_complete(QIOTask *task) { task->func(task, task->opaque); trace_qio_task_complete(task); - qio_task_free(task); + qio_task_unref(task); } =20 =20 @@ -208,3 +211,21 @@ Object *qio_task_get_source(QIOTask *task) { return task->source; } + +void qio_task_ref(QIOTask *task) +{ + if (!task) { + return; + } + atomic_inc(&task->refcount); +} + +void qio_task_unref(QIOTask *task) +{ + if (!task) { + return; + } + if (atomic_fetch_dec(&task->refcount) =3D=3D 1) { + qio_task_free(task); + } +} --=20 2.14.3