From nobody Wed Oct 22 12:51:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519411738761972.038604945444; Fri, 23 Feb 2018 10:48:58 -0800 (PST) Received: from localhost ([::1]:46571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epIOn-0007fx-FK for importer@patchew.org; Fri, 23 Feb 2018 13:48:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epINI-0006yj-KI for qemu-devel@nongnu.org; Fri, 23 Feb 2018 13:47:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epINF-0002zD-JN for qemu-devel@nongnu.org; Fri, 23 Feb 2018 13:47:16 -0500 Received: from chuckie.co.uk ([82.165.15.123]:49296 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1epINF-0002xl-CD; Fri, 23 Feb 2018 13:47:13 -0500 Received: from host109-153-193-100.range109-153.btcentralplus.com ([109.153.193.100] helo=kentang.home) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1epINO-0004j9-8m; Fri, 23 Feb 2018 18:47:23 +0000 From: Mark Cave-Ayland To: jsnow@redhat.com, anton.nefedov@virtuozzo.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Fri, 23 Feb 2018 18:47:00 +0000 Message-Id: <20180223184700.28854-1-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.11.0 X-SA-Exim-Connect-IP: 109.153.193.100 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 82.165.15.123 Subject: [Qemu-devel] [PATCH] macio: fix NULL pointer dereference when issuing IDE trim X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit ef0e64a983 "ide: pass IDEState to trim AIO callback" changed the IDE trim callback from using a BlockBackend to an IDEState but forgot to up= date the dma_blk_io() call in hw/ide/macio.c accordingly. Without this fix qemu-system-ppc segfaults when issuing an IDE trim command= on any of the PPC Mac machines (easily triggered by running the Debian install= er). Reported-by: Howard Spoelstra Signed-off-by: Mark Cave-Ayland Reviewed-by: Anton Nefedov --- hw/ide/macio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index 2e043ef1ea..d3a85cba3b 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -187,7 +187,7 @@ static void pmac_ide_transfer_cb(void *opaque, int ret) break; case IDE_DMA_TRIM: s->bus->dma->aiocb =3D dma_blk_io(blk_get_aio_context(s->blk), &s-= >sg, - offset, 0x1, ide_issue_trim, s->bl= k, + offset, 0x1, ide_issue_trim, s, pmac_ide_transfer_cb, io, DMA_DIRECTION_TO_DEVICE); break; --=20 2.11.0