From nobody Fri Oct 24 22:12:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519212371836759.2428928827302; Wed, 21 Feb 2018 03:26:11 -0800 (PST) Received: from localhost ([::1]:60166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoSXK-0003sJ-VK for importer@patchew.org; Wed, 21 Feb 2018 06:26:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoSK5-000160-Mt for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:12:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoSK3-0002LZ-Oa for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:12:29 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:40457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoSK3-0002L7-Fs for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:12:27 -0500 Received: by mail-wr0-x242.google.com with SMTP id o76so3326904wrb.7 for ; Wed, 21 Feb 2018 03:12:27 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id n24sm30580073wmi.21.2018.02.21.03.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 03:12:24 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id E5CE43E0CEF; Wed, 21 Feb 2018 11:05:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yn69zVGmuNidSJ9HxRcTZD6IcAUFa/6Ul7HJQ+7g54s=; b=hBWxKtsssuHQGHM57DH3DkrROPfSJAIHmFChZ6CH+jxt8DPlRJ6oAdwKB9D8YNNgyi IPzZ5iHw3hX7jl+Iwj3rXGfitcC2uBfNXmrltL/BbMAsXMT/dTsLXiUG/LEDQSYCi205 MmyG5Ap6q+Fhd9GEeDYRbM6NuLbabdxMWaRfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yn69zVGmuNidSJ9HxRcTZD6IcAUFa/6Ul7HJQ+7g54s=; b=NO/ey8aD1O4heYK+CewTCyTxgUTvWKLm6hKtBYU1z5/vRrZ69zLlqUQztYEkEnRznu 6vBlChuw4UvU9D+hXkZ+Z23apWRkHHPSNs0eAsvYKG90ZAkGZ4HoAGmyd0Lu7M6k38px P22ZnH3lw66IrtVzs/aPWwL034aIz97xoc+1HfSj5QT1iLYdLr4IIssdWR7hkEXqXmZW wl7qJm0wTbCQUyYCl2/jHzDJfwneGYig9x0n/4UZ4HV/unpy2HctkAlxtkMN2RT6Rdy2 1ojA0qtAwD4M5ylxmbrgVVmJyEk22Zc2I6GgP/1cOVjSgXekGkcrzRhEDbTTV2F66WGm Hm+w== X-Gm-Message-State: APf1xPAyx6Nym/BLP5QlQIuFa+9SRNnVLtpwtDrFReSWxBM+NtNPLc/j dTtFX7NAqBSdY6rwdYNgh5/mcg== X-Google-Smtp-Source: AH8x226jgQxHJwmHF750XFrNkF6CPQedSPpK/w8hZmQjFCpptgggfgJUTGqg/n+yHpU/DyXkEYRt8Q== X-Received: by 10.223.166.135 with SMTP id t7mr2659642wrc.260.1519211546353; Wed, 21 Feb 2018 03:12:26 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Wed, 21 Feb 2018 11:05:22 +0000 Message-Id: <20180221110523.859-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180221110523.859-1-alex.bennee@linaro.org> References: <20180221110523.859-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 22/22] fpu/softfloat: re-factor sqrt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This is a little bit of a departure from softfloat's original approach as we skip the estimate step in favour of a straight iteration. There is a minor optimisation to avoid calculating more bits of precision than we need however this still brings a performance drop, especially for float64 operations. Suggested-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 4bc425d7e4..e7fb0d357a 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1896,6 +1896,102 @@ float64 float64_scalbn(float64 a, int n, float_stat= us *status) return float64_round_pack_canonical(pr, status); } =20 +/* + * Square Root + * + * The old softfloat code did an approximation step before zeroing in + * on the final result. However for simpleness we just compute the + * square root by iterating down from the implicit bit to enough extra + * bits to ensure we get a correctly rounded result. + * + * This does mean however the calculation is slower than before, + * especially for 64 bit floats. + */ + +static FloatParts sqrt_float(FloatParts a, float_status *s, const FloatFmt= *p) +{ + uint64_t a_frac, r_frac, s_frac; + int bit, last_bit; + + if (is_nan(a.cls)) { + return return_nan(a, s); + } + if (a.cls =3D=3D float_class_zero) { + return a; /* sqrt(+-0) =3D +-0 */ + } + if (a.sign) { + s->float_exception_flags |=3D float_flag_invalid; + a.cls =3D float_class_dnan; + return a; + } + if (a.cls =3D=3D float_class_inf) { + return a; /* sqrt(+inf) =3D +inf */ + } + + assert(a.cls =3D=3D float_class_normal); + + /* We need two overflow bits at the top. Adding room for that is a + * right shift. If the exponent is odd, we can discard the low bit + * by multiplying the fraction by 2; that's a left shift. Combine + * those and we shift right if the exponent is even. + */ + a_frac =3D a.frac; + if (!(a.exp & 1)) { + a_frac >>=3D 1; + } + a.exp >>=3D 1; + + /* Bit-by-bit computation of sqrt. */ + r_frac =3D 0; + s_frac =3D 0; + + /* Iterate from implicit bit down to the 3 extra bits to compute a + * properly rounded result. Remember we've inserted one more bit + * at the top, so these positions are one less. + */ + bit =3D DECOMPOSED_BINARY_POINT - 1; + last_bit =3D MAX(p->frac_shift - 4, 0); + do { + uint64_t q =3D 1ULL << bit; + uint64_t t_frac =3D s_frac + q; + if (t_frac <=3D a_frac) { + s_frac =3D t_frac + q; + a_frac -=3D t_frac; + r_frac +=3D q; + } + a_frac <<=3D 1; + } while (--bit >=3D last_bit); + + /* Undo the right shift done above. If there is any remaining + * fraction, the result is inexact. Set the sticky bit. + */ + a.frac =3D (r_frac << 1) + (a_frac !=3D 0); + + return a; +} + +float16 __attribute__((flatten)) float16_sqrt(float16 a, float_status *sta= tus) +{ + FloatParts pa =3D float16_unpack_canonical(a, status); + FloatParts pr =3D sqrt_float(pa, status, &float16_params); + return float16_round_pack_canonical(pr, status); +} + +float32 __attribute__((flatten)) float32_sqrt(float32 a, float_status *sta= tus) +{ + FloatParts pa =3D float32_unpack_canonical(a, status); + FloatParts pr =3D sqrt_float(pa, status, &float32_params); + return float32_round_pack_canonical(pr, status); +} + +float64 __attribute__((flatten)) float64_sqrt(float64 a, float_status *sta= tus) +{ + FloatParts pa =3D float64_unpack_canonical(a, status); + FloatParts pr =3D sqrt_float(pa, status, &float64_params); + return float64_round_pack_canonical(pr, status); +} + + /*------------------------------------------------------------------------= ---- | Takes a 64-bit fixed-point value `absZ' with binary point between bits 6 | and 7, and returns the properly rounded 32-bit integer corresponding to = the @@ -3303,62 +3399,6 @@ float32 float32_rem(float32 a, float32 b, float_stat= us *status) } =20 =20 -/*------------------------------------------------------------------------= ---- -| Returns the square root of the single-precision floating-point value `a'. -| The operation is performed according to the IEC/IEEE Standard for Binary -| Floating-Point Arithmetic. -*-------------------------------------------------------------------------= ---*/ - -float32 float32_sqrt(float32 a, float_status *status) -{ - flag aSign; - int aExp, zExp; - uint32_t aSig, zSig; - uint64_t rem, term; - a =3D float32_squash_input_denormal(a, status); - - aSig =3D extractFloat32Frac( a ); - aExp =3D extractFloat32Exp( a ); - aSign =3D extractFloat32Sign( a ); - if ( aExp =3D=3D 0xFF ) { - if (aSig) { - return propagateFloat32NaN(a, float32_zero, status); - } - if ( ! aSign ) return a; - float_raise(float_flag_invalid, status); - return float32_default_nan(status); - } - if ( aSign ) { - if ( ( aExp | aSig ) =3D=3D 0 ) return a; - float_raise(float_flag_invalid, status); - return float32_default_nan(status); - } - if ( aExp =3D=3D 0 ) { - if ( aSig =3D=3D 0 ) return float32_zero; - normalizeFloat32Subnormal( aSig, &aExp, &aSig ); - } - zExp =3D ( ( aExp - 0x7F )>>1 ) + 0x7E; - aSig =3D ( aSig | 0x00800000 )<<8; - zSig =3D estimateSqrt32( aExp, aSig ) + 2; - if ( ( zSig & 0x7F ) <=3D 5 ) { - if ( zSig < 2 ) { - zSig =3D 0x7FFFFFFF; - goto roundAndPack; - } - aSig >>=3D aExp & 1; - term =3D ( (uint64_t) zSig ) * zSig; - rem =3D ( ( (uint64_t) aSig )<<32 ) - term; - while ( (int64_t) rem < 0 ) { - --zSig; - rem +=3D ( ( (uint64_t) zSig )<<1 ) | 1; - } - zSig |=3D ( rem !=3D 0 ); - } - shift32RightJamming( zSig, 1, &zSig ); - roundAndPack: - return roundAndPackFloat32(0, zExp, zSig, status); - -} =20 /*------------------------------------------------------------------------= ---- | Returns the binary exponential of the single-precision floating-point va= lue @@ -4202,61 +4242,6 @@ float64 float64_rem(float64 a, float64 b, float_stat= us *status) =20 } =20 - -/*------------------------------------------------------------------------= ---- -| Returns the square root of the double-precision floating-point value `a'. -| The operation is performed according to the IEC/IEEE Standard for Binary -| Floating-Point Arithmetic. -*-------------------------------------------------------------------------= ---*/ - -float64 float64_sqrt(float64 a, float_status *status) -{ - flag aSign; - int aExp, zExp; - uint64_t aSig, zSig, doubleZSig; - uint64_t rem0, rem1, term0, term1; - a =3D float64_squash_input_denormal(a, status); - - aSig =3D extractFloat64Frac( a ); - aExp =3D extractFloat64Exp( a ); - aSign =3D extractFloat64Sign( a ); - if ( aExp =3D=3D 0x7FF ) { - if (aSig) { - return propagateFloat64NaN(a, a, status); - } - if ( ! aSign ) return a; - float_raise(float_flag_invalid, status); - return float64_default_nan(status); - } - if ( aSign ) { - if ( ( aExp | aSig ) =3D=3D 0 ) return a; - float_raise(float_flag_invalid, status); - return float64_default_nan(status); - } - if ( aExp =3D=3D 0 ) { - if ( aSig =3D=3D 0 ) return float64_zero; - normalizeFloat64Subnormal( aSig, &aExp, &aSig ); - } - zExp =3D ( ( aExp - 0x3FF )>>1 ) + 0x3FE; - aSig |=3D LIT64( 0x0010000000000000 ); - zSig =3D estimateSqrt32( aExp, aSig>>21 ); - aSig <<=3D 9 - ( aExp & 1 ); - zSig =3D estimateDiv128To64( aSig, 0, zSig<<32 ) + ( zSig<<30 ); - if ( ( zSig & 0x1FF ) <=3D 5 ) { - doubleZSig =3D zSig<<1; - mul64To128( zSig, zSig, &term0, &term1 ); - sub128( aSig, 0, term0, term1, &rem0, &rem1 ); - while ( (int64_t) rem0 < 0 ) { - --zSig; - doubleZSig -=3D 2; - add128( rem0, rem1, zSig>>63, doubleZSig | 1, &rem0, &rem1 ); - } - zSig |=3D ( ( rem0 | rem1 ) !=3D 0 ); - } - return roundAndPackFloat64(0, zExp, zSig, status); - -} - /*------------------------------------------------------------------------= ---- | Returns the binary log of the double-precision floating-point value `a'. | The operation is performed according to the IEC/IEEE Standard for Binary diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index cebe37b716..9b7b5e34e2 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -251,6 +251,7 @@ float16 float16_minnum(float16, float16, float_status *= status); float16 float16_maxnum(float16, float16, float_status *status); float16 float16_minnummag(float16, float16, float_status *status); float16 float16_maxnummag(float16, float16, float_status *status); +float16 float16_sqrt(float16, float_status *status); int float16_compare(float16, float16, float_status *status); int float16_compare_quiet(float16, float16, float_status *status); =20 --=20 2.15.1